-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix: autofill on the BaseExpensiInput #4632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Don't forget to CP it or remove the issue from deployblocker list. |
|
|
|
testing now @parasharrajat |
|
Ignoring the Company Address field since I'm fixing that elsewhere 👍 |
Jag96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one request for jsdocs
| this.deactivateLabel(); | ||
| } | ||
|
|
||
| setValue(v) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add jsdoc for param type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Fix: autofill on the BaseExpensiInput (cherry picked from commit ea0fb88)
|
🚀 Cherry-picked to staging by @Jag96 in version: 1.0.85-4 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
|
This has been deployed to production and is now subject to a 7-day regression period. |
|
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |

Details
Fixed Issues
$ Fixes #4597
Tests | QA Steps
Tested On
Screenshots
Web | Mobile Web | Desktop