Skip to content

Revert "Emojis larger in other contexts than just single character messages" #46463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roryabraham merged 1 commit into from
Jul 30, 2024
Merged

Revert "Emojis larger in other contexts than just single character messages" #46463

roryabraham merged 1 commit into from
Jul 30, 2024

Conversation

@marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Jul 29, 2024 •
edited
Loading

@marcochavezf marcochavezf requested review from a team as code owners July 29, 2024 23:53
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2024

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot melvin-bot bot requested review from luacmartins and removed request for a team July 29, 2024 23:53
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2024

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marcochavezf marcochavezf mentioned this pull request Jul 29, 2024
Closed
6 tasks
@shawnborton
Copy link
Contributor

shawnborton commented Jul 30, 2024

Works for me too, do you have the associated bug report or deploy blocker handy? Just curious what went wrong with this one.

@mkhutornyi
Copy link
Contributor

mkhutornyi commented Jul 30, 2024

Works for me too, do you have the associated bug report or deploy blocker handy? Just curious what went wrong with this one.

https://expensify.slack.com/archives/C01GTK53T8Q/p1722321575027469?thread_ts=1722282538.734549&cid=C01GTK53T8Q

@iwiznia iwiznia mentioned this pull request Jul 30, 2024
Closed
6 tasks
@roryabraham
Copy link
Contributor

roryabraham commented Jul 30, 2024

skipping checklists for straight revert

@roryabraham roryabraham merged commit 3257e2f into main Jul 30, 2024
@roryabraham roryabraham deleted the revert-40692-feat/enlarge-emojis-font-size branch July 30, 2024 15:18
@melvin-bot melvin-bot bot added the Emergency label Jul 30, 2024
@melvin-bot
Copy link

melvin-bot bot commented Jul 30, 2024

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Jul 30, 2024
@roryabraham @OSBotify
Merge pull request #46463 from Expensify/revert-40692-feat/enlarge-em…
005cbad 
…ojis-font-size

Revert "Emojis larger in other contexts than just single character messages"

(cherry picked from commit 3257e2f)
@VickyStash VickyStash mentioned this pull request Jul 30, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Closed
84 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jul 30, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/46463/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/46463/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/46463/NewExpensify.dmg https://46463.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Contributor

OSBotify commented Jul 30, 2024

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@francoisl francoisl mentioned this pull request Jul 30, 2024
Closed
6 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jul 31, 2024

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@VickyStash VickyStash mentioned this pull request Aug 7, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luacmartins luacmartins luacmartins approved these changes

@dubielzyk-expensify dubielzyk-expensify dubielzyk-expensify approved these changes

Assignees

No one assigned

Labels

Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@marcochavezf @shawnborton @mkhutornyi @roryabraham @OSBotify @luacmartins @dubielzyk-expensify