[NoQA] Tests for group chat name by ShridharGoel · Pull Request #46661 · Expensify/App

ShridharGoel · 2024-08-01T12:40:41Z

Details

Tests for group chat name.

Fixed Issues

$ #40189
PROPOSAL: #40189 (comment)

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-08-01T12:40:46Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2024-08-01T12:41:41Z

@marcaaron Last one was reverted because of some workflow issues, can you check this?

s77rt · 2024-08-01T15:57:07Z

@ShridharGoel What caused the workflow issues?

ShridharGoel · 2024-08-01T16:37:03Z

Some typecheck issues after getting merged (checks had passed in the old PR). #40658 (comment)

s77rt · 2024-08-01T17:10:00Z

Can you please point to the changes that fixed the workflow issues?

s77rt · 2024-08-06T00:12:54Z

@ShridharGoel Did you get a chance to check my above comment? (Also please fix ts errors)

ShridharGoel · 2024-08-09T20:36:46Z

I think the issue was that the signature of getGroupChatName method was changed from accepting reportID to accepting report.

s77rt · 2024-08-10T16:31:52Z

@ShridharGoel Can you please fix the ts errors

s77rt · 2024-08-23T03:28:37Z

@ShridharGoel Any updates on this?

ShridharGoel · 2024-08-23T12:48:21Z

Updated.

s77rt

Please refer to tests/ui/UnreadIndicatorsTest.tsx once again as the logic get simplified

s77rt · 2024-08-23T19:34:15Z

tests/utils/TestHelper.ts

+    await waitForBatchedUpdatesWithAct();
+}
+
+function beforeAllSetupUITests(shouldConnectToPusher = false) {


This is no longer needed. There is setupApp and setupGlobalFetchMock that does the same

s77rt · 2024-08-23T19:39:54Z

__mocks__/@react-native-reanimated/index.ts

Is this still needed? We have this mock in jest/setup.ts

s77rt · 2024-09-02T04:42:11Z

@ShridharGoel Any updates?

s77rt · 2024-09-09T16:10:42Z

@ShridharGoel Did you get a chance to look into this?

ShridharGoel · 2024-09-10T20:17:55Z

Will check this within 2 days.

s77rt · 2024-10-23T21:30:09Z

@ShridharGoel This PR still needs to be merged Were you able to look into addressing the previous review

s77rt · 2024-10-27T05:33:40Z

tests/ui/GroupChatNameTests.tsx

-beforeAll(() => {
-    TestHelper.beforeAllSetupUITests();
-});


I think we need to call TestHelper.setupApp(); instead

s77rt · 2024-10-29T15:33:30Z

@ShridharGoel Please address #46661 (comment) as well

ShridharGoel · 2024-10-29T16:22:06Z

One test, Should show only 5 names when there are 8 participants in the report header, is failing. I'm checking it, but any idea why all the 8 names are showing instead of 5?

s77rt · 2024-10-29T23:02:18Z

The failing part is related to LHN not the report header. Both are returning 5 items which seems correct (and consist), let's just update the test to reflect that

s77rt · 2024-10-30T14:01:35Z

Can you check why is the UnreadIndicatorsTest failing

s77rt · 2024-10-30T20:32:45Z

tests/ui/UnreadIndicatorsTest.tsx


 // We need a large timeout here as we are lazy loading React Navigation screens and this test is running against the entire mounted App
-jest.setTimeout(30000);
+jest.setTimeout(45000);


Any idea why this is suddenly required?

No, the only change in this file was moving navigateToSidebarOption to TestHelper.

I'm not following. Why are we increasing it?

Because one existing test was failing because of timeout.

s77rt · 2024-11-04T15:30:17Z

@ShridharGoel Please address #46661 (comment)

marcaaron · 2024-11-04T19:22:31Z

@ShridharGoel please give daily updates on this PR until it is merged.

s77rt · 2024-11-04T20:19:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Missed a comment

s77rt · 2024-11-16T11:32:20Z

@ShridharGoel Can you please resolve the conflicts

s77rt · 2024-11-20T08:28:08Z

@marcaaron Can you please merge this

marcaaron · 2024-11-20T20:59:50Z

Yes, but FWIW - I did not find the answer to this question to be very clear... #46661 (comment)

s77rt · 2024-11-20T23:53:08Z

@marcaaron That test was failing randomly on other PRs due to the given timing not being enough. Recently the timeout was increased and this PR no longer modifies it (since it's already enough).

github-actions · 2024-11-21T01:43:41Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-22T19:47:41Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Add tests for group chat name

9f57e20

ShridharGoel requested a review from a team as a code owner August 1, 2024 12:40

melvin-bot bot requested review from s77rt and removed request for a team August 1, 2024 12:40

Update

7b5298a

ShridharGoel added 6 commits August 23, 2024 16:38

Update

a428070

Merge branch 'main' into chat_tests

4716c33

Update TestHelper.ts

e8956bc

Update

3e2f30e

Update

84deb67

Lint fixes

221b3ff

s77rt suggested changes Aug 23, 2024

View reviewed changes

s77rt mentioned this pull request Oct 23, 2024

[HOLD for payment 2024-11-29] [HOLD for payment 2024-06-28] [$250] Add automated tests for getGroupChatName() #40189

Closed

4 tasks

ShridharGoel added 2 commits October 25, 2024 13:42

Merge

3391791

Update

33d1ba3

s77rt reviewed Oct 27, 2024

View reviewed changes

ShridharGoel added 2 commits October 29, 2024 18:36

Merge branch 'main' of https://github.com/Expensify/App into chat_tests

ca814e8

Update

304f0d2

Update

e24e1cc

Update

a8b9955

ShridharGoel added 2 commits October 31, 2024 01:41

Update timeout of UnreadIndicatorsTest.tsx

b64f63d

Update timeout of UnreadIndicatorsTest.tsx

bd9f6e8

s77rt reviewed Oct 30, 2024

View reviewed changes

marcaaron assigned ShridharGoel Nov 4, 2024

s77rt approved these changes Nov 4, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron November 4, 2024 20:22

marcaaron previously approved these changes Nov 4, 2024

View reviewed changes

marcaaron self-requested a review November 4, 2024 23:37

Merge branch 'main' into chat_tests

e9aedb5

marcaaron approved these changes Nov 20, 2024

View reviewed changes

marcaaron merged commit f5fd952 into Expensify:main Nov 20, 2024

github-actions bot mentioned this pull request Nov 21, 2024

Deploy Checklist: New Expensify 2024-11-21 #52862

Closed

65 tasks

Conversation

ShridharGoel commented Aug 1, 2024

Details

Fixed Issues

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 1, 2024

Uh oh!

ShridharGoel commented Aug 1, 2024

Uh oh!

s77rt commented Aug 1, 2024

Uh oh!

ShridharGoel commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Aug 1, 2024

Uh oh!

s77rt commented Aug 6, 2024

Uh oh!

ShridharGoel commented Aug 9, 2024

Uh oh!

s77rt commented Aug 10, 2024

Uh oh!

s77rt commented Aug 23, 2024

Uh oh!

ShridharGoel commented Aug 23, 2024

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

s77rt Aug 23, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt Aug 23, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented Sep 2, 2024

Uh oh!

s77rt commented Sep 9, 2024

Uh oh!

ShridharGoel commented Sep 10, 2024

Uh oh!

s77rt commented Oct 23, 2024

Uh oh!

s77rt Oct 27, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented Oct 29, 2024

Uh oh!

ShridharGoel commented Oct 29, 2024

Uh oh!

s77rt commented Oct 29, 2024

Uh oh!

s77rt commented Oct 30, 2024

Uh oh!

s77rt Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

marcaaron Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented Nov 4, 2024

Uh oh!

marcaaron commented Nov 4, 2024

Uh oh!

s77rt commented Nov 4, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Nov 16, 2024

Uh oh!

s77rt commented Nov 20, 2024

Uh oh!

ShridharGoel commented Aug 1, 2024 •

edited

Loading