Fix composer not focused when pressing key after coming from WS share code page by bernhardoj · Pull Request #46855 · Expensify/App

bernhardoj · 2024-08-06T06:41:13Z

Details

The composer will be focused if there is no modal visible anymore, but when we open the share code page and go to #admins, the RHP is not dismissed. This PR fix it.

Fixed Issues

$ #46206
PROPOSAL: #46206 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open Settings > Workspaces > Select any workspace (or create a new one)
Open Profile > Share
Press the #admins text link
Verify you are navigated to the WS admin chat

(For web/desktop)
5. Click anywhere to remove focus from composer
6. Press any key
7. Verify the composer is focused with the green outline and the key character is added to the composer

(For iOS/Android/mWeb)
8. Press the composer
9. Verify the composer is focused with the green outline

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-08-06T06:41:18Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-08-06T08:57:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

2024-08-06.12.22.01.mov

Android: mWeb Chrome

2024-08-06.11.54.29.mov

iOS: Native

2024-08-06.11.40.50.mov

iOS: mWeb Safari

web-ios.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ZhenjaHorbach · 2024-08-06T10:02:07Z

@bernhardoj
I found bug
In mobile apps, after pressing the back button, we return not to the share screen, but to the profile screen

2024-08-06.11.42.19.mov

ZhenjaHorbach · 2024-08-06T10:07:06Z

And it's strange
In mobile, сomposer doesn't get focused except for Android web

bernhardoj · 2024-08-06T10:33:03Z

In mobile apps, after pressing the back button, we return not to the share screen, but to the profile screen

That's because we dismiss the modal. It's a common pattern to dismiss the RHP when going to report screen.

App/src/pages/ReimbursementAccount/ConnectBankAccount/components/FinishChatCard.tsx

Line 44 in 3775dae

onPress={handleNavigateToConciergeChat}

App/src/pages/ReimbursementAccount/ConnectBankAccount/components/FinishChatCard.tsx

Line 30 in 3775dae

    
           const handleNavigateToConciergeChat = () => Report.navigateToConciergeChat(true);

App/src/libs/actions/Report.ts

Lines 2083 to 2097 in 290a9d9

    
           function navigateToConciergeChat(shouldDismissModal = false, checkIfCurrentPageActive = () => true, actionType?: string) { 
        
               // If conciergeChatReportID contains a concierge report ID, we navigate to the concierge chat using the stored report ID. 
        
               // Otherwise, we would find the concierge chat and navigate to it. 
        
               if (!conciergeChatReportID) { 
        
                   // In order to avoid creating concierge repeatedly, 
        
                   // we need to ensure that the server data has been successfully pulled 
        
                   Welcome.onServerDataReady().then(() => { 
        
                       // If we don't have a chat with Concierge then create it 
        
                       if (!checkIfCurrentPageActive()) { 
        
                           return; 
        
                       } 
        
                       navigateToAndOpenReport([CONST.EMAIL.CONCIERGE], shouldDismissModal, actionType); 
        
                   }); 
        
               } else if (shouldDismissModal) { 
        
                   Navigation.dismissModal(conciergeChatReportID);

Otherwise, the modal.isVisible stays true. Maybe we should set the visibility to false when blurred instead of remove here so we don't need to dismiss RHP anymore?

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 181 to 191 in 3775dae

    
           const modalScreenListeners = { 
        
               focus: () => { 
        
                   Modal.setModalVisibility(true); 
        
               }, 
        
               beforeRemove: () => { 
        
                   // Clear search input (WorkspaceInvitePage) when modal is closed 
        
                   SearchInputManager.searchInput = ''; 
        
                   Modal.setModalVisibility(false); 
        
                   Modal.willAlertModalBecomeVisible(false); 
        
               }, 
        
           };

In mobile apps, my keyboard doesn't open except for Android web

That's weird, the keyboard opens just fine from my side

android.mp4

ZhenjaHorbach · 2024-08-06T10:44:51Z

That's weird, the keyboard opens just fine from my side

Sorry
I wrote a little unclearly
I mean, сomposer doesn't get focused except for Android web

2024-08-06.11.54.29.mov

But as far as I can see in your video
Your composer does not focus

ZhenjaHorbach · 2024-08-06T10:49:30Z

Otherwise, the modal.isVisible stays true. Maybe we should set the visibility to false when blurred instead of remove here so we don't need to dismiss RHP anymore?

This actually sounds like a good idea !

bernhardoj · 2024-08-06T14:36:02Z

I mean, сomposer doesn't get focused except for Android web

Do you mean the auto focus? It'll only auto focus if the chat is empty. From your video, looks like the chat isn't loaded yet, so perhaps it's detected as an empty chat.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 291 to 296 in 41e27c9

    
           const shouldAutoFocus = 
        
               !modal?.isVisible && 
        
               Modal.areAllModalsHidden() && 
        
               isFocused && 
        
               (shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction))) && 
        
               shouldShowComposeInput;

Otherwise, the modal.isVisible stays true. Maybe we should set the visibility to false when blurred instead of remove here so we don't need to dismiss RHP anymore?

Updated. I didn't remove the beforeRemove to reduce risk of regressions. Please check!

ZhenjaHorbach · 2024-08-06T15:04:45Z

Yes
Everything works fine now
Thanks !
Only one small comment left

ZhenjaHorbach · 2024-08-06T15:06:22Z

src/components/FocusTrap/FocusTrapForScreen/index.web.tsx

            return isFocused;
        }

+        if (route.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {


Can you add a bit comment as in other conditions?

I just retested after not dismissing the RHP, this fix isn't needed anymore, so I remove it.

I confirm, everything works
Thanks for cleaning the code

ZhenjaHorbach · 2024-08-06T16:05:41Z

LGTM

OSBotify · 2024-08-07T08:00:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-07T22:13:24Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.18-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-12T10:04:38Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix composer not focused when pressing key

1207094

bernhardoj requested a review from a team as a code owner August 6, 2024 06:41

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team August 6, 2024 06:41

bernhardoj added 2 commits August 6, 2024 22:35

use navigate back

41f006e

set the modal visibility when blurred

fbcfdb7

ZhenjaHorbach reviewed Aug 6, 2024

View reviewed changes

remove unused logic

4f37bc7

ZhenjaHorbach approved these changes Aug 6, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek August 6, 2024 16:05

techievivek approved these changes Aug 7, 2024

View reviewed changes

techievivek assigned bernhardoj Aug 7, 2024

techievivek merged commit bbb09d8 into Expensify:main Aug 7, 2024

github-actions bot mentioned this pull request Aug 7, 2024

Deploy Checklist: New Expensify 2024-08-07 #47006

Closed

88 tasks

IuliiaHerets mentioned this pull request Aug 8, 2024

[HOLD for payment 2024-08-29] [$250] mWeb/Safari - Keypad overlap composer & blank space in header when open admins room from WS share pg #47063

Closed

6 tasks

melvin-bot bot mentioned this pull request Aug 12, 2024

[HOLD for payment 2024-08-19] [$250] Chat Composer - Composer doesn't get focused when coming from share code link #46206

Closed

6 tasks

Conversation

bernhardoj commented Aug 6, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 6, 2024

Uh oh!

ZhenjaHorbach commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Aug 6, 2024

Uh oh!

ZhenjaHorbach commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Aug 6, 2024

Uh oh!

ZhenjaHorbach commented Aug 6, 2024

Uh oh!

ZhenjaHorbach commented Aug 6, 2024

Uh oh!

bernhardoj commented Aug 6, 2024

Uh oh!

ZhenjaHorbach commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Aug 6, 2024

Uh oh!

OSBotify commented Aug 7, 2024

Uh oh!

OSBotify commented Aug 7, 2024

Uh oh!

OSBotify commented Aug 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ZhenjaHorbach commented Aug 6, 2024 •

edited

Loading

ZhenjaHorbach commented Aug 6, 2024 •

edited

Loading

ZhenjaHorbach commented Aug 6, 2024 •

edited

Loading