[Ideal-nav] Fix navigate to search tab by adamgrzybowski · Pull Request #46970 · Expensify/App

adamgrzybowski · 2024-08-07T13:45:55Z

Details

@DylanDylann found a problem similar to the one solved by this PR.

If the user opens the search page and selects a status, it should be remembered if the user goes to another tab and back to the search tab.

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the search tab.
Select a status e.g. Drafts.
Switch the tab to chats.
Go back to the search tab.
Selected status option should stay the same (Drafts)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

androidWeb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

iosWeb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

DylanDylann · 2024-08-07T14:04:35Z

src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

+            return;
+        }
+        interceptAnonymousUser(() => {
+            const currentSearchParams = getCurrentSearchParams();


Oops, it seems getCurrentSearchParams has never been used in our app

It was used in search but we are still working on this feature. I think the guys refactored the current state of search so it's not used but it's rather a temporary situation.

melvin-bot · 2024-08-07T15:21:35Z

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

adamgrzybowski · 2024-08-07T15:21:57Z

@DylanDylann @luacmartins it should be ready for review.

dangrous

This makes sense to me, but I'd love to have @luacmartins take a look as well since he's much more familiar with the search project

luacmartins

LGTM

luacmartins · 2024-08-07T17:19:41Z

@DylanDylann all yours!

DylanDylann · 2024-08-08T08:26:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-08-08.at.16.34.07.mov

MacOS: Desktop

Screen.Recording.2024-08-08.at.16.36.45.mov

DylanDylann

LGTM 💯

melvin-bot · 2024-08-08T09:38:02Z

🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #47047.

DylanDylann · 2024-08-08T09:39:14Z

src/libs/SearchUtils.ts

+        return lastSearchCentralPaneRoute.params as AuthScreensParamList[typeof SCREENS.SEARCH.CENTRAL_PANE];
+    }
+
+    if (lastSearchBottomTabRoute) {


@adamgrzybowski NAB: I don't see any case which this code block is triggered

Have you tried to run this on mobile?

Ahhh, Thanks

OSBotify · 2024-08-08T10:21:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Beamanator · 2024-08-14T20:54:23Z

FYI I believe this was deployed to prod yesterday, from this checklist - #47219

rojiphil · 2025-02-18T17:00:01Z

src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

        Navigation.navigate(route);
    }, [activeWorkspaceID, selectedTab]);

+    const navigateToSearch = useCallback(() => {


NAB but a super edge case occurs when a double click on web platforms causes selection to persist on other tabs. This required us to clear the selection manually and this was addressed in #54993

fix navigate to search tab

df067e0

DylanDylann reviewed Aug 7, 2024

View reviewed changes

fix saving tab on mobile

822281d

adamgrzybowski marked this pull request as ready for review August 7, 2024 15:21

adamgrzybowski requested a review from a team as a code owner August 7, 2024 15:21

melvin-bot bot requested review from dangrous and removed request for a team August 7, 2024 15:21

dangrous approved these changes Aug 7, 2024

View reviewed changes

luacmartins self-requested a review August 7, 2024 16:46

luacmartins approved these changes Aug 7, 2024

View reviewed changes

luacmartins requested a review from DylanDylann August 7, 2024 17:19

DylanDylann approved these changes Aug 8, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Aug 8, 2024

[$250] Payment issue for E/App PR#46970 #47047

Closed

DylanDylann reviewed Aug 8, 2024

View reviewed changes

luacmartins merged commit 9c7c4a1 into Expensify:main Aug 8, 2024

github-actions bot mentioned this pull request Aug 12, 2024

Deploy Checklist: New Expensify 2024-08-12 #47219

Closed

90 tasks

rojiphil reviewed Feb 18, 2025

View reviewed changes

Conversation

adamgrzybowski commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

DylanDylann Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 7, 2024

Uh oh!

adamgrzybowski commented Aug 7, 2024

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Aug 7, 2024

Uh oh!

DylanDylann commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 8, 2024

Uh oh!

DylanDylann Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski Aug 8, 2024

Choose a reason for hiding this comment

Uh oh!

DylanDylann Aug 8, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 8, 2024

Uh oh!

Beamanator commented Aug 14, 2024

Uh oh!

rojiphil Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

adamgrzybowski commented Aug 7, 2024 •

edited

Loading

DylanDylann commented Aug 8, 2024 •

edited

Loading

DylanDylann Aug 8, 2024 •

edited

Loading