[CP Staging] fix: enforce transaction filename to be a string#47060
[CP Staging] fix: enforce transaction filename to be a string#47060techievivek merged 1 commit intoExpensify:mainfrom
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@shubham1206agra can you please review the PR ASAP, thanks. |
|
I am doing that right now. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeScreen.Recording.2024-08-08.at.6.47.35.PM.moviOS: NativeScreen.Recording.2024-08-08.at.7.03.09.PM.moviOS: mWeb SafariScreen.Recording.2024-08-08.at.6.00.35.PM.movMacOS: Chrome / SafariScreen.Recording.2024-08-08.at.5.56.55.PM.movMacOS: DesktopScreen.Recording.2024-08-08.at.6.53.53.PM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
fix: enforce transaction filename to be a string (cherry picked from commit d7b0aba)
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.18-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
False alert. Since we did not change anything that affects performance. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀
|
Details
Fixed Issues
$ #47022
PROPOSAL: #47022 (comment)
Tests
Verify that: The receipt is displayed, and app won't crash
Offline tests
QA Steps
Verify that: The receipt is displayed, and app won't crash
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
compressed_android.webm.mp4
Android: mWeb Chrome
compressed_aweb.webm.mp4
iOS: Native
compressed_ios.mp4.mp4
iOS: mWeb Safari
compressed_iosweb.mp4.mp4
MacOS: Chrome / Safari
compressed_web.mov.mp4
MacOS: Desktop
compressed_web.mov.mp4