[No QA] Update redirects.csv - URGENT#47127
Conversation
|
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
|
@RachCHopkins the build is failing because there are multiple redirects from the same address. This already existed: Can you please delete whichever one should not be there? As soon as that's done I'll merge :) |
|
Done, thank you @stitesExpensify ! |
|
A preview of your ExpensifyHelp changes have been deployed to https://2c96df37.helpdot.pages.dev ⚡️ |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.0.23-0 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.23-0 🚀
|
Details
Adding redirects for pages missed last year - old help site is now defunct, so this is pretty urgent.
Fixed Issues
https://github.com/Expensify/Expensify/issues/416557
Tests
Make sure https://community.expensify.com/discussion/7385/how-to-enable-two-factor-authentication-in-your-account goes to https://help.expensify.com/articles/expensify-classic/settings/Enable-two-factor-authentication
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined