fix: default the selected tab to scan by dominictb · Pull Request #47310 · Expensify/App

dominictb · 2024-08-13T11:25:39Z

in iou request start page

Details

Fixed Issues

$ #46916
PROPOSAL: #46916 (comment)

Tests

Login to a new account (Or clear the Onyx state in the troubleshooting settings
Navigate to the app on either the mobile or web platform.
Open Global create > Tap submit expense

Verify that the default selected tab is Scan

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to a new account (Or clear the Onyx state in the troubleshooting settings
Navigate to the app on either the mobile or web platform.
Open Global create > Tap submit expense

Verify that the default selected tab is Scan

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

compressed_android.webm.mp4

Android: mWeb Chrome

compressed_aweb.webm.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

compressed_iosweb.mp4.mp4

MacOS: Chrome / Safari

compressed_web.mov.mp4

MacOS: Desktop

compressed_web.mov.mp4

in iou request start page

melvin-bot · 2024-08-13T11:26:10Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2024-08-13T11:30:56Z

shoot sorry @blimpich . I set the wrong PR template. One moment

this PR should be for @brunovjk

src/libs/Navigation/OnyxTabNavigator.tsx

trjExpensify · 2024-08-14T12:14:40Z

Kicking Ben off, Vit is assigned to the parent issue.

brunovjk · 2024-08-14T17:16:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

47310_android_native.mov

Android: mWeb Chrome

47310_android_web.mov

iOS: Native

47310_ios_native.mov

iOS: mWeb Safari

47310_ios_web.mov

MacOS: Chrome / Safari

47310_chorme_web.mov

MacOS: Desktop

47310_chorme_desktop.mov

src/CONST.ts

dominictb · 2024-08-16T05:19:06Z

updated!

fabioh8010

minor comment!

src/libs/Navigation/OnyxTabNavigator.tsx

brunovjk · 2024-08-16T11:00:41Z

Thanks for the changes, testing on multiple platforms.

brunovjk

The code changes look good to me, but sometimes when I start a request there's a flickering before it settles on the selected tab or default one. This issue wasn't introduced or fixed by this PR, as I can reproduce it in both staging and production:

staging

staging_chorme_web.mov

prod

prod_chorme_web.mov

I believe it will be fixed here.

mountiny

Perfect thank you!

OSBotify · 2024-08-20T07:42:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-20T22:58:37Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-22T17:12:00Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rayane-d · 2024-10-19T18:19:04Z

src/libs/Navigation/OnyxTabNavigator.tsx

+    if (isLoadingOnyxValue(selectedTabResult)) {
+        return null;
+    }


FYI, this issue #50098 was a missed case in this PR. More details can be found in this proposal: #50098 (comment)

fix: default the selected tab to scan

f13c83c

in iou request start page

dominictb requested a review from a team as a code owner August 13, 2024 11:25

melvin-bot bot requested a review from blimpich August 13, 2024 11:26

melvin-bot bot removed the request for review from a team August 13, 2024 11:26

brunovjk reviewed Aug 13, 2024

View reviewed changes

src/libs/Navigation/OnyxTabNavigator.tsx Show resolved Hide resolved

trjExpensify requested review from mountiny and removed request for blimpich August 14, 2024 12:14

mountiny assigned dominictb Aug 14, 2024

mountiny reviewed Aug 14, 2024

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

fix: remove onyx fetching status const

a05957a

fabioh8010 reviewed Aug 16, 2024

View reviewed changes

src/libs/Navigation/OnyxTabNavigator.tsx Outdated Show resolved Hide resolved

fix: update variable name

1ea06e8

dominictb requested review from brunovjk, fabioh8010, mountiny and trjExpensify August 16, 2024 09:37

fabioh8010 approved these changes Aug 16, 2024

View reviewed changes

brunovjk approved these changes Aug 16, 2024

View reviewed changes

mountiny approved these changes Aug 20, 2024

View reviewed changes

mountiny merged commit 0e4f02e into Expensify:main Aug 20, 2024

dominictb deleted the fix/46916-default-scan branch August 20, 2024 14:02

github-actions bot mentioned this pull request Aug 20, 2024

Deploy Checklist: New Expensify 2024-08-20 #47760

Closed

38 tasks

brunovjk mentioned this pull request Aug 21, 2024

[HOLD for payment 2024-08-29] [CVP] [$250] Default Selected Tab is Scan when submitting an expense #46916

Closed

6 tasks

rayane-d reviewed Oct 19, 2024

View reviewed changes

rayane-d mentioned this pull request Oct 19, 2024

[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] [$250] Android - IOS - It flickers when I open the manual submit expense twice or more #50098

Closed

6 tasks

Conversation

dominictb commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 13, 2024

Uh oh!

dominictb commented Aug 13, 2024

Uh oh!

Uh oh!

trjExpensify commented Aug 14, 2024

Uh oh!

brunovjk commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

dominictb commented Aug 16, 2024

Uh oh!

fabioh8010 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brunovjk commented Aug 16, 2024

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 20, 2024

Uh oh!

OSBotify commented Aug 20, 2024

Uh oh!

OSBotify commented Aug 22, 2024

Uh oh!

rayane-d Oct 19, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dominictb commented Aug 13, 2024 •

edited

Loading

brunovjk commented Aug 14, 2024 •

edited

Loading