Make onboarding continue from last visited onboarding page by tsa321 · Pull Request #47472 · Expensify/App

tsa321 · 2024-08-15T02:49:14Z

Details

Fixed Issues

$ #46104
PROPOSAL: #46104 (comment)

Tests

Sign in as a new user -> Join
Verify that the onboarding modal is displayed.
Select Manage my team's expenses.
Change the URL to a random URL after .com, for example, /aaa (for desktop, enter the URL in the browser as new-expensify:/aaa and press Enter).
Verify that the onboarding modal work page is displayed.
Change the URL after .com to /settings/profile (for desktop, enter the URL in the browser as new-expensify:/settings/profile and press Enter).
Verify that the onboarding modal work page is displayed.
Fill in the business name and click Continue.
Complete the onboarding flow.
Verify that the explanation modal appears properly.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Sign in as a new user -> Join
Verify that the onboarding modal is displayed.
Select Manage my team's expenses.
Change the URL to a random URL after .com, for example, /aaa (for desktop, enter the URL in the browser as new-expensify:/aaa and press Enter).
Verify that the onboarding modal work page is displayed.
Change the URL after .com to /settings/profile (for desktop, enter the URL in the browser as new-expensify:/settings/profile and press Enter).
Verify that the onboarding modal work page is displayed.
Fill in the business name and click Continue.
Complete the onboarding flow.
Verify that the explanation modal appears properly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-d.mp4

Android: mWeb Chrome

android-mweb_d.mp4

iOS: Native

ios-native_d.mp4

iOS: mWeb Safari

ios-msfari_d.mp4

MacOS: Chrome / Safari

macos-web-d.mp4

MacOS: Desktop

macos-desktop_d.mp4

melvin-bot · 2024-08-15T02:49:19Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tsa321 · 2024-08-15T02:59:10Z

@mollfpr In android and ios native, the LAST_VISITED_PATH is always cleared when starting the app:

App/src/setup/index.ts

Lines 42 to 43 in 57ef25c

    
           // Always open the home route on app startup for native platforms by clearing the lastVisitedPath 
        
           [ONYXKEYS.LAST_VISITED_PATH]: initializeLastVisitedPath(),

The initializeLastVisitedPath() function returns an empty string for native. The Android and iOS video tests I attached above were conducted after I removed that line.

To address this, should we create a new Onyx key, lastVisitedOnboardingPath, and update it near updateLastVisitedPath when the path starts with /onboarding?

tsa321 · 2024-08-15T03:13:15Z

src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

-                const {adaptedState} = getAdaptedStateFromPath(ROUTES.ONBOARDING_ROOT.route, linkingConfig.config);
-                navigationRef.resetRoot(adaptedState);
+                Navigation.resetToHome();
+                Navigation.navigate(Welcome.getInitialOnboardingPath());


I am changing this line to Navigation.resetHome because it causes some bugs when I use the same code in welcome of Report.openReportFromDeepLink:

Back to personal details

back_to_personal_detaisl-d.mp4

Click next on purpose back to purpose:

click_next_back_to_purpose-d.mp4

tsa321 · 2024-08-15T03:16:30Z

src/libs/actions/Report.ts

-                            Welcome.isOnboardingFlowCompleted({onNotCompleted: () => Navigation.navigate(ROUTES.ONBOARDING_ROOT.getRoute())});
+                            Welcome.isOnboardingFlowCompleted({
+                                onNotCompleted: () => {
+                                    Navigation.resetToHome();


This will fix the issue where a random URL leads to a "not-found" screen and the onboarding modal will disappears after clicking "next" on the purpose page, as mentioned in the issue.

tsa321 · 2024-08-15T03:23:35Z

@mollfpr, there is also a bug in the main: when a user fills out the work page/business name, clicks "continue" to go to the personal details page, then refreshes the page and clicks the back button, the purpose page is displayed instead of the work page. So I think this is out of scope.

back to purpose instead of work page:

back_to_purpose.mp4

mollfpr · 2024-08-18T14:55:06Z

Sorry for the delay 🙏

To address this, should we create a new Onyx key, lastVisitedOnboardingPath, and update it near updateLastVisitedPath when the path starts with /onboarding?

Yes! I think we can implement the original proposal.

tsa321 · 2024-08-19T01:11:15Z

@mollfpr I have added the onboarding last visited path on onyx.

mollfpr

Sorry for the delay! Mostly the changes and the result look good, but I have an issue after signing up the onboarding modal is not showing until I refresh the page.

Screen.Recording.2024-08-22.at.21.10.52.mp4

mollfpr · 2024-08-20T07:21:01Z

src/libs/actions/Welcome.ts

+        }
+
+        onboardingInitialPath = value.substring(1);
+        Onyx.disconnect(onboardingLastVisitedPathConnection);


Why do we need to disconnect here?

Because we only need the initial value when the user opens the app or URL. I have tested it, the onboarding is triggered from bottomTabBar and openReportFromDeepLink, leading to navigation changes that affect the lastVisitedPath and will open incorrect page.

tsa321 · 2024-08-22T15:14:30Z

Sorry for the delay! Mostly the changes and the result look good, but I have an issue after signing up the onboarding modal is not showing until I refresh the page.
Screen.Recording.2024-08-22.at.21.10.52.mp4

I tested mostly on legacy mode.
I will try in strict mode.

mollfpr · 2024-08-22T16:12:33Z

Thanks for the investigation @tsa321!

Sure, I'll give it a try! Just wondering if this will be the production build or not.

tsa321 · 2024-08-22T16:16:59Z

@mollfpr The double mount is in Dev mode, more info in: PR
In production, the double mount won't be happening.

tsa321 · 2024-08-24T09:25:21Z

@mollfpr Please disregard my previous comment here.

The correct way to disable strict mode is, in this line:

App/src/CONFIG.ts

Line 99 in 42bed64

USE_REACT_STRICT_MODE: true,

Change the value to false.

I have squashed all the commits to make the history cleaner.
Could you review this PR again? Thank you...

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 · 2024-08-25T02:41:57Z

src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

-            Navigation.dismissModal();
+            // Navigate to HOME instead of dismissModal, because there is bug in small screen
+            // where the onboarding puropose page will be disaplayed briefly
+            Navigation.navigate(ROUTES.HOME);


I am changing dismissModal to navigate HOME because there is a bug:

Onboarding purpose disaplyed briefly:

home-instead-of-dismiss-d.mp4

tsa321 · 2024-08-25T02:52:39Z

src/libs/actions/Welcome.ts

 }

+function startOnboardingFlow() {
+    const {adaptedState} = getAdaptedStateFromPath(getOnboardingInitialPath(), linkingConfig.config, false);


I really need to add an optional parameter to getAdaptedStateFromPath because it is causing this bug:

The path is being appended to the URL inserted by the user:

Incorrect URL path:

incorrect-path-d.mp4

tsa321 · 2024-08-25T02:53:26Z

src/libs/actions/Welcome.ts

+            isOnboardingInProgress = false;
            onCompleted?.();
-        } else {
+        } else if (!isOnboardingInProgress) {


Prevents multiple onboarding flow running causing navigation issue.

tsa321 · 2024-08-25T02:55:25Z

src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

 }

-const getAdaptedStateFromPath: GetAdaptedStateFromPath = (path, options) => {
+const getAdaptedStateFromPath: GetAdaptedStateFromPath = (path, options, shouldReplacePathInNestedState = true) => {


I am adding an optional parameter here, I really need it, more info here.

tsa321 · 2024-08-25T02:59:59Z

@mollfpr, PR is ready for review again. Just a reminder:

To test, disable strict mode on this line:

App/src/CONFIG.ts

Line 99 in 42bed64

USE_REACT_STRICT_MODE: true,

Change the value to false. This is what we will see in staging/production.

mollfpr · 2024-08-27T18:59:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

47472.Android.mp4

Android: mWeb Chrome

47472.mWeb-Chrome.mp4

iOS: Native

47472.iOS.mov

iOS: mWeb Safari

47472.Safari.mov

MacOS: Chrome / Safari

47472.Web.mp4

MacOS: Desktop

47472.Desktop.mp4

mollfpr

LGTM 👍

Also, the result on web still good under the strict mode true.

chiragsalian · 2024-08-27T23:55:38Z

I had to revert this PR since it caused a number of workflow failures. Please create another PR and ensure you are up to date so that GH actions runs on the latest code 🙂

OSBotify · 2024-08-28T21:44:18Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.26-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-08-30T02:33:38Z

Failing with #46104 in all the platforms
https://platform.applause.com/services/links/v1/external/1e855cf90afa8dff243652c587dec04870d36cf5f4b9c7aedfffe2698bd45443
https://platform.applause.com/services/links/v1/external/c9c861956a92135eb0b12d423761c87e678bf38d0878ed814f4d92945daa5ff9
https://platform.applause.com/services/links/v1/external/3f33d7db7636972ccbc944e0d44476812510d0b0f440a5115a976e0f552816a7
https://platform.applause.com/services/links/v1/external/2aec3037698d6230b0de53966f61bdf35fcd6420f42ea3fe3215ee29f0dd70f9
https://platform.applause.com/services/links/v1/external/0813f213057f837be6d103f1df6455478def54860294ea0f8e1ff52f543bdae3

tsa321 · 2024-08-30T03:16:12Z

@kavimuru, yes, this was reverted by #48135 due to lint and typecheck errors during merging.

Maybe next time, we might want to change the title to No QA Reverted?

OSBotify · 2024-08-30T18:32:46Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tsa321 requested a review from a team as a code owner August 15, 2024 02:49

melvin-bot bot requested review from mollfpr and removed request for a team August 15, 2024 02:49

tsa321 commented Aug 15, 2024

View reviewed changes

mollfpr reviewed Aug 22, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

Make onboarding continue from last visited onboarding page

7a13a23

tsa321 force-pushed the fixOnboardingURLChange branch from dded728 to 7a13a23 Compare August 24, 2024 09:17

tsa321 added 2 commits August 24, 2024 23:39

Fix navigation issues

070e24b

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Remove unnecessary line

1a1e96d

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 requested a review from mollfpr August 24, 2024 16:56

This comment was marked as outdated.

Sign in to view

Fix navigation issues across platforms

f7d800b

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 commented Aug 25, 2024

View reviewed changes

mollfpr approved these changes Aug 27, 2024

View reviewed changes

melvin-bot bot requested a review from chiragsalian August 27, 2024 19:04

chiragsalian approved these changes Aug 27, 2024

View reviewed changes

chiragsalian merged commit 25ed997 into Expensify:main Aug 27, 2024

This was referenced Aug 27, 2024

Investigate workflow job failing on main: typecheck / typecheck #48132

Closed

Investigate workflow job failing on main: lint / Run ESLint #48133

Closed

Investigate workflow job failing on main: confirmPassingBuild #48134

Closed

chiragsalian mentioned this pull request Aug 27, 2024

Revert "Make onboarding continue from last visited onboarding page" #48135

Merged

github-actions bot mentioned this pull request Aug 28, 2024

Deploy Checklist: New Expensify 2024-08-28 #48221

Closed

93 tasks

Conversation

tsa321 commented Aug 15, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 15, 2024

Uh oh!

tsa321 commented Aug 15, 2024

Uh oh!

tsa321 Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsa321 Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

tsa321 commented Aug 15, 2024

Uh oh!

mollfpr commented Aug 18, 2024

Uh oh!

tsa321 commented Aug 19, 2024

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

tsa321 Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsa321 commented Aug 22, 2024

Uh oh!

This comment was marked as outdated.

mollfpr commented Aug 22, 2024

Uh oh!

tsa321 commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsa321 commented Aug 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

tsa321 Aug 25, 2024

Choose a reason for hiding this comment

Uh oh!

tsa321 Aug 25, 2024

Choose a reason for hiding this comment

Uh oh!

tsa321 Aug 25, 2024

Choose a reason for hiding this comment

Uh oh!

tsa321 Aug 25, 2024

Choose a reason for hiding this comment

Uh oh!

tsa321 commented Aug 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

chiragsalian commented Aug 27, 2024

Uh oh!

OSBotify commented Aug 28, 2024

Uh oh!

kavimuru commented Aug 30, 2024

Uh oh!

tsa321 commented Aug 30, 2024

Uh oh!

tsa321 Aug 15, 2024 •

edited

Loading

tsa321 Aug 22, 2024 •

edited

Loading

tsa321 commented Aug 22, 2024 •

edited

Loading

tsa321 commented Aug 24, 2024 •

edited

Loading

tsa321 commented Aug 25, 2024 •

edited

Loading

mollfpr commented Aug 27, 2024 •

edited

Loading