Support INTEGRATIONSYNCFAILED actions by arosiclair · Pull Request #47510 · Expensify/App

arosiclair · 2024-08-15T17:21:26Z

HELD on:
- https://github.com/Expensify/Auth/pull/12028
- https://github.com/Expensify/Web-Expensify/pull/43149

Details

Renders INTEGRATIONSYNCFAILED actions which are posted to the #admins room when the last sync fails.

Fixed Issues

$ #46985

Tests

Create a workspace with a QBO connection
Log into QBO and disconnect the Expensify app (Menu > Apps > Overview > Expensify 3-dot menu > Disconnect)
Log into NewDot as the admin
Avatar > Workspaces > [Workspace name] > Accounting > QBO > 3-dot menu > Sync Now
Wait for the sync to fail and display an error message
Go to the #admins room for the policy
Verify there is a message for the sync failure

Offline tests

None

QA Steps

Same as Tests\

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ration-sync-failed

arosiclair · 2024-08-21T16:24:50Z

Backend PRs are deployed this is ready for review!

melvin-bot · 2024-08-21T16:24:57Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair · 2024-08-21T16:25:58Z

@hungvu193 are you available to review this one?

hungvu193 · 2024-08-21T16:34:06Z

@hungvu193 are you available to review this one?

Yeah. Reviewing shortly 👀

hungvu193

This is looking good. There's small issue that we also need to format our clipboard for INTEGRATION_SYNC_FAILED action, otherwise it will return English clipboard even we switched to Spanish.

Screen.Recording.2024-08-21.at.23.54.11.mov

arosiclair · 2024-08-21T19:15:31Z

Should be fixed now

hungvu193 · 2024-08-22T02:54:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-22.at.09.51.36.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-08-22.at.09.18.56.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desktop.mov

hungvu193

LGTM!

melvin-bot · 2024-08-22T02:55:19Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote · 2024-08-22T08:34:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

lakchote

LGTM!

OSBotify · 2024-08-22T08:53:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-22T17:28:34Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.24-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-08-22T19:33:21Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.24-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-08-26T22:59:53Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane · 2024-10-23T23:32:27Z

src/languages/en.ts

                stripePaid: ({amount, currency}: StripePaidParams) => `paid ${currency}${amount}`,
                takeControl: `took control`,
                unapproved: ({amount, currency}: UnapprovedParams) => `unapproved ${currency}${amount}`,
+                integrationSyncFailed: (label: string, errorMessage: string) => `failed to sync with ${label} ("${errorMessage}")`,


bug: if error message is empty, we'll display empty parentheses.
#49373 (comment)

hoangzinh · 2025-06-11T14:21:45Z

Coming from #62217 (comment), it seems we missed adding for LHN and report header case. We covered them here #62847

render INTEGRATIONSYNCFAILED actions

b0e256f

arosiclair self-assigned this Aug 15, 2024

arosiclair mentioned this pull request Aug 15, 2024

[Awaiting Payment] [$250] [QBO Export] #admins QBO sync error message displays as a report export error #46985

Closed

6 tasks

arosiclair added 2 commits August 19, 2024 16:18

Merge branch 'main' of github.com:Expensify/App into arosiclair-integ…

c0a1d90

…ration-sync-failed

add espanol translation

f7746ea

arosiclair marked this pull request as ready for review August 21, 2024 16:24

arosiclair requested a review from a team as a code owner August 21, 2024 16:24

melvin-bot bot requested review from mkhutornyi and removed request for a team August 21, 2024 16:24

arosiclair requested review from hungvu193 and removed request for mkhutornyi August 21, 2024 16:42

hungvu193 reviewed Aug 21, 2024

View reviewed changes

copy translated text for INTEGRATIONSYNCFAILED actions

b834bc3

arosiclair requested a review from hungvu193 August 21, 2024 19:15

hungvu193 approved these changes Aug 22, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote August 22, 2024 02:55

lakchote approved these changes Aug 22, 2024

View reviewed changes

lakchote merged commit 50de692 into main Aug 22, 2024

lakchote deleted the arosiclair-integration-sync-failed branch August 22, 2024 08:36

github-actions bot mentioned this pull request Aug 22, 2024

Deploy Checklist: New Expensify 2024-08-22 #47873

Closed

50 tasks

rushatgabhane reviewed Oct 23, 2024

View reviewed changes

rushatgabhane mentioned this pull request Oct 23, 2024

[HOLD for payment 2024-10-24] [$125] QBO Desktop - The message is incorrectly formatted after a failed connection #49373

Closed

6 tasks

hoangzinh mentioned this pull request Jun 11, 2025

[Due for payment 2025-06-11] [$125] System message in LHN and report name not translated into Spanish for failed Netsuite connection #62217

Closed

16 tasks

Conversation

arosiclair commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

arosiclair commented Aug 21, 2024

Uh oh!

melvin-bot bot commented Aug 21, 2024

Uh oh!

arosiclair commented Aug 21, 2024

Uh oh!

hungvu193 commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

arosiclair commented Aug 21, 2024

Uh oh!

hungvu193 commented Aug 22, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 22, 2024

Uh oh!

lakchote commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 22, 2024

Uh oh!

OSBotify commented Aug 22, 2024

Uh oh!

OSBotify commented Aug 22, 2024

Uh oh!

OSBotify commented Aug 26, 2024

Uh oh!

rushatgabhane Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Jun 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

arosiclair commented Aug 15, 2024 •

edited

Loading

hungvu193 commented Aug 21, 2024 •

edited

Loading

lakchote commented Aug 22, 2024 •

edited

Loading