[CP Staging] Prevent overflow empty UI and space above skeleton by tienifr · Pull Request #47555 · Expensify/App

tienifr · 2024-08-16T09:26:30Z

Details

Fixes regressions from #42413

Fixed Issues

$ #47553
$ #47524
PROPOSAL:

Tests

Test 1:

Go to staging.new.expensify.com
Go to FAB > Submit expense > Manual
Enter amount
Click Next
Verify there is no empty space between input field and the loading skeleton in participant list.

Test 2:

Navigate to staging.new.expensify.com and sign up with a new Gmail account
Click on FAB > Submit expense
Enter an amount and click next
Verify the illustration becomes fully visible while the keyboard is up

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-16.at.16.14.13.mov

Android: mWeb Chrome

Screen.Recording.2024-08-16.at.16.11.56.mov

iOS: Native

Screen.Recording.2024-08-16.at.15.31.16.mov

iOS: mWeb Safari

Screen.Recording.2024-08-16.at.16.09.38.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-16.at.16.14.47.mov

MacOS: Desktop

Screen.Recording.2024-08-16.at.16.17.19.mov

melvin-bot · 2024-08-16T09:27:05Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-08-16T09:27:21Z

@allroundexperts Pls review this PR

shawnborton · 2024-08-16T11:33:57Z

Seems to look good to me.

Quickly though - do you know why the status bar is green here?

allroundexperts · 2024-08-16T16:05:57Z

@tienifr Can you please add test steps?

Beamanator · 2024-08-16T20:09:55Z

@allroundexperts requesting you review since you were C+ on this PR - #42413

I can help add test steps so we can move forward with this

Beamanator · 2024-08-16T20:10:55Z

Test 1:

Go to staging.new.expensify.com
Go to FAB > Submit expense > Manual
Enter amount
Click Next
Verify there is no empty space between input field and the loading skeleton in participant list.

Test 2:

Navigate to staging.new.expensify.com and sign up with a new Gmail account
Click on FAB > Submit expense
Enter an amount and click next
Verify the illustration becomes fully visible while the keyboard is up

allroundexperts · 2024-08-16T20:13:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-17.at.4.01.25.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-08-17.at.4.00.06.AM.mov

iOS: Native

Screen.Recording.2024-08-17.at.3.58.09.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-08-17.at.3.48.15.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-17.at.3.40.44.AM.mov

MacOS: Desktop

Screen.Recording.2024-08-17.at.3.45.44.AM.mov

allroundexperts · 2024-08-16T23:05:19Z

src/styles/utils/spacing.ts

+        minHeight: 20,
+    },
+
+    minHeight65: {


Is there a reason behind this naming? 65 seems random to me.

Ah, I see. Multiple of 4.

Hmm wouldn't 64 be a multiple of 4?

allroundexperts

Works good!

Prevent overflow empty UI and space above skeleton (cherry picked from commit faf2480) (CP triggered by Beamanator)

OSBotify · 2024-08-17T14:21:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-17T14:46:51Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.21-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-08-19T16:02:13Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-08-19T16:26:37Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Pujan92 · 2025-01-02T17:29:04Z

src/components/EmptySelectionListContent.tsx


    return (
-        <View style={[styles.flex1, styles.overflowHidden]}>
+        <View style={[styles.flex1, styles.overflowHidden, styles.minHeight65]}>


This min-height without ScrollView causes the issue #53689

fix: add minHeight

895cc51

tienifr marked this pull request as ready for review August 16, 2024 09:27

tienifr requested review from a team as code owners August 16, 2024 09:27

melvin-bot bot requested a review from rojiphil August 16, 2024 09:27

melvin-bot bot removed the request for review from a team August 16, 2024 09:27

Beamanator mentioned this pull request Aug 16, 2024

Illustration gets hidden behind the search field #47553

Closed

6 tasks

Beamanator requested review from allroundexperts and removed request for rojiphil August 16, 2024 20:09

allroundexperts reviewed Aug 16, 2024

View reviewed changes

allroundexperts approved these changes Aug 16, 2024

View reviewed changes

melvin-bot bot requested a review from AndrewGable August 16, 2024 23:05

Beamanator approved these changes Aug 17, 2024

View reviewed changes

Beamanator merged commit faf2480 into Expensify:main Aug 17, 2024

Beamanator changed the title ~~Prevent overflow empty UI and space above skeleton~~ [CP Staging] Prevent overflow empty UI and space above skeleton Aug 17, 2024

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Aug 17, 2024

OSBotify pushed a commit that referenced this pull request Aug 17, 2024

Merge pull request #47555 from tienifr/fix/regression-empty-ui

b6121c5

Prevent overflow empty UI and space above skeleton (cherry picked from commit faf2480) (CP triggered by Beamanator)

github-actions bot mentioned this pull request Aug 17, 2024

Deploy Checklist: New Expensify 2024-08-15 #47512

Closed

74 tasks

Krishna2323 mentioned this pull request Aug 19, 2024

[CP Staging] fix: Workspace switcher - Empty workspace switcher does not have 'Create a workspace' modal. #47527

Merged

50 tasks

Pujan92 reviewed Jan 2, 2025

View reviewed changes

Conversation

tienifr commented Aug 16, 2024 • edited by Beamanator Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 16, 2024

Uh oh!

tienifr commented Aug 16, 2024

Uh oh!

shawnborton commented Aug 16, 2024

Uh oh!

allroundexperts commented Aug 16, 2024

Uh oh!

Beamanator commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

allroundexperts Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

Beamanator Aug 17, 2024

Choose a reason for hiding this comment

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 17, 2024

Uh oh!

OSBotify commented Aug 17, 2024

Uh oh!

OSBotify commented Aug 19, 2024

Uh oh!

OSBotify commented Aug 19, 2024

Uh oh!

Pujan92 Jan 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tienifr commented Aug 16, 2024 •

edited by Beamanator

Loading

Beamanator commented Aug 16, 2024 •

edited

Loading

Beamanator commented Aug 16, 2024 •

edited

Loading

allroundexperts commented Aug 16, 2024 •

edited

Loading