Skip to content

Update en.ts #47649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pecanoro merged 3 commits into from
Aug 19, 2024
Merged

Update en.ts #47649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d870f0
Update en.ts
jamesdeanexpensify Aug 19, 2024
141a140
Update es.ts
jamesdeanexpensify Aug 19, 2024
2b5a61b
Update es.ts
pecanoro Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,9 @@ export default {
cameraErrorTitle: 'Camera error',
cameraErrorMessage: 'An error occurred while taking a photo. Please try again.',
locationAccessTitle: 'Allow location access',
locationAccessMessage: 'We’ll use your location to accurately determine your default currency and timezone. You can edit access in your device’s settings anytime.',
locationErrorTitle: 'Enable location in settings',
locationErrorMessage: 'Allowing location access is required to help accurately determine your default currency and timezone. Tap Settings to update permissions.',
locationAccessMessage: 'Location access helps us keep your timezone and currency accurate wherever you go.',
locationErrorTitle: 'Allow location access',
locationErrorMessage: 'Location access helps us keep your timezone and currency accurate wherever you go.',
Comment on lines +671 to +673
Copy link
Copy Markdown
Contributor

@pecanoro pecanoro Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you are just changing the copy, but ideally, we should merge both in the future if they are the same copy.

Copy link
Copy Markdown
Contributor Author

@jamesdeanexpensify jamesdeanexpensify Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure, I just wasn't sure how to do that piece.

dropTitle: 'Let it go',
dropMessage: 'Drop your file here',
flash: 'flash',
Expand Down
8 changes: 3 additions & 5 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,11 +660,9 @@ export default {
cameraAccess: 'Se requiere acceso a la cámara para hacer fotos de los recibos.',
cameraErrorTitle: 'Error en la cámara',
locationAccessTitle: 'Permitir acceso a la ubicación',
locationAccessMessage:
'Usaremos tu ubicación para determinar con precisión la moneda y zona horaria predeterminadas. Puedes editar el acceso en la configuración de tu dispositivo en cualquier momento.',
locationErrorTitle: 'Habilitar ubicación en la configuración',
locationErrorMessage:
'Es necesario permitir el acceso a la ubicación para ayudar a determinar con precisión su moneda y zona horaria predeterminadas. Haz click en Configuración para actualizar los permisos.',
locationAccessMessage: 'El acceso a la ubicación nos ayuda a mantener tu zona horaria y moneda precisas dondequiera que vayas.',
locationErrorTitle: 'Permitir acceso a la ubicación',
locationErrorMessage: 'El acceso a la ubicación nos ayuda a mantener tu zona horaria y moneda precisas dondequiera que vayas.',
cameraErrorMessage: 'Se ha producido un error al hacer una foto. Por favor, inténtalo de nuevo.',
dropTitle: 'Suéltalo',
dropMessage: 'Suelta tu archivo aquí',
Expand Down