Skip to content

Revert "Create status bar"#47748

Merged
srikarparsi merged 1 commit intomainfrom
revert-47181-cmartins-createStatusBar
Aug 20, 2024
Merged

Revert "Create status bar"#47748
srikarparsi merged 1 commit intomainfrom
revert-47181-cmartins-createStatusBar

Conversation

@luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Aug 20, 2024 •
edited
Loading

Reverts #47181

$ #47741
$ #47746
$ #47684
$ #47752
$ #47652

@luacmartins luacmartins self-assigned this Aug 20, 2024
@luacmartins luacmartins marked this pull request as ready for review August 20, 2024 20:37
@luacmartins luacmartins requested review from a team as code owners August 20, 2024 20:37
@melvin-bot melvin-bot bot requested review from srikarparsi and removed request for a team August 20, 2024 20:37
@melvin-bot
Copy link

melvin-bot bot commented Aug 20, 2024

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi
srikarparsi approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@srikarparsi srikarparsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight revert

@srikarparsi srikarparsi merged commit 7e27cf8 into main Aug 20, 2024
@srikarparsi srikarparsi deleted the revert-47181-cmartins-createStatusBar branch August 20, 2024 20:55
@melvin-bot melvin-bot bot added the Emergency label Aug 20, 2024
@melvin-bot
Copy link

melvin-bot bot commented Aug 20, 2024

@srikarparsi looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@luacmartins
Copy link
Contributor Author

luacmartins commented Aug 20, 2024

Straight revert

OSBotify pushed a commit that referenced this pull request Aug 20, 2024
@srikarparsi @OSBotify
Merge pull request #47748 from Expensify/revert-47181-cmartins-create…
9f0bdcc 
…StatusBar

Revert "Create status bar"

(cherry picked from commit 7e27cf8)

(CP triggered by luacmartins)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Aug 20, 2024
@luacmartins luacmartins mentioned this pull request Aug 20, 2024
Merged
60 tasks
@github-actions github-actions bot mentioned this pull request Aug 20, 2024
Closed
77 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Aug 20, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 20, 2024

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.22-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 20, 2024

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.22-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasperhuangg jasperhuangg jasperhuangg approved these changes

@srikarparsi srikarparsi srikarparsi approved these changes

Assignees

@luacmartins luacmartins

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luacmartins @OSBotify @jasperhuangg @srikarparsi