fix: turn off selection mode when unmounting by dominictb · Pull Request #47994 · Expensify/App

dominictb · 2024-08-26T12:03:26Z

Details

Fixed Issues

$ #47685
PROPOSAL: #47685 (comment)

Tests

Launch New Expensify app.
Go to workspace settings > Categories.
Long tap on any category > Select.
On iOS, swipe to right to exit the page (not app back button).
On Android, use device back navigation to exit the page.
Go to Tags.

Verify that: Selection mode will not be shown in Tags page.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch New Expensify app.
Go to workspace settings > Categories.
Long tap on any category > Select.
On iOS, swipe to right to exit the page (not app back button).
On Android, use device back navigation to exit the page.
Go to Tags.

Verify that: Selection mode will not be shown in Tags page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

compressed_android.webm.mp4

Android: mWeb Chrome

compressed_aweb.webm.mp4

iOS: Native

ios.copy.mp4

iOS: mWeb Safari

ios.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

melvin-bot · 2024-08-26T12:03:31Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-08-27T03:12:06Z

src/hooks/useMobileSelectionMode.ts

+            }
+            turnOffMobileSelectionMode();
+        };
+        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps


Why should we disable lint here?

do we want to include the autoTurnOff flag as a dependency here?

dukenv0307 · 2024-08-27T03:17:10Z

@dominictb As we already had logic to trigger turnOffMobileSelectionMode in the custom hook. Should we remove the redundant logic in HeaderWithBackButton here

App/src/pages/ReportParticipantsPage.tsx

Line 322 in af98a53

turnOffMobileSelectionMode();

and other similar places.

dukenv0307 · 2024-08-27T03:19:18Z

We can use the custom hook in SelectionListWithModal, then remove the following logic:

App/src/components/SelectionListWithModal/index.tsx

Line 66 in af98a53

useEffect(() => turnOffMobileSelectionMode(), []);

dominictb · 2024-08-28T07:13:20Z

#47994 (comment)

@dukenv0307 if you press back button, it will exit the selection mode first. Then press the button again -> the user will be navigated to the previous page. I think it's intentional to be like that, hence I didn't remove.

dukenv0307 · 2024-08-29T02:51:06Z

src/components/SelectionListWithModal/index.tsx

    };

-    useEffect(() => turnOffMobileSelectionMode(), []);
+    useMobileSelectionMode(true);


Suggested change

useMobileSelectionMode(true);

const {selectionMode} = useMobileSelectionMode();

Then remove const [selectionMode] = useOnyx(ONYXKEYS.MOBILE_SELECTION_MODE);

dukenv0307 · 2024-08-29T02:53:09Z

2 minor comments

dukenv0307 · 2024-08-30T03:02:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-30.at.10.10.21.mov

Android: mWeb Chrome

Screen.Recording.2024-08-30.at.10.10.21.mov

iOS: Native

Screen.Recording.2024-08-30.at.10.16.27.mov

iOS: mWeb Safari

Screen.Recording.2024-08-30.at.10.14.17.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-30.at.10.04.59.mov

MacOS: Desktop

Screen.Recording.2024-08-30.at.10.19.06.mov

dukenv0307 · 2024-08-30T03:29:46Z

LGTM

dukenv0307 · 2024-08-30T03:45:56Z

src/hooks/useMobileSelectionMode.ts

+    const [selectionMode] = useOnyx(ONYXKEYS.MOBILE_SELECTION_MODE);
+
+    useEffect(() => {
+        return () => {


Ah, I think we need to turnOffMobileSelectionMode when the component mount

dukenv0307 · 2024-08-30T15:35:54Z

LGTM and tests well

youssef-lr

LGTM!

OSBotify · 2024-08-30T17:50:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-30T18:49:39Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-02T23:27:21Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.27-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: turn off selection mode when unmounting

43fbf0c

dominictb requested a review from a team as a code owner August 26, 2024 12:03

melvin-bot bot requested review from dukenv0307 and removed request for a team August 26, 2024 12:03

dukenv0307 reviewed Aug 27, 2024

View reviewed changes

dominictb added 2 commits August 28, 2024 14:14

Merge branch 'main' into fix/47685-selection-mode

c28dc6e

fix: use new hook in the SelectionListWithModal

20becca

dukenv0307 reviewed Aug 29, 2024

View reviewed changes

fix: use new hook in SelectionListWithModal

4abe5fb

dominictb requested a review from dukenv0307 August 30, 2024 02:12

dukenv0307 approved these changes Aug 30, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr August 30, 2024 03:30

dukenv0307 reviewed Aug 30, 2024

View reviewed changes

fix: only turn off selection mode on first mount

a60c498

dukenv0307 approved these changes Aug 30, 2024

View reviewed changes

youssef-lr approved these changes Aug 30, 2024

View reviewed changes

youssef-lr merged commit 537c62a into Expensify:main Aug 30, 2024

github-actions bot mentioned this pull request Aug 30, 2024

Deploy Checklist: New Expensify 2024-08-30 #48360

Closed

45 tasks

dominictb mentioned this pull request Sep 30, 2024

[Ready for payment][$250] Tags - Selection mode is on Tags page after exiting Categories with selection mode #47685

Closed

6 tasks

	useMobileSelectionMode(true);
	const {selectionMode} = useMobileSelectionMode();

Conversation

dominictb commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 26, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Aug 27, 2024

Uh oh!

dominictb commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Aug 29, 2024

Uh oh!

dukenv0307 commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Aug 30, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Aug 30, 2024

Uh oh!

youssef-lr left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 30, 2024

Uh oh!

OSBotify commented Aug 30, 2024

Uh oh!

OSBotify commented Sep 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dominictb commented Aug 26, 2024 •

edited

Loading

dukenv0307 commented Aug 27, 2024 •

edited

Loading

dominictb commented Aug 28, 2024 •

edited

Loading

dukenv0307 commented Aug 30, 2024 •

edited

Loading