[NO QA]: Feed Added Empty State by narefyev91 · Pull Request #48000 · Expensify/App

narefyev91 · 2024-08-26T13:07:00Z

Details

UI for Feed added empty state

Fixed Issues

$ #47376
PROPOSAL:

Tests

Enable Company cards in More feature
Open Company Cards screen
Verify UI

Verify that no errors appear in the JS console

Offline tests

Enable Company cards in More feature
Open Company Cards screen
Verify UI

QA Steps

Enable Company cards in More feature
Open Company Cards screen
Verify UI

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-08-26T13:07:06Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

assets/images/companyCards/addedFeedEmptyState.svg

Pujan92 · 2024-08-26T20:06:57Z

Let's wait for this PR to get merged, so we can reuse the illustration styles from it.

narefyev91 · 2024-08-27T07:19:59Z

Let's wait for this PR to get merged, so we can reuse the illustration styles from it.

Yeah no problem - just updated illustration naming and style to avoid merge conflicts

Pujan92 · 2024-08-30T05:57:29Z

@narefyev91 We need to merge main to resolve conflicts and reuse the illustration and styles

# Conflicts: # assets/images/companyCards/emptystate__card-pos.svg # src/components/Icon/Illustrations.ts # src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

narefyev91 · 2024-08-30T08:03:37Z

@narefyev91 We need to merge main to resolve conflicts and reuse the illustration and styles

Updated!

Pujan92 · 2024-08-30T08:19:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/pages/workspace/companyCards/WorkspaceCompanyCardsFeedAddedEmptyPage.tsx

Pujan92

LGTM!

shawnborton · 2024-08-30T11:16:18Z

Looking good to me.

Not a blocker, but we might want @jamesdeanexpensify to take a quick look and suggest some different copy so we can potentially avoid the hanging orphan here:

Pujan92 · 2024-08-30T16:01:18Z

Tagging @robertjchen in case @iwiznia is OOO

jamesdeanexpensify · 2024-08-30T16:53:43Z

Where do you assign your first card from this page? I wonder if that copy could be a bit more instructional, if possible.

dannymcclain · 2024-08-30T17:13:42Z

Where do you assign your first card from this page? I wonder if that copy could be a bit more instructional, if possible.

I think there should be an Assign card button in the upper right once you've added a feed.

As far as I know, the TOTAL empty state (no feed at all) looks like this:

And then once you add a feed, but before you've assigned any cards, the empty state looks like this:

Does this look right to everyone, or am I missing something?

shawnborton · 2024-08-30T17:15:28Z

That checks out to me.

jamesdeanexpensify · 2024-08-30T17:18:15Z

Maybe we just remove "to a member" at the end? I just want to keep the body slightly longer than the header, for balance. Can we see how that looks?

dannymcclain · 2024-08-30T17:19:49Z

Maybe we just remove "to a member" at the end? I just want to keep the body slightly longer than the header, for balance. Can we see how that looks?

jamesdeanexpensify · 2024-08-30T17:22:57Z

Looks good to me if it looks good to you!

shawnborton · 2024-08-30T17:40:43Z

I like that.

robertjchen

Great, thanks! 👍

joekaufmanexpensify · 2024-08-30T18:14:43Z

Woooo, TY!

OSBotify · 2024-08-30T18:25:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-30T18:49:42Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.0.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-02T23:27:24Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.27-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Feed Added Empty State

64a612b

narefyev91 requested review from a team as code owners August 26, 2024 13:07

melvin-bot bot requested review from Pujan92 and removed request for a team August 26, 2024 13:07

shawnborton reviewed Aug 26, 2024

View reviewed changes

assets/images/companyCards/addedFeedEmptyState.svg Outdated Show resolved Hide resolved

fix design comments

05a1c6d

avoid merge conflicts

f051039

narefyev91 added 3 commits August 30, 2024 10:28

Merge branch 'refs/heads/main' into add-feeded-empty-state

4d660fe

# Conflicts: # assets/images/companyCards/emptystate__card-pos.svg # src/components/Icon/Illustrations.ts # src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

fixes after merge

199d927

default value

abe0d6b

Pujan92 reviewed Aug 30, 2024

View reviewed changes

src/pages/workspace/companyCards/WorkspaceCompanyCardsFeedAddedEmptyPage.tsx Outdated Show resolved Hide resolved

narefyev91 added 2 commits August 30, 2024 11:48

clean up

a7144b9

default state

b8d62fd

Pujan92 approved these changes Aug 30, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia August 30, 2024 08:52

robertjchen approved these changes Aug 30, 2024

View reviewed changes

robertjchen merged commit 11d679d into Expensify:main Aug 30, 2024

github-actions bot mentioned this pull request Aug 30, 2024

Deploy Checklist: New Expensify 2024-08-30 #48360

Closed

45 tasks

Conversation

narefyev91 commented Aug 26, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 26, 2024

Uh oh!

Uh oh!

Pujan92 commented Aug 26, 2024

Uh oh!

narefyev91 commented Aug 27, 2024

Uh oh!

Pujan92 commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

narefyev91 commented Aug 30, 2024

Uh oh!

Pujan92 commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Aug 30, 2024

Uh oh!

Pujan92 commented Aug 30, 2024

Uh oh!

jamesdeanexpensify commented Aug 30, 2024

Uh oh!

dannymcclain commented Aug 30, 2024

Uh oh!

shawnborton commented Aug 30, 2024

Uh oh!

jamesdeanexpensify commented Aug 30, 2024

Uh oh!

dannymcclain commented Aug 30, 2024

Uh oh!

jamesdeanexpensify commented Aug 30, 2024

Uh oh!

shawnborton commented Aug 30, 2024

Uh oh!

robertjchen left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Aug 30, 2024

Uh oh!

OSBotify commented Aug 30, 2024

Uh oh!

OSBotify commented Aug 30, 2024

Uh oh!

OSBotify commented Sep 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Pujan92 commented Aug 30, 2024 •

edited

Loading

Pujan92 commented Aug 30, 2024 •

edited

Loading