Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp by SzymczakJ · Pull Request #48258 · Expensify/App

SzymczakJ · 2024-08-29T12:06:44Z

Details

This PR adds an animation that hides mobile Search nav bar on scroll down and reveals it on scrollUp. Please note that this feature is only meant to work on mobile screens. Also when user doesn't have enough expenses, the bar won't hide.

Fixed Issues

$ #48019
PROPOSAL:

Tests

Go to Search tab that has a lot of expenses.
Try scrolling and make sure expense type and status bar hides and shows properly.
Go to Search tab that has little or no expenses.
Make sure and make sure expense type and status bar is locked in place.

Offline tests

QA Steps

Same as test steps

PR Author Checklist

Screenshots/Videos

Android: Native

animAndroid.mov

Android: mWeb Chrome

animAndroidweb.mov

iOS: Native

animIos.mov

iOS: mWeb Safari

iosweb.mov

MacOS: Chrome / Safari

MacOS: Desktop

Guccio163

generally LGTM, works great! 👀

Kicu

Hey very nice work both on animation and refactoring. SearchPageHeader feels much simpler, and also Search component also looks simpler.

My only real problem is with SearchPageBottom because it became harder to read.
Most of my comments are minor naming issues, LGTM otherwise 👍

src/pages/Search/SearchPageBottomTab.tsx

src/components/Search/index.tsx

src/components/Search/SearchStatusBar.tsx

Kicu · 2024-09-03T15:10:48Z

src/components/Search/SearchPageHeader.tsx

    isCustomQuery: boolean;
-    setOfflineModalOpen?: () => void;
-    setDownloadErrorModalOpen?: () => void;
-    data?: TransactionListItemType[] | ReportListItemType[];


great job removing so many props! 👏

src/components/Search/index.tsx

src/components/SelectionList/index.tsx

src/libs/SearchUtils.ts

Kicu · 2024-09-03T15:24:01Z

src/pages/Search/SearchPageBottomTab.tsx

+                                hash={queryJSON.hash}
+                                isCustomQuery={isCustomQuery}
+                            />
+                        )}


Do you think its possible to somehow simplify this and reduce the amount of conditional rendering inside this return?
We have conditional rendering for TopBar + SearchTypeMenu, then extra condition for SearchStatusBar and all that is exclusive with SearchPageHeader rendering.
It's very hard to understand which parts of the UI will be rendered.

Some ideas:

early returns?

saving parts of JSX to variables?

small helper components declared within this file?

I think you could try to go over this code again and see if anything can be improved.

melvin-bot · 2024-09-04T09:06:02Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-09-04T10:23:30Z

Running a test build for easier testing...

shawnborton · 2024-09-04T10:42:27Z

Any idea how to fix the iOS build above so we can test?

SzymczakJ · 2024-09-04T12:10:11Z

I merged main and the error should be solved(ruby-version file was missing, but it was reintroduced after merge). Can you try again?

shawnborton · 2024-09-04T12:12:00Z

Will do!

github-actions · 2024-09-04T12:51:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48258/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48258/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48258/NewExpensify.dmg	https://48258.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dannymcclain · 2024-09-04T13:58:24Z

I think this is feeling pretty darn good!

rayane-d · 2024-09-26T00:27:07Z

We have conflicts also

luacmartins · 2024-09-26T00:56:23Z

Waiting on @SzymczakJ to address the comments above

SzymczakJ · 2024-09-26T13:30:59Z

I'll work on it today, I'm just prioritising #49457

luacmartins · 2024-09-26T14:55:55Z

@SzymczakJ yes, let's prioritize #49457

SzymczakJ · 2024-09-26T16:50:15Z

Bumped into bug on #49457, so no update for today

SzymczakJ · 2024-09-27T11:20:04Z

fixed comments and conflicts @rayane-djouah

SzymczakJ · 2024-09-30T09:14:31Z

kind bump @rayane-djouah 🙇

rayane-d

Looks good! One last comment

rayane-d · 2024-09-30T10:12:24Z

src/pages/Search/SearchSelectedNarrow.tsx


    return (
-        <View style={[styles.pb4]}>
+        <View>


Last comment 😄 : To make this view consistent with the room members view, let's reduce the padding to 12px instead of removing it entirely. This way, we will have a total of 24px between the drop-down button and the 'Select All' checkbox.

Suggested change

<View>

<View style={[styles.pb3]} >

Room members Search

SzymczakJ · 2024-09-30T11:12:55Z

Done!

rayane-d

Looks good to me and tests well. Thanks for the great work!

luacmartins

LGTM great work!

OSBotify · 2024-09-30T14:03:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Kicu · 2024-09-30T14:24:28Z

👏

github-actions · 2024-09-30T22:57:05Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-02T00:19:56Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.42-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-10-15T21:11:05Z

This PR caused the following issue:

[$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list #50227

which was caused by wrapping SearchTypeMenu in Animated.View which caused the scroll to stop working. It was fixed in a follow-up PR by this PRs reviewer.

mkhutornyi · 2024-10-28T18:35:08Z

src/styles/index.ts

+        },
+
+        searchListContentContainerStyles: {
+            marginTop: variables.searchListContentMarginTop,


We should use padding instead of margin for contentContainerStyle of ScrollView.
Related bug: #50649
Root cause: #50649 (comment)

ishpaul777 · 2025-03-28T18:44:30Z

src/components/Search/SearchContext.tsx

+        .filter(
+            (item) =>
+                !SearchUtils.isTransactionListItemType(item) &&
+                !SearchUtils.isReportActionListItemType(item) &&
+                item.reportID &&
+                item?.transactions?.every((transaction: {keyForList: string | number}) => selectedTransactions[transaction.keyForList]?.isSelected),
+        )
+        .map((item) => item.reportID);


we did not cover for the case when item is TransactionListItemType, which cause this regression #57473,

RC in Proposal: #57473 (comment)

SzymczakJ added 3 commits August 29, 2024 13:51

add animation logic

0cdffe1

Merge branch 'main' into @szymczak/search-bar-hiding

ce6f1cc

prettify code

6ea15d8

Guccio163 approved these changes Aug 30, 2024

View reviewed changes

SzymczakJ added 7 commits September 2, 2024 10:46

adjust padding

ec1402b

Merge branch 'main' into @szymczak/search-bar-hiding

c2cb62e

make SearchPageHeader use SearchContext instead of accepting data param

e93ceca

move modals from Search/index to SearchPageHeader

1e5ff51

fix paddings

cd01f44

fix EmptyState and Loading screen paddings

ce7d213

fix loading state bug

709e93d

Kicu suggested changes Sep 3, 2024

View reviewed changes

SzymczakJ added 3 commits September 3, 2024 18:26

fix PR comments

317cc9e

Merge branch 'main' into @szymczak/search-bar-hiding

8fd252b

fix typo in comment

8794f8c

SzymczakJ marked this pull request as ready for review September 4, 2024 09:05

SzymczakJ requested review from a team as code owners September 4, 2024 09:05

melvin-bot bot requested review from rayane-d and removed request for a team September 4, 2024 09:06

shawnborton added the Ready To Build label Sep 4, 2024

This comment has been minimized.

Sign in to view

Merge branch 'main' into @szymczak/search-bar-hiding

261df38

SzymczakJ added 3 commits September 27, 2024 11:36

Merge branch 'main' into @szymczak/search-bar-hiding

557625b

fix PR comments

89f95be

fix styles

c507ca1

Merge branch 'main' into @szymczak/search-bar-hiding

ca27414

rayane-d suggested changes Sep 30, 2024

View reviewed changes

fix styles

029f277

rayane-d approved these changes Sep 30, 2024

View reviewed changes

luacmartins approved these changes Sep 30, 2024

View reviewed changes

luacmartins merged commit decf515 into Expensify:main Sep 30, 2024

github-actions bot mentioned this pull request Sep 30, 2024

Deploy Checklist: New Expensify 2024-09-30 #49960

Closed

49 tasks

luacmartins mentioned this pull request Oct 1, 2024

[HOLD for payment 2024-10-10] [Search v1.2] "this expense" in Delete modal changes to "these expenses" after deleting an expense #49980

Closed

6 tasks

rayane-d mentioned this pull request Oct 2, 2024

[HOLD for Payment 2024-10-07][$250] [Search v2.2] Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48019

Closed

jayeshmangwani mentioned this pull request Oct 4, 2024

[$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list #50227

Closed

6 tasks

bernhardoj mentioned this pull request Oct 11, 2024

[HOLD for payment 2024-10-29] [$62.50] Android - Chat search - Unable to reach the bottom of chat list when scrolling down #50649

Closed

6 tasks

mkhutornyi reviewed Oct 28, 2024

View reviewed changes

ishpaul777 reviewed Mar 28, 2025

View reviewed changes

SzymczakJ deleted the @szymczak/search-bar-hiding branch April 8, 2025 09:12

Conversation

SzymczakJ commented Aug 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Guccio163 left a comment

Choose a reason for hiding this comment

Uh oh!

Kicu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kicu Sep 3, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kicu Sep 3, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Sep 4, 2024

Uh oh!

shawnborton commented Sep 4, 2024

Uh oh!

This comment has been minimized.

shawnborton commented Sep 4, 2024

Uh oh!

SzymczakJ commented Sep 4, 2024

Uh oh!

shawnborton commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

dannymcclain commented Sep 4, 2024

Uh oh!

rayane-d commented Sep 26, 2024

Uh oh!

luacmartins commented Sep 26, 2024

Uh oh!

SzymczakJ commented Sep 26, 2024

Uh oh!

luacmartins commented Sep 26, 2024

Uh oh!

SzymczakJ commented Sep 26, 2024

Uh oh!

SzymczakJ commented Sep 27, 2024

Uh oh!

SzymczakJ commented Sep 30, 2024

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

rayane-d Sep 30, 2024

Choose a reason for hiding this comment

Uh oh!

SzymczakJ commented Sep 30, 2024

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 30, 2024

Uh oh!

Kicu commented Sep 30, 2024

Uh oh!

github-actions bot commented Sep 30, 2024

Uh oh!

github-actions bot commented Oct 2, 2024

SzymczakJ commented Aug 29, 2024 •

edited

Loading