feat: validate new contact method action by getusha · Pull Request #48320 · Expensify/App

getusha · 2024-08-30T09:39:23Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/423805
PROPOSAL:

Tests

Go to Settings
Go to Profile
Go to Contact methods
Click “Add new contact method”
Enter new email or phone number
Verify that you are navigated to magic code verification page
Once the magic code is inserted, click Submit
Verify that the contact is added and you're navigated to contact list page

Verify that no errors appear in the JS console

Offline tests

Go to Settings
Go to Profile
Go to Contact methods
Click “Add new contact method”
Verify that the "Add" button is disabled

QA Steps

NOTE: The magic code verification does not work yet so no matter what magic code number you put in, it will succeed

Go to Settings
Go to Profile
Go to Contact methods
Click “Add new contact method”
Enter new email or phone number
Verify that you are navigated to magic code verification page
Once the magic code is inserted, click Submit
Verify that the contact is added and you're navigated to contact list page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-31.at.11.17.09.in.the.morning.mov

Android: mWeb Chrome

Screen.Recording.2024-08-30.at.7.48.30.in.the.evening.mov

iOS: Native

Screen.Recording.2024-08-30.at.7.55.19.in.the.evening.mov

iOS: mWeb Safari

Screen.Recording.2024-08-30.at.5.30.34.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-30.at.5.17.13.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2024-08-30.at.5.31.36.in.the.afternoon.mov

src/ONYXKEYS.ts

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx

src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx

src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

src/libs/actions/User.ts

hungvu193 · 2024-08-30T13:35:17Z

Thanks for assigning. I'll review this shortly

hungvu193 · 2024-08-30T14:36:36Z

Bug 1: User can spam Didn't receive magic code button,I think we should also implement countdown timer like login page

Screen.Recording.2024-08-30.at.21.33.22.mov

getusha · 2024-08-30T14:39:16Z

Bug 1: User can spam Didn't receive magic code button,I think we should also implement countdown timer like login page

Same as ContactMethodDetailsPage i think we should handle this separately.

hungvu193 · 2024-08-30T14:40:44Z

Bug 2: If you added a contact method before but not enter the magic code then exist the page, later when you press Add new contact method you will be redirected to ValidateContactActionPage page.

Screen.Recording.2024-08-30.at.21.38.43.mov

hungvu193 · 2024-08-30T14:43:49Z

Bug 3: A RBR will appear and can not be removed on the primary contact method.

Steps:

Click add new contact method.
Add any email, press Next
Without entering any magic code, submit the form a few times.
Notice that an RBR appears right next to the primary contact method.

hungvu193 · 2024-08-30T14:49:06Z

I've never received any magic code even when I requested/ resent few times. Did you guys receive magic code input after ResendValidateCode was called?

getusha · 2024-08-30T14:50:58Z

I've never received any magic code even when I requested/ resent few times. Did you guys receive magic code input after ResendValidateCode was called?

Just did, ~~make sure the email address you are trying to link doesn't have associated accounts.~~

hungvu193 · 2024-08-30T14:52:51Z

Bug 4: Click on close icon does not clear the error message.

Screen.Recording.2024-08-30.at.21.52.12.mov

We probably also want to clear the error when clicking Didn't receive the magic code?

hungvu193 · 2024-08-30T14:56:53Z

Bug 5: If you interrupt the api called on New Contact Method page, the loading indicator will be there forever.
~~Also even if it's loading we can still interact with it.~~

Screen.Recording.2024-08-30.at.21.55.14.mov

hungvu193 · 2024-08-30T14:59:47Z

Oh shoot :/ I got blocked because I requested so many times 😭 . I'll wait for a while then continue with my testing 😈

getusha · 2024-08-30T15:01:03Z

Oh shoot :/ I got blocked because I requested so many times 😭 . I'll wait for a while then continue with my testing 😈

I use a different email when that happens 😄

hungvu193 · 2024-08-30T15:33:48Z

Bug 6: New contact method page shows errors even there's no error.

Steps :

Click add new contact method.
Add any email, press Next
Without entering any magic code, submit the form and request a new code a few times, until you saw the error Failed to send magic code.... Click back.
Notice that on New Contact Method page, the error shows at the bottom.

Screen.Recording.2024-08-30.at.22.28.39.mov

getusha · 2024-08-30T15:41:21Z

Bug 2, bug 3, bug 4 (you should be able to see the error on the email form), bug 5

@hungvu193 could you recheck ^ bugs, now? thanks!

hungvu193 · 2024-08-30T15:44:27Z

Sure

hungvu193 · 2024-08-30T16:03:45Z

I still can reproduce the RBR bug by trying to request magic code few time at ValidateContactActionPage then go back to New Contact method page then press Next. Repeat few times.

Screen.Recording.2024-08-30.at.23.02.08.mov

hungvu193 · 2024-08-30T16:05:47Z

src/pages/settings/Profile/Contacts/ValidateContactActionPage.tsx

+        Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS.route);
+    }, [loginData, loginData?.pendingFields, loginList]);
+
+    useEffect(() => () => User.clearUnvalidatedNewContactMethodAction(), []);


Once user existed the page, we should also clear the error (RBR) as well.
Let's also add User.clearUnvalidatedNewContactMethodAction() as the return function.

Which function are you referring?

Sorry. I mean the cleanup function of this useEffect.

getusha · 2024-08-31T07:13:27Z

@hungvu193 this is what i see trying to reproduce bug 5

Screen.Recording.2024-08-31.at.10.12.14.in.the.morning.mov

hungvu193 · 2024-08-31T07:22:23Z

Oh weird, after loging out and login again, I can't reproduce anymore :)

hungvu193 · 2024-08-31T07:52:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

// native error

iOS: mWeb Safari

Screen.Recording.2024-08-31.at.15.08.18.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-31.at.14.32.03.mov

MacOS: Desktop

hungvu193 · 2024-08-31T07:59:01Z

On mSafari, after entering the magic code, it still stay on ValidateContactActionPage. I tested it with Strict mode enabled.

Screen.Recording.2024-08-31.at.14.57.38.mov

getusha · 2024-08-31T08:03:37Z

On mSafari, after entering the magic code, it still stay on ValidateContactActionPage. I tested it with Strict mode enabled.

@hungvu193 could you logout & sign in again then retest?

Screen.Recording.2024-08-31.at.11.03.42.in.the.morning.mov

hungvu193 · 2024-08-31T08:04:49Z

On mSafari, after entering the magic code, it still stay on ValidateContactActionPage. I tested it with Strict mode enabled.

@hungvu193 could you logout & sign in again then retest?

I actually logged out before testing, but let me try again.

hungvu193 · 2024-08-31T08:07:00Z

~~Weird, I still can reproduce.~~
Nevermind, It worked after I cleared caches 🥲

Screen.Recording.2024-08-31.at.15.06.29.mov

…-action

hungvu193

All yours @mountiny

melvin-bot · 2024-08-31T08:09:31Z

🎯 @hungvu193, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #48374.

mountiny · 2024-09-02T10:48:12Z

Thanks for the hustle, I will try to test with the backend changes later today

mountiny

@getusha Thank you!

I think we will need to add some clean ups but for the sake of the urgency I think this is good to go and I would like to merge it before the deploy so we have it in staging tomorrow to unblock the backend changes

@getusha Could you look into the fixing the navigation when the user removes the optimistic login? The page goes to not found page because the contact method is in the URL. I think we need to redirect to the contact method list page

Screen.Recording.2024-09-02.at.22.00.17.mp4

mountiny · 2024-09-02T19:58:33Z

src/libs/actions/User.ts

+/**
+ * Clears a contact method optimistically. this is used when the contact method fails to be added to the backend
+ */
+


Suggested change

OSBotify · 2024-09-02T20:28:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-02T23:45:38Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.28-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-03T23:26:14Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.28-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2024-09-04T09:23:26Z

src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

+    useEffect(() => {
+        if (!pendingContactAction?.validateCodeSent) {
+            return;
+        }
+
+        Navigation.navigate(ROUTES.SETINGS_CONTACT_METHOD_VALIDATE_ACTION);
+    }, [pendingContactAction]);


@getusha What is the purpose for this logic?

@parasharrajat We started requiring verification before adding a contact method. the new flow is temporarily save new contact > verify action > add the new contact method.

saveNewContactMethodAndRequestValidationCode just saves the contact method temporarily and requests a magic code, so this logic just navigates youValidateContactActionPage after the magic code is sent

App/src/libs/actions/User.ts

Line 342 in e1d726e

validateCodeSent: true,

parasharrajat · 2024-09-04T11:20:26Z

Is there a design doc for this PR? @hungvu193 @getusha

getusha · 2024-09-04T11:35:59Z

@parasharrajat there is no design doc but you can check this thread and this issue for more detail

mountiny · 2024-09-04T15:42:27Z

No design doc for this, its an urgent change we require now to validate the primary login before taking certain actions, little more details in here #48541

getusha added 2 commits August 30, 2024 00:33

feat: validate new contact method action

087f2fd

refactor: remove unnecessary code

74ec327

mountiny assigned getusha Aug 30, 2024

mountiny self-requested a review August 30, 2024 09:42

mountiny reviewed Aug 30, 2024

View reviewed changes

src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx Outdated Show resolved Hide resolved

src/libs/actions/User.ts Show resolved Hide resolved

mountiny requested a review from hungvu193 August 30, 2024 13:22

getusha added 3 commits August 30, 2024 16:54

refactor: improve action state handling and naming

650f47f

fix: lint and tscheck

c11acac

fix: lint

8d8f6a4

fix: clear pending contact method action

e9b4406

hungvu193 reviewed Aug 30, 2024

View reviewed changes

getusha added 3 commits August 30, 2024 19:19

fix: clear pending contact method action on back press

0714b23

fix: clear pending contact method action

db17bf3

fix: lint

0a40dd5

Merge remote-tracking branch 'exfy/main' into validate-contact-method…

c2f3b6f

…-action

hungvu193 approved these changes Aug 31, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Aug 31, 2024

[$250] Payment issue for E/App PR#48320 #48374

Closed

fix: clear failed contact method from error

0a2c0b2

mountiny approved these changes Sep 2, 2024

View reviewed changes

mountiny merged commit 2cb8354 into Expensify:main Sep 2, 2024

github-actions bot mentioned this pull request Sep 2, 2024

Deploy Checklist: New Expensify 2024-09-02 #48438

Closed

46 tasks

rushatgabhane mentioned this pull request Sep 3, 2024

Add copilot section to security page and add copilot #47353

Merged

50 tasks

This was referenced Sep 3, 2024

Contact methods - Offline indicator is below Verify button and not bottom of the page #48447

Closed

Contact methods - Not here page opens after adding existing contact and dismissing error #48450

Closed

lanitochka17 mentioned this pull request Sep 3, 2024

Contact method - App signs out when adding a new contact method after removing previous one #48472

Closed

6 tasks

mountiny mentioned this pull request Sep 3, 2024

Profile - User receives a magic code instead of the secondary login verification #48501

Closed

6 tasks

parasharrajat reviewed Sep 4, 2024

View reviewed changes

mountiny mentioned this pull request Sep 4, 2024

[HOLD for payment 2024-09-18] Update the Magic code form to be easier to reuse in other flows and add it to Reveal card details flow #48541

Closed

4 tasks

c3024 mentioned this pull request Sep 11, 2024

[PAID] [$250] Wallet empty state has disabled "Add bank account" button for new, unvalidated accounts #48041

Closed

6 tasks

Conversation

getusha commented Aug 30, 2024 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hungvu193 commented Aug 30, 2024

Uh oh!

hungvu193 commented Aug 30, 2024

Uh oh!

getusha commented Aug 30, 2024

Uh oh!

hungvu193 commented Aug 30, 2024

Uh oh!

hungvu193 commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Aug 30, 2024

Uh oh!

getusha commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Aug 30, 2024

Uh oh!

getusha commented Aug 30, 2024

Uh oh!

hungvu193 commented Aug 30, 2024

Uh oh!

getusha commented Aug 30, 2024

Uh oh!

hungvu193 commented Aug 30, 2024

Uh oh!

hungvu193 commented Aug 30, 2024

Uh oh!

hungvu193 Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

getusha Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

getusha commented Aug 31, 2024

Uh oh!

hungvu193 commented Aug 31, 2024

Uh oh!

hungvu193 commented Aug 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 commented Aug 31, 2024

Uh oh!

getusha commented Aug 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Aug 31, 2024

Uh oh!

hungvu193 commented Aug 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

getusha commented Aug 30, 2024 •

edited by mountiny

Loading

hungvu193 commented Aug 30, 2024 •

edited

Loading

getusha commented Aug 30, 2024 •

edited

Loading

hungvu193 commented Aug 30, 2024 •

edited

Loading

hungvu193 commented Aug 30, 2024 •

edited

Loading

hungvu193 commented Aug 31, 2024 •

edited

Loading

getusha commented Aug 31, 2024 •

edited

Loading

hungvu193 commented Aug 31, 2024 •

edited

Loading