Fix: iOS chat view to be hidden if the user clicks away/navigate to two screens or more. by struc · Pull Request #48428 · Expensify/App

struc · 2024-09-02T19:46:15Z

Details

Fixed Issues

$ #48369
PROPOSAL: #48369 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

I have read the CLA Document and I hereby sign the CLA

github-actions · 2024-09-02T19:46:26Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2024-09-02T19:46:44Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-09-02T19:47:25Z

src/pages/home/report/ReportActionsList.tsx

                onClick={scrollToBottomAndMarkReportAsRead}
            />
-            <Animated.View style={[animatedStyles, styles.flex1, !shouldShowReportRecipientLocalTime && !hideComposer ? styles.pb4 : {}]}>
+            <Animated.View style={[styles.flex1, !shouldShowReportRecipientLocalTime && !hideComposer ? styles.pb4 : {}]}>


remove Animated, i guess it no longer required

ishpaul777 · 2024-09-02T19:50:43Z

Tip: Always link issue as a link https://github.com/Expensify/App/issues/<issuenumber>not #<issuenumber> , so our automation can assign a c+ correctly

ishpaul777 · 2024-09-02T20:20:50Z

@struc Please push signed commits

https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#begin-coding-your-solution-in-a-pull-request
Point 10.

Before you begin writing any code, please be aware that we require all commits to be signed. The easiest way to do that is to generate a new GPG key and add it to your GitHub account. Once you've done that, you can automatically sign all your commits by adding the following to your .gitconfig:

[commit]
    gpgsign = true
[user]
    email = <Your GH account email>
    name = <Your Name>
    signingkey = <your_signing_key>
[gpg]
    program = gpg

struc · 2024-09-02T20:29:13Z

@ishpaul777 Thank you so much for you help, I was pushing the commit from a different machine and forgot to add the sign key.

ishpaul777 · 2024-09-02T20:29:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-09-03-02-01-06.mp4

Android: mWeb Chrome

Record_2024-09-03-02-02-49.mp4

iOS: Native

trim.15530756-22BF-4263-8B25-1FDE575AD6A7.MOV

iOS: mWeb Safari

trim.02E297C8-4300-4104-B786-49390B8CBD60.MOV

MacOS: Chrome / Safari

Screen.Recording.2024-09-03.at.1.56.56.AM.mov

MacOS: Desktop

Screen.Recording.2024-09-03.at.2.14.26.AM.mov

ishpaul777 · 2024-09-02T20:35:28Z

still says unverified

ishpaul777 · 2024-09-02T20:40:48Z

gentle bump @struc

Signed-off-by: struc <m.elsayed.a@gmail.com>

struc · 2024-09-02T20:45:41Z

@ishpaul777 sorry for the delay, they are signed now.

melvin-bot · 2024-09-02T20:46:25Z

🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #48431.

ishpaul777 · 2024-09-02T20:46:42Z

All yours @roryabraham

github-actions · 2024-09-02T20:58:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48428/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48428/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48428/NewExpensify.dmg	https://48428.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777 · 2024-09-02T21:13:37Z

ready to go

Fix: iOS chat view to be hidden if the user clicks away/navigate to two screens or more. (cherry picked from commit 7b4d98a) (CP triggered by roryabraham)

OSBotify · 2024-09-02T21:50:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-02T22:27:21Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.27-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-09-02T23:28:33Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.27-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

struc requested a review from a team as a code owner September 2, 2024 19:46

melvin-bot bot requested review from MariaHCD and removed request for a team September 2, 2024 19:46

ishpaul777 reviewed Sep 2, 2024

View reviewed changes

roryabraham added the Ready To Build label Sep 2, 2024

struc force-pushed the main branch 2 times, most recently from 8af3555 to f758d29 Compare September 2, 2024 20:06

This comment has been minimized.

Sign in to view

struc force-pushed the main branch from f758d29 to 6244670 Compare September 2, 2024 20:27

struc force-pushed the main branch from 6244670 to e9bd7ce Compare September 2, 2024 20:41

struc added 2 commits September 2, 2024 20:44

fix: iOS chat view, remove animation

92052ec

Signed-off-by: struc <m.elsayed.a@gmail.com>

improve: Replace Animated.View with View

56d9936

Signed-off-by: struc <m.elsayed.a@gmail.com>

struc force-pushed the main branch from e9bd7ce to 56d9936 Compare September 2, 2024 20:45

ishpaul777 approved these changes Sep 2, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Sep 2, 2024

Payment issue for E/App PR#48428 #48431

Closed

roryabraham approved these changes Sep 2, 2024

View reviewed changes

roryabraham merged commit 7b4d98a into Expensify:main Sep 2, 2024

OSBotify pushed a commit that referenced this pull request Sep 2, 2024

Merge pull request #48428 from struc/main

c1e02c7

Fix: iOS chat view to be hidden if the user clicks away/navigate to two screens or more. (cherry picked from commit 7b4d98a) (CP triggered by roryabraham)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Sep 2, 2024

github-actions bot mentioned this pull request Sep 2, 2024

Deploy Checklist: New Expensify 2024-08-30 #48360

Closed

45 tasks

melvin-bot bot mentioned this pull request Sep 2, 2024

[HOLD for payment 2024-09-09] [$250] Android & iOS Expense - Main chat becomes blank after returning from transaction thread #48369

Closed

6 tasks

github-actions bot mentioned this pull request Sep 2, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #48440

Closed

Conversation

struc commented Sep 2, 2024 • edited by roryabraham Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Sep 2, 2024

Uh oh!

ishpaul777 Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

roryabraham Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

struc Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

ishpaul777 commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

struc commented Sep 2, 2024

Uh oh!

ishpaul777 commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Sep 2, 2024

Uh oh!

ishpaul777 commented Sep 2, 2024

Uh oh!

struc commented Sep 2, 2024

Uh oh!

melvin-bot bot commented Sep 2, 2024

Uh oh!

ishpaul777 commented Sep 2, 2024

Uh oh!

github-actions bot commented Sep 2, 2024

Uh oh!

ishpaul777 commented Sep 2, 2024

Uh oh!

OSBotify commented Sep 2, 2024

Uh oh!

OSBotify commented Sep 2, 2024

Uh oh!

OSBotify commented Sep 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

struc commented Sep 2, 2024 •

edited by roryabraham

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

ishpaul777 commented Sep 2, 2024 •

edited

Loading

ishpaul777 commented Sep 2, 2024 •

edited

Loading

ishpaul777 commented Sep 2, 2024 •

edited

Loading