Skip to content

Fix - Workspace - Toggle btn changed to green but the dot oriented incorrectly in WS settings #48601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneetlath merged 4 commits into from
Sep 17, 2024
Merged

Fix - Workspace - Toggle btn changed to green but the dot oriented incorrectly in WS settings #48601

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3fa4b2
fix highlightable loop bug
FitseTLT Sep 4, 2024
1a8463f
fix lint
FitseTLT Sep 5, 2024
daa74d5
minor fix
FitseTLT Sep 5, 2024
d1aa1e9
clarified the comment
FitseTLT Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/hooks/useAnimatedHighlightStyle/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ export default function useAnimatedHighlightStyle({
return;
}
setStartHighlight(true);
}, [shouldHighlight, startHighlight]);
// We only need to add shouldHighlight as a dependency and adding startHighlight as deps will cause a loop because
// if shouldHighlight stays at true the above early return will not be executed and this useEffect will be run
// as long as shouldHighlight is true as we set startHighlight to false in the below useEffect.
// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
}, [shouldHighlight]);

React.useEffect(() => {
if (!startHighlight || !didScreenTransitionEnd) {
Expand Down