[NetSuite] Add authentication error by mananjadhav · Pull Request #48918 · Expensify/App

mananjadhav · 2024-09-10T18:42:58Z

Details

Adds an authnetication error to the NetSuite connection when we submit invalid credentials.
Also refactored the Sage Intacct previous code to make it generic across connections.

Fixed Issues

$ #47493
PROPOSAL:

Tests

Prerequisite
An accounting enabled workspace with NetSuite beta enabled.

Go to the workspace > Accounting > NetSuite.
Click on the Setup.
One the RHP click next until you reach the credentials form.
Enter any random credentials and click submit.
You'll see the connection is in progress.
After a while it should show error Can’t connect to NetSuite due to an authentication error. along with the learn more link.
Verify the error in Spanish by updating the language.
As a regression test, ensure valid credentials connect you to NetSuite.

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as QA steps.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-netsuite-auth-error.mov

MacOS: Desktop

desktop-netsuite-auth-error.mov

src/pages/workspace/accounting/PolicyAccountingPage.tsx

melvin-bot · 2024-09-10T19:56:25Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/types/onyx/Policy.ts

mananjadhav · 2024-09-16T12:20:03Z

I am a bit unwell, I'll fix the conflicts and work on the comments by later tonight.

…th-error

mananjadhav · 2024-09-18T18:49:42Z

@shubham1206agra I removed one of the properties. Though I felt it was unrelated to this PR. @yuwenmemon @shubham1206agra I've asked two questions here - 1 and 2. Would be great if you folks can respond?

yuwenmemon · 2024-09-18T22:23:37Z

@shubham1206agra bump for a review please

src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx

…th-error

src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx

shubham1206agra · 2024-09-23T12:42:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-09-23.at.5.48.49.PM.mov

MacOS: Desktop

OSBotify · 2024-09-23T21:05:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-24T19:29:26Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-27T17:44:22Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hungvu193 · 2024-10-25T14:30:24Z

src/pages/workspace/accounting/PolicyAccountingPage.tsx

    const overflowMenu: ThreeDotsMenuProps['menuItems'] = useMemo(
        () => [
-            ...(shouldShowEnterCredentials
+            ...(shouldShowEnterCredentials && (connectedIntegration === CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT || connectedIntegration === CONST.POLICY.CONNECTIONS.NAME.NETSUITE)


This line introduced this bug (#50357).
More context: #50357 (comment)

mananjadhav added 4 commits September 10, 2024 23:27

feat: added last sync object to netsuite

da9099b

feat: move all auth errors to common

2f3099c

feat: allow redirect for netsuite

cd21a6f

feat: allow token input form

88b6d3c

mananjadhav commented Sep 10, 2024

View reviewed changes

src/pages/workspace/accounting/PolicyAccountingPage.tsx Show resolved Hide resolved

mananjadhav commented Sep 10, 2024

View reviewed changes

src/pages/workspace/accounting/PolicyAccountingPage.tsx Show resolved Hide resolved

mananjadhav added 4 commits September 11, 2024 00:28

refactor: rename variable

db3215e

refactor: fix ts error

cc97c7a

fix: condition when connection is empty

901483c

fix: condition when connection is empty

f28eb8b

mananjadhav marked this pull request as ready for review September 10, 2024 19:56

mananjadhav requested a review from a team as a code owner September 10, 2024 19:56

melvin-bot bot requested review from shubham1206agra and removed request for a team September 10, 2024 19:56

shubham1206agra reviewed Sep 12, 2024

View reviewed changes

src/types/onyx/Policy.ts Outdated Show resolved Hide resolved

mananjadhav added 2 commits September 18, 2024 22:40

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-au…

91c788e

…th-error

refactor: remove unused props

78dc8f3

refactor: remove comment

0c52433

shubham1206agra reviewed Sep 20, 2024

View reviewed changes

src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx Outdated Show resolved Hide resolved

mananjadhav added 2 commits September 23, 2024 02:33

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-au…

65358d0

…th-error

refactor: update lib call

4e8e84e

shubham1206agra reviewed Sep 23, 2024

View reviewed changes

src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx Outdated Show resolved Hide resolved

refactor: use isEmptyObject

8953ec6

mananjadhav requested a review from shubham1206agra September 23, 2024 09:13

shubham1206agra approved these changes Sep 23, 2024

View reviewed changes

melvin-bot bot requested a review from yuwenmemon September 23, 2024 12:42

yuwenmemon approved these changes Sep 23, 2024

View reviewed changes

yuwenmemon merged commit a8e6a4f into Expensify:main Sep 23, 2024

github-actions bot mentioned this pull request Sep 24, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

67 tasks

IuliiaHerets mentioned this pull request Sep 25, 2024

[HOLD for payment 2024-10-14] [$250] NetSuite - "Can't connect to NetSuite" message appears after connecting #49752

Closed

6 tasks

twilight2294 mentioned this pull request Oct 10, 2024

[HOLD for payment 2024-10-25] [$250] [QBO] There is no option to enter credentials. #50357

Closed

6 tasks

hungvu193 reviewed Oct 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NetSuite] Add authentication error#48918

[NetSuite] Add authentication error#48918
yuwenmemon merged 14 commits intoExpensify:mainfrom
mananjadhav:mj-netsuite-auth-error

mananjadhav commented Sep 10, 2024 •

edited by yuwenmemon

Loading

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Sep 10, 2024

Uh oh!

Uh oh!

mananjadhav commented Sep 16, 2024

Uh oh!

mananjadhav commented Sep 18, 2024

Uh oh!

yuwenmemon commented Sep 18, 2024

Uh oh!

Uh oh!

Uh oh!

shubham1206agra commented Sep 23, 2024

Uh oh!

OSBotify commented Sep 23, 2024

Uh oh!

OSBotify commented Sep 24, 2024

Uh oh!

github-actions bot commented Sep 27, 2024

Uh oh!

hungvu193 Oct 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mananjadhav commented Sep 10, 2024 • edited by yuwenmemon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Sep 10, 2024

Uh oh!

Uh oh!

mananjadhav commented Sep 16, 2024

Uh oh!

mananjadhav commented Sep 18, 2024

Uh oh!

yuwenmemon commented Sep 18, 2024

Uh oh!

Uh oh!

Uh oh!

shubham1206agra commented Sep 23, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Sep 23, 2024

Uh oh!

OSBotify commented Sep 24, 2024

Uh oh!

github-actions bot commented Sep 27, 2024

Uh oh!

hungvu193 Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mananjadhav commented Sep 10, 2024 •

edited by yuwenmemon

Loading