[A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta by fabioh8010 · Pull Request #49007 · Expensify/App

fabioh8010 · 2024-09-11T17:08:54Z

Details

This PR implements the Combined Expense Flow under the corresponding beta.

Fixed Issues

$ #48787
PROPOSAL: #47598 (comment)

Tests

Verify that no errors appear in the JS console

Assert you have the combinedTrackSubmit beta enabled in your account.
Click the FAB to open the Global Create menu, assert there is a Create expense option and there are no Track expense and Submit expense options.
Click the Create expense option to open the page, assert the page's title is Create expense.
Click the Manual tab, insert an amount and click Next to navigate to the next page. Assert the page's title is Submit expense and there is a Just track it button.
Click the Just track it button to navigate to the Track expense confirmation page. Assert the page's title is Track expense. Confirm and assert the expense was tracked.
Repeat steps 4 and 5 for Scan and Distance requests.
Repeat steps 4, 5 and 6 for Manual, Scan and Distance requests, but now submit the expense to someone else instead of tracking it. Assert the confirmation page's title is Submit expense.

Offline tests

Same as above.

QA Steps

Verify that no errors appear in the JS console

Same as above.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-17.at.16.43.49-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-09-17.at.16.50.18-compressed.mov

iOS: Native

Screen.Recording.2024-09-17.at.17.01.34-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-09-17.at.17.04.28-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-17.at.17.09.59-compressed.mov

Screen.Recording.2024-09-17.at.17.13.57-compressed.mov

MacOS: Desktop

Screen.Recording.2024-09-17.at.17.20.20-compressed.mov

…_isValidMoneyRequestType()

…nse beta is enabled

…nse-flow-48787

… flow

…nse-flow-48787

melvin-bot · 2024-09-17T16:39:39Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fabioh8010 · 2024-09-20T08:47:21Z

@grgia I had to migrate the following components to useOnyx:

AccessOrNotFoundWrapper
AttachmentPickerWithMenuItems
FloatingActionButtonAndPopover
IOURequestStepAmount
IOURequestStepDistance
IOURequestStepScan
IOURequestStepParticipants
ReportWelcomeText

I'll do some quick testing around them on Monday.

grgia · 2024-09-20T10:12:43Z

@fabioh8010 would it be better to move the useOnyx updates to a separate PR?

grgia · 2024-09-20T10:14:35Z

@fabioh8010, can you also ensure that we replace track/submit for this case in all scenarios throughout the app?

For example in the report create menu:

fabioh8010 · 2024-09-20T10:44:33Z

@fabioh8010 would it be better to move the useOnyx updates to a separate PR?

Yes I would actually prefer that if you are fine with this.

@fabioh8010, can you also ensure that we replace track/submit for this case in all scenarios throughout the app?

@grgia From what I understood we should only do this in the Global Create menu, could you confirm that we need to do in all the other scenarios?

grgia · 2024-09-20T14:28:25Z

@fabioh8010

From what I understood we should only do this in the #47598, could you confirm that we need to do in all the other scenarios?

Yes, we decided in an internal slack convo [link for internal reference] to replace this option in all the menus yesterday

grgia · 2024-09-20T14:29:22Z

Yes I would actually prefer that if you are fine with this.
If you want to move them into a new PR, ping me in slack or add me as a reviewer and I'll find someone to help test it!

…nse-flow-48787

fabioh8010 · 2024-09-30T17:03:40Z

@fabioh8010 On iOS native, the create expense screens flashes

CleanShot.2024-09-26.at.12.56.28.mp4

Hi @fedirjh I'm having same behavior on main.

Screen.Recording.2024-09-30.at.17.54.44.mov

grgia · 2024-09-30T17:10:26Z

Going to trigger a new adhoc build

github-actions · 2024-09-30T17:42:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49007/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49007/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49007/NewExpensify.dmg	https://49007.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

grgia

Tests well in ADHOC so far, a few minor comments.

@fedirjh could you take a look at this? I think we could merge it today.

src/CONST.ts

src/pages/workspace/AccessOrNotFoundWrapper.tsx

grgia

Code changes LGTM, I'll trigger a final build now

fedirjh · 2024-10-01T11:10:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-10-01.at.11.34.11.mp4

Android: mWeb Chrome

CleanShot.2024-10-01.at.11.50.50-converted.mp4

iOS: Native

Screen.Recording.2024-10-01.at.11.41.19.AM-converted.mov

iOS: mWeb Safari

Screen.Recording.2024-10-01.at.12.01.12.PM.mov

MacOS: Chrome / Safari

CleanShot.2024-10-01.at.11.16.13-converted.mp4

MacOS: Desktop

CleanShot.2024-10-01.at.11.09.46-converted.mp4

fedirjh

Looks good to me as well.

github-actions · 2024-10-01T11:19:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49007/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49007/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49007/NewExpensify.dmg	https://49007.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

grgia

LGTM!

melvin-bot · 2024-10-01T14:54:54Z

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

grgia · 2024-10-01T14:55:00Z

Lint errors are being handled here: #49592

OSBotify · 2024-10-01T15:05:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-02T00:31:24Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.43-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-02T01:10:04Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.43-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

lanitochka17 · 2024-10-02T12:18:01Z

This PR is failing because of issue #50058
Step 2 fails

The issue is reproducible in: all

Bug6622023_1727866383691.20241002_185114.1.mp4

github-actions · 2024-10-03T03:34:15Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.43-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2024-11-10T11:22:22Z

src/pages/iou/request/step/IOURequestStepParticipants.tsx

+    const trackExpense = () => {
+        // If coming from the combined submit/track flow and the user proceeds to just track the expense,
+        // we will use the track IOU type in the confirmation flow.
+        if (!selfDMReportID) {
+            return;
+        }
+
+        IOU.setMoneyRequestParticipantsFromReport(transactionID, ReportUtils.getReport(selfDMReportID));
+        const iouConfirmationPageRoute = ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(action, CONST.IOU.TYPE.TRACK, transactionID, selfDMReportID);
+        Navigation.navigate(iouConfirmationPageRoute);
+    };


In addition to setting the participants we had to set the the custom unit rate id. Without the rate the distance shows as pending

App/src/components/MoneyRequestConfirmationList.tsx

Line 290 in 9f92c5e

const isDistanceRequestWithPendingRoute = isDistanceRequest && (!hasRoute || !rate) && !isMovingTransactionFromTrackExpense;

(Coming from #51679)

fabioh8010 added 6 commits September 10, 2024 16:35

Add "Create Expense" item to Global Create menu

3e0f77d

Merge branch 'main' into feature/combined-expense-flow-48787

96da7f1

Update getIconForAction() to account for create IOU type

ecbf217

Add create iou type to isValidMoneyRequestType() and delete temporary…

a04f4e4

…_isValidMoneyRequestType()

Change canCreateRequest() to include create iou type if combined expe…

80acc3b

…nse beta is enabled

Add tab title for create iou type in IOURequestStartPage

dbe07eb

fabioh8010 changed the title ~~[A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta~~ [WIP] [A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta Sep 11, 2024

fabioh8010 added 7 commits September 12, 2024 14:34

Merge remote-tracking branch 'origin/main' into feature/combined-expe…

18f9585

…nse-flow-48787

Navigate the user to participants page if they are using the combined…

67cb211

… flow

Add Track expense button to IOU participants page

63aa38b

Fix TS error

6b17906

Merge remote-tracking branch 'origin/main' into feature/combined-expe…

093b947

…nse-flow-48787

Fix TS

d7f4032

Merge branch 'main' into feature/combined-expense-flow-48787

2eed579

fabioh8010 marked this pull request as ready for review September 17, 2024 16:39

fabioh8010 requested a review from a team as a code owner September 17, 2024 16:39

melvin-bot bot requested review from fedirjh and removed request for a team September 17, 2024 16:39

fabioh8010 changed the title ~~[WIP] [A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta~~ [A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta Sep 17, 2024

fabioh8010 mentioned this pull request Sep 17, 2024

[HOLD for payment 2024-10-10] [A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta #48787

Closed

Merge branch 'main' into feature/combined-expense-flow-48787

2481082

grgia self-requested a review September 19, 2024 16:12

Merge remote-tracking branch 'origin/main' into feature/combined-expe…

5f21f65

…nse-flow-48787

Add logic to only display track button if user has a self DM

5e52ce1

grgia reviewed Oct 1, 2024

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

src/pages/workspace/AccessOrNotFoundWrapper.tsx Outdated Show resolved Hide resolved

fabioh8010 added 3 commits October 1, 2024 11:15

Merge branch 'main' into feature/combined-expense-flow-48787

17b07c8

Rename GLOBAL_CREATE to CREATE

fcd7690

Use allBetas from ReportUtils

fdf3949

grgia approved these changes Oct 1, 2024

View reviewed changes

fedirjh approved these changes Oct 1, 2024

View reviewed changes

melvin-bot bot requested a review from grgia October 1, 2024 11:10

grgia approved these changes Oct 1, 2024

View reviewed changes

grgia merged commit 1ff3994 into Expensify:main Oct 1, 2024

melvin-bot bot added the Emergency label Oct 1, 2024

grgia removed the Emergency label Oct 1, 2024

github-actions bot mentioned this pull request Oct 2, 2024

Deploy Checklist: New Expensify 2024-10-02 #50030

Closed

56 tasks

nkdengineer mentioned this pull request Oct 2, 2024

[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error #50048

Closed

6 tasks

Shahidullah-Muffakir mentioned this pull request Oct 2, 2024

[HOLD for payment 2024-10-11] Track distance - Distance and Rate show “Pending” when tracking via Just track it route #50051

Closed

6 tasks

IuliiaHerets mentioned this pull request Oct 2, 2024

[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] [$250] Android - IOS - It flickers when I open the manual submit expense twice or more #50098

Closed

6 tasks

s77rt reviewed Nov 10, 2024

View reviewed changes

s77rt mentioned this pull request Nov 10, 2024

[HOLD for payment 2024-11-14] [$250] Track distance - Distance and Rate show “Pending” when tracking via Just track it route #51679

Closed

8 tasks

Conversation

fabioh8010 commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 17, 2024

Uh oh!

fabioh8010 commented Sep 20, 2024

Uh oh!

grgia commented Sep 20, 2024

Uh oh!

grgia commented Sep 20, 2024

Uh oh!

fabioh8010 commented Sep 20, 2024

Uh oh!

grgia commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grgia commented Sep 20, 2024

Uh oh!

fabioh8010 commented Sep 30, 2024

Uh oh!

grgia commented Sep 30, 2024

Uh oh!

github-actions bot commented Sep 30, 2024

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

fedirjh commented Oct 1, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 1, 2024

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Oct 1, 2024

Uh oh!

grgia commented Oct 1, 2024

Uh oh!

OSBotify commented Oct 1, 2024

Uh oh!

github-actions bot commented Oct 2, 2024

Uh oh!

github-actions bot commented Oct 2, 2024

Uh oh!

lanitochka17 commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 3, 2024

Uh oh!

s77rt Nov 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fabioh8010 commented Sep 11, 2024 •

edited

Loading

grgia commented Sep 20, 2024 •

edited

Loading

lanitochka17 commented Oct 2, 2024 •

edited

Loading

s77rt Nov 10, 2024 •

edited

Loading