Add support for inline code with space only characters by tsa321 · Pull Request #49038 · Expensify/App

tsa321 · 2024-09-12T01:19:34Z

Details

Fixed Issues

$ #48101
PROPOSAL: #48101 (comment)

Tests

Test example:

Open any chat, then send: ` `
Verify the disaplyed message is :
Another test : ` `
Verify the displayed message is
Another test: it uses`;`separated fields because the line number column could have`:`in them ` ` with space
Verify the displayed message is: it uses;separated fields because the line number column could have:in them with space

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test example:

Open any chat, then send: ` `
Verify the disaplyed message is :
Another test : ` `
Verify the disaplyed message is
Another test: it uses`;`separated fields because the line number column could have`:`in them ` ` with space
Verify the displayed message is: it uses;separated fields because the line number column could have:in them with space

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-d.mp4

Android: mWeb Chrome

android-mweb_d.mp4

iOS: Native

ios-native_d.mp4

iOS: mWeb Safari

ios-msfari_d.mp4

MacOS: Chrome / Safari

macos-web-d.mp4

MacOS: Desktop

macos-desktop_d.mp4

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

melvin-bot · 2024-09-12T01:19:40Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 · 2024-09-12T01:23:03Z

@hoangzinh, the rest of the changes, aside from the package update, are to display the correct last message in the LHN.

hoangzinh · 2024-09-12T10:18:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-13.at.17.33.47.android.mov

Android: mWeb Chrome

Screen.Recording.2024-09-13.at.17.35.54.android.chrome.mov

iOS: Native

Screen.Recording.2024-09-13.at.17.29.39.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-09-13.at.17.32.00.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-13.at.17.18.31.web.mov

MacOS: Desktop

Screen.Recording.2024-09-13.at.17.21.41.desktop.mov

hoangzinh · 2024-09-12T10:36:56Z

src/libs/ReportActionsUtils.ts

+
+    // Add support for inline code containing only space characters
+    // The message will appear as a blank space in the LHN
+    if ((trimmedMessage === '' && lastMessageText.length > 0) || (trimmedMessage === '?\u2026' && lastMessageText.length > CONST.REPORT.MIN_LENGTH_LAST_MESSAGE_WITH_ELLIPSIS)) {


Can you share what are contexts that the second condition would be used?

To test: try sending an inline code with many spaces inside it, for example:

The lastMessageText of the report from the back end is a lot of spaces, with an ellipsis at the end.

Thanks for the explanation.

hoangzinh · 2024-09-13T10:04:59Z

package.json

    "dom-serializer": "^0.2.2",
    "domhandler": "^4.3.0",
-    "expensify-common": "2.0.84",
+    "expensify-common": "2.0.88",


Just double-check, are you available to check if there are no breaking changes when we bump from 2.0.84 to 2.0.88?

I believe there are no breaking changes. However, I have noticed another issue that also wants updating the expensify-common package (to version 2.0.87): #46117. Should we wait for a PR to be raised for that issue? or should we proceed with this PR?

I think we should. @deetergp what do you think?

I've asked them in that PR if they want us to wait or not.

hoangzinh · 2024-09-13T10:18:12Z

Can you also add this test to the test steps?

it uses`;`separated fields because the line number column could have`:`in them ` ` with space

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 · 2024-09-18T13:17:13Z

@hoangzinh, based on the reply in the other issue, we can continue bumping the expensify-common package in this PR.

hoangzinh · 2024-09-18T13:50:28Z

Cool, can you fix eslint?

tsa321 · 2024-09-18T13:54:57Z

@hoangzinh, the check errors are from main

hoangzinh · 2024-09-18T14:02:08Z

Can you help to report in Slack then someone will pick and fix it, then we can merge in this PR to fix?

tsa321 · 2024-09-18T16:11:50Z

@hoangzinh There is already a Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1726169039084589. I’m not sure if this PR is categorized as:

However, if there's some reason that doing so is unsafe or unreasonable, you can bring it up in slack and ask the Expensify reviewer to ignore the error and merge the PR anyways.

Should I try to fix it? I’m concerned that it might cause a regression.
cc @deetergp

deetergp · 2024-09-18T18:06:52Z

@tsa321 It looks like you'd just be updating getters, so I think the likelihood of introducing a regression is pretty low. Let's go ahead and update the deprecated methods.

hoangzinh · 2024-09-19T23:33:08Z

@tsa321 fyi, there is a PR that fixes somes in the ReportUtils, we can fix the remaining in the ReportActionUtils

#49325

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 · 2024-09-20T06:38:00Z

src/libs/ReportActionsUtils.ts


 function getOriginalMessage<T extends ReportActionName>(reportAction: OnyxInputOrEntry<ReportAction<T>>): OriginalMessage<T> | undefined {
    if (!Array.isArray(reportAction?.message)) {
+        // eslint-disable-next-line


The reportAction?.originalMessage is still needed here.

Previously, I was using eslint-disable-next-line deprecation/deprecation. This fixed the lint error for npm run lint-changed, but it caused a lint error for npm run lint because the deprecation/deprecation rule is not available in npm run lint; it only exists in npm run lint-changed.

Therefore, I am now using eslint-disable-next-line following the discussion in this comment.

tsa321 · 2024-09-20T06:39:17Z

src/libs/ReportActionsUtils.ts


    // HACK ALERT: We're temporarily filtering out any reportActions keyed by sequenceNumber
    // to prevent bugs during the migration from sequenceNumber -> reportActionID
+    // eslint-disable-next-line


The sequenceNumber is still needed to check the deprecation of the reportAction.

hoangzinh

Overal looks good, just one minor feedback

hoangzinh · 2024-09-23T15:33:52Z

src/libs/ReportActionsUtils.ts

    getNumberOfMoneyRequests,
    getOneTransactionThreadReportID,
    getOriginalMessage,
+    // eslint-disable-next-line


can you double check if we need this disabled line?

@hoangzinh Yes, we need this. Removing this line will cause errors when I run npm run lint-changed.

tsa321 · 2024-09-26T01:16:11Z

cc @deetergp for review

OSBotify · 2024-09-26T16:13:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-09-27T17:58:47Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.41-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-30T22:40:34Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add support for inline code with space only characters

3c7bfed

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 requested a review from a team as a code owner September 12, 2024 01:19

melvin-bot bot requested review from hoangzinh and removed request for a team September 12, 2024 01:19

Modify comment

102455a

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

hoangzinh reviewed Sep 12, 2024

View reviewed changes

hoangzinh reviewed Sep 13, 2024

View reviewed changes

deetergp mentioned this pull request Sep 17, 2024

[HOLD for Payment 10/8] [$250] [Crashlytics] TypeError: undefined is not a function #46117

Closed

Merge main and resolve conflict

3c12da6

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 requested a review from hoangzinh September 18, 2024 13:17

mountiny mentioned this pull request Sep 18, 2024

[HOLD https://github.com/Expensify/App/pull/49038] [NoQA] chore: bump expensify-common to 2.0.89 #49364

Closed

50 tasks

tsa321 added 3 commits September 20, 2024 10:14

fix reportactionsutils lint errors

d05cfc7

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

Merge branch 'main' into supportEmptyInlineCode

6885f11

fix lints

81c3fbc

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 commented Sep 20, 2024

View reviewed changes

hoangzinh reviewed Sep 23, 2024

View reviewed changes

tsa321 requested a review from hoangzinh September 23, 2024 15:49

hoangzinh approved these changes Sep 24, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp September 24, 2024 10:40

deetergp approved these changes Sep 26, 2024

View reviewed changes

deetergp merged commit b5a0a29 into Expensify:main Sep 26, 2024

github-actions bot mentioned this pull request Sep 27, 2024

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

Conversation

tsa321 commented Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 12, 2024

Uh oh!

tsa321 commented Sep 12, 2024

Uh oh!

hoangzinh commented Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsa321 Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsa321 Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Sep 13, 2024

Uh oh!

tsa321 commented Sep 18, 2024

Uh oh!

hoangzinh commented Sep 18, 2024

Uh oh!

tsa321 commented Sep 18, 2024

Uh oh!

hoangzinh commented Sep 18, 2024

Uh oh!

tsa321 commented Sep 18, 2024

Uh oh!

deetergp commented Sep 18, 2024

Uh oh!

hoangzinh commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsa321 commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Sep 26, 2024

Uh oh!

github-actions bot commented Sep 27, 2024

Uh oh!

github-actions bot commented Sep 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

tsa321 commented Sep 12, 2024 •

edited

Loading

hoangzinh commented Sep 12, 2024 •

edited

Loading

tsa321 Sep 12, 2024 •

edited

Loading

tsa321 Sep 16, 2024 •

edited

Loading

hoangzinh commented Sep 19, 2024 •

edited

Loading

tsa321 commented Sep 26, 2024 •

edited

Loading