Fix loading skeleton behind background#49039
Merged
carlosmiceli merged 6 commits intoExpensify:mainfrom Sep 14, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #47799
PROPOSAL: #47799 (comment)
Tests
Pre-condition: Create public room without any chat
Offline tests
Can't be tested while offline
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Kapture.2024-09-12.at.09.30.56.mp4
Android: mWeb Chrome
Kapture.2024-09-12.at.09.34.43.mp4
iOS: Native
Kapture.2024-09-14.at.06.00.21.mp4
iOS: mWeb Safari
Kapture.2024-09-12.at.10.14.47.mp4
MacOS: Chrome / Safari
Kapture.2024-09-12.at.09.07.26.mp4
MacOS: Desktop
Kapture.2024-09-12.at.10.00.40.mp4