Skip to content

Revert "fix: remove transaction after navigate"#49096

Merged
luacmartins merged 1 commit intomainfrom
revert-48055-fix/45576
Sep 12, 2024
Merged

Revert "fix: remove transaction after navigate"#49096
luacmartins merged 1 commit intomainfrom
revert-48055-fix/45576

Conversation

@luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Sep 12, 2024

Fixed issues

$ #49052
$ #49066
$ #49094

Reverts #48055

@luacmartins luacmartins self-assigned this Sep 12, 2024
@luacmartins luacmartins marked this pull request as ready for review September 12, 2024 16:07
@luacmartins luacmartins requested a review from a team as a code owner September 12, 2024 16:07
@melvin-bot melvin-bot bot requested review from MonilBhavsar and removed request for a team September 12, 2024 16:08
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2024

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert, looks good

@luacmartins luacmartins merged commit fae105b into main Sep 12, 2024
@luacmartins luacmartins deleted the revert-48055-fix/45576 branch September 12, 2024 16:24
@melvin-bot melvin-bot bot added the Emergency label Sep 12, 2024
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2024

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@luacmartins
Copy link
Contributor Author

Straight revert, didn't complete the checklists

OSBotify pushed a commit that referenced this pull request Sep 12, 2024
Revert "fix: remove transaction after navigate"

(cherry picked from commit fae105b)

(CP triggered by luacmartins)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Sep 12, 2024
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants