fix lhn and copying message content by koko57 · Pull Request #49177 · Expensify/App

koko57 · 2024-09-13T13:59:16Z

Details

Fixed Issues

$ #49149
PROPOSAL:

Tests

PREREQUISITES:

User is assigned a physical card.
User does not have personal details.

Go to workspace chat.
Click Add shipping details.
Complete the flow.
Right click on the system message "x added shipping details" > Copy to clipboard.
Paste the system message.
Copied and pasted messages should match - but instead of the handle there will be display name
LHN message should match the message in the report.

Verify that no errors appear in the JS console

Offline tests

QA Steps

same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-09-13T13:59:21Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Thanks for the quick PR, its nice to see it being refactored like this.

I believe we need to make some small changes though to bring the copy to clipboard and LHN sidebar aligned with how we handle these elsewhere in app.

You can test it out by sending a message to someone with a mention who has or does not have display name and observer the LHN + check how its copied

src/libs/ReportActionsUtils.ts

mountiny · 2024-09-13T21:53:23Z

src/libs/ReportActionsUtils.ts

+    const assignee = shouldRenderHTML ? `<mention-user accountID=${assigneeAccountID}></mention-user>` : assigneeDetails?.displayName ?? assigneeDetails.login ?? '';
+    const link = shouldRenderHTML
+        ? `<a href='${environmentURL}/${ROUTES.SETTINGS_WALLET}'>${Localize.translateLocal('cardPage.expensifyCard')}</a>`
+        : Localize.translateLocal('cardPage.expensifyCard');


So for mentions I think we need to copy the mention, as well, to keep it same as with a normal message

Similarly for the LHN preview, we should show the @FirstName format. so its not a full Display name for the mention but the first name part

@mountiny fixed

allgandalf · 2024-09-14T15:56:17Z

I will complete the checklist tomorrow

allgandalf · 2024-09-15T08:57:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-16.at.7.56.15.PM.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-09-15.at.2.45.20.PM.mov

MacOS: Desktop

Screen.Recording.2024-09-15.at.2.50.28.PM.mov

allgandalf · 2024-09-15T09:34:45Z

bug:
Not getting the @ of the user on small screen devices:

Screen.Recording.2024-09-15.at.3.04.20.PM.mov

allgandalf · 2024-09-15T09:35:38Z

@koko57 can you test on small screen devices? i am able copy paste the username too on macOS web and desktop, but it fails to copy the username/email on both ios and android

koko57 · 2024-09-16T09:05:01Z

@allgandalf fixed!

allgandalf

Looks good to get shipped 🚀 , all yours @mountiny

mountiny

Thanks!

OSBotify · 2024-09-16T14:48:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-16T18:41:50Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.36-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-17T20:32:06Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.36-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allgandalf · 2024-10-24T06:00:50Z

src/components/ReportActionItem/IssueCardMessage.tsx

-                return '';
-        }
-    };
+    const shouldShowAddMissingDetailsButton = action?.actionName === CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS && missingDetails && isAssigneeCurrentUser;


The condition we used here is wrong, we should had checked !isAssigneeCurrentUser instead, this caused #50233.

nitpick @allgandalf 😅 , should had looked more carefully

ahmedGaber93 · 2025-04-03T01:01:41Z

src/libs/ReportActionsUtils.ts

+    const assigneeAccountID = (reportAction?.originalMessage as IssueNewCardOriginalMessage)?.assigneeAccountID;
+    const assigneeDetails = PersonalDetailsUtils.getPersonalDetailsByIDs([assigneeAccountID], currentUserAccountID ?? -1)[0];
+
+    const assignee = shouldRenderHTML ? `<mention-user accountID="${assigneeAccountID}"/>` : assigneeDetails?.firstName ?? assigneeDetails.login ?? '';


Coming from #54630, assignee can be empty string because assigneeDetails?.firstName can be empty string and nullish check ?? will check only for null or undefined, and we fix it here #55699

coming from #65337, the card could be unavailable, we need to check if the card is available

koko57 added 2 commits September 13, 2024 18:51

fix: create isCardIssuedAction, apply for every location where necessary

751e2e8

fix: create getCardIssuedMessage to display a proper message

f4823e1

koko57 requested a review from a team as a code owner September 13, 2024 13:59

melvin-bot bot requested a review from allgandalf September 13, 2024 13:59

melvin-bot bot removed the request for review from a team September 13, 2024 13:59

koko57 mentioned this pull request Sep 13, 2024

[$250] [Workspace Feeds] Copied content & LHN preview do not follow "x added shipping details" message #49149

Closed

6 tasks

mountiny requested changes Sep 13, 2024

View reviewed changes

fix: apply requested changes

1937b1c

mountiny assigned koko57 Sep 15, 2024

koko57 added 2 commits September 16, 2024 13:31

Merge branch 'main' into fix/49149-fix-lhn-and-copying-message-content

096e44e

fix: fix mentions copied on mobile

eab7d0e

koko57 requested a review from mountiny September 16, 2024 11:17

allgandalf approved these changes Sep 16, 2024

View reviewed changes

mountiny approved these changes Sep 16, 2024

View reviewed changes

mountiny merged commit d860f2d into Expensify:main Sep 16, 2024

github-actions bot mentioned this pull request Sep 16, 2024

Deploy Checklist: New Expensify 2024-09-16 #49287

Closed

38 tasks

grgia mentioned this pull request Sep 25, 2024

[getCardIssuedMessage] fix lint error #49734

Merged

49 tasks

allgandalf reviewed Oct 24, 2024

View reviewed changes

allgandalf mentioned this pull request Oct 24, 2024

[HOLD for payment 2024-10-30] Card - "*member* added shipping details" message appears when the details aren't set yet #50233

Closed

6 tasks

ahmedGaber93 mentioned this pull request Jan 3, 2025

[Due for payment 2025-04-02] [$500] Chat - Mentions are not shown in the issue Expensify Card thread page header #54630

Closed

8 tasks

ahmedGaber93 reviewed Apr 3, 2025

View reviewed changes

DylanDylann mentioned this pull request Jul 28, 2025

[Due for payment 2025-07-28] [$250] Company card - The hyperlink in the Workspace chat still highlights after unassigning the card #65337

Closed

8 tasks

Conversation

koko57 commented Sep 13, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 13, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

koko57 Sep 14, 2024

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Sep 14, 2024

Uh oh!

allgandalf commented Sep 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Sep 15, 2024

Uh oh!

allgandalf commented Sep 15, 2024

Uh oh!

koko57 commented Sep 16, 2024

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 16, 2024

Uh oh!

OSBotify commented Sep 16, 2024

Uh oh!

OSBotify commented Sep 17, 2024

Uh oh!

allgandalf Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

koko57 commented Sep 13, 2024 •

edited by github-actions bot

Loading

allgandalf commented Sep 15, 2024 •

edited

Loading