[NoQA] e2e: gather more telemetry data by kirillzyusko · Pull Request #49338 · Expensify/App

kirillzyusko · 2024-09-17T12:15:24Z

Details

Add more loggers to e2e tests because right now it's impossible to understand what's causing double invocation of realeaseProfiler.stop().

Mainly we have two problems:

[Thu Sep 12 2024 23:24:00 GMT+0000 (Coordinated Universal Time)]  ▶️ [DELTA] Warmup for test 'App start time' [1/5]. Iteration 1/2
[Thu Sep 12 2024 23:24:00 GMT+0000 (Coordinated Universal Time)]  Killing com.expensify.chat.e2edelta
[Thu Sep 12 2024 23:24:00 GMT+0000 (Coordinated Universal Time)]  �[2m adb shell am force-stop com.expensify.chat.e2edelta �[0m
[Thu Sep 12 2024 23:24:00 GMT+0000 (Coordinated Universal Time)]  Launching com.expensify.chat.e2edelta
[Thu Sep 12 2024 23:24:00 GMT+0000 (Coordinated Universal Time)]  �[2m adb shell am start -n com.expensify.chat.e2edelta/com.expensify.chat.MainActivity  �[0m
[23:24:01] ⚠️  Process id has changed, ignoring measures until now
[Thu Sep 12 2024 23:24:05 GMT+0000 (Coordinated Universal Time)]  ✅ �[32m [DELTA] Warmup for test 'App start time' [1/5]. Iteration 1/2 �[0m
/tmp/devicefarm-workspace/execution-_emnrkj1/test-package-lyu3der0/zip/testRunner.ts:28427
        throw new Error('Cannot stop polling on a stopped profiler');

Error: Cannot stop polling on a stopped profiler
    at Object.stop (/tmp/devicefarm-workspace/execution-_emnrkj1/test-package-lyu3der0/zip/testRunner.ts:28427:15)
    at Object.stop (/tmp/devicefarm-workspace/execution-_emnrkj1/test-package-lyu3der0/zip/testRunner.ts:28445:13)
    at /tmp/devicefarm-workspace/execution-_emnrkj1/test-package-lyu3der0/zip/testRunner.ts:27975:46
    at /tmp/devicefarm-workspace/execution-_emnrkj1/test-package-lyu3der0/zip/testRunner.ts:27674:13
    at Array.forEach (<anonymous>)

^^ This crash happens when we call forceTestComplete() (i. e. we sent test done command).

[Thu Sep 12 2024 14:04:34 GMT+0000 (Coordinated Universal Time)]  ▶️ [DELTA] Warmup for test 'App start time' [1/5]. Iteration 1/2
[Thu Sep 12 2024 14:04:34 GMT+0000 (Coordinated Universal Time)]  Killing com.expensify.chat.e2edelta
[Thu Sep 12 2024 14:04:34 GMT+0000 (Coordinated Universal Time)]  �[2m adb shell am force-stop com.expensify.chat.e2edelta �[0m
[Thu Sep 12 2024 14:04:34 GMT+0000 (Coordinated Universal Time)]  Launching com.expensify.chat.e2edelta
[Thu Sep 12 2024 14:04:34 GMT+0000 (Coordinated Universal Time)]  �[2m adb shell am start -n com.expensify.chat.e2edelta/com.expensify.chat.MainActivity  �[0m
[14:04:34] ⚠️  Process id has changed, ignoring measures until now
/tmp/devicefarm-workspace/execution-zbabrc2x/test-package-12smuich/zip/testRunner.ts:28427
        throw new Error('Cannot stop polling on a stopped profiler');
              ^

Error: Cannot stop polling on a stopped profiler
    at Object.stop (/tmp/devicefarm-workspace/execution-zbabrc2x/test-package-12smuich/zip/testRunner.ts:28427:15)
    at Object.stop (/tmp/devicefarm-workspace/execution-zbabrc2x/test-package-12smuich/zip/testRunner.ts:28445:13)
    at onAttachFailed (/tmp/devicefarm-workspace/execution-zbabrc2x/test-package-12smuich/zip/testRunner.ts:28014:34)
    at onPidChanged (/tmp/devicefarm-workspace/execution-zbabrc2x/test-package-12smuich/zip/testRunner.ts:28439:13)

^^ this crash happens when we are trying to retry the test.

In both stacktraces we don't see There was an error - it means that onError is not triggered. It means that test done/test retry are conflicting with each other (which is barely possible, as they disable each other if one of them was called).

In this Pr I'm just adding more console.log data to be sure, that we can verify more stacktraces and its interaction with each other.

Fixed Issues

Part of #49314
PROPOSAL:

Note: this PR doesn't fix the problem but just records additional data to investigate failure further.

Tests

run e2e tests and be sure new data is available in console

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-09-17T12:16:33Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair

@kirillzyusko is there an issue you can link this to?

kirillzyusko · 2024-09-17T14:26:32Z

@arosiclair added 🙌 Thank you for a reminder!

arosiclair · 2024-09-17T15:42:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-09-17T20:52:33Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-19T23:35:06Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

chore: gather more telemetry data in e2e tests

b61aaef

kirillzyusko requested a review from a team as a code owner September 17, 2024 12:15

melvin-bot bot requested review from arosiclair and removed request for a team September 17, 2024 12:16

arosiclair approved these changes Sep 17, 2024

View reviewed changes

arosiclair merged commit d4cc26c into Expensify:main Sep 17, 2024

github-actions bot mentioned this pull request Sep 17, 2024

Deploy Checklist: New Expensify 2024-09-17 #49356

Closed

40 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] e2e: gather more telemetry data#49338

[NoQA] e2e: gather more telemetry data#49338
arosiclair merged 1 commit intoExpensify:mainfrom
margelo:e2e/mysterious-double-calls-to-profile-stop

kirillzyusko commented Sep 17, 2024 •

edited by arosiclair

Loading

Uh oh!

melvin-bot bot commented Sep 17, 2024

Uh oh!

arosiclair left a comment

Uh oh!

kirillzyusko commented Sep 17, 2024

Uh oh!

arosiclair commented Sep 17, 2024 •

edited

Loading

Uh oh!

OSBotify commented Sep 17, 2024

Uh oh!

OSBotify commented Sep 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kirillzyusko commented Sep 17, 2024 • edited by arosiclair Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 17, 2024

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

kirillzyusko commented Sep 17, 2024

Uh oh!

arosiclair commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Sep 17, 2024

Uh oh!

OSBotify commented Sep 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kirillzyusko commented Sep 17, 2024 •

edited by arosiclair

Loading

arosiclair commented Sep 17, 2024 •

edited

Loading