Skip to content

[Fix] Search - Expenses are not highlighted when selected #50089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 3 commits into from
Oct 2, 2024
Merged

[Fix] Search - Expenses are not highlighted when selected #50089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d964249
fixes the issue
ishpaul777 Oct 2, 2024
3a53c2d
fixes issue on android
ishpaul777 Oct 2, 2024
4d7a154
fixes issue on android
ishpaul777 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/SelectionList/Search/ReportListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ function ReportListItem<TItem extends ListItem>({
styles.pv1half,
styles.ph0,
styles.overflowHidden,
// Removing background style because they are added to the parent OpacityView via animatedHighlightStyle
styles.bgTransparent,
item.isSelected && styles.activeComponentBG,
isFocused && styles.sidebarLinkActive,
// Removing some of the styles because they are added to the parent OpacityView via animatedHighlightStyle
{backgroundColor: 'unset'},
Copy link
Copy Markdown
Contributor Author

@ishpaul777 ishpaul777 Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backgroundColor: 'unset' was not working as expected on android so i have to use styles.bgTransparent

styles.mh0,
];

Expand Down
4 changes: 2 additions & 2 deletions src/components/SelectionList/Search/TransactionListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ function TransactionListItem<TItem extends ListItem>({
styles.selectionListPressableItemWrapper,
styles.pv3,
styles.ph3,
// Removing background style because they are added to the parent OpacityView via animatedHighlightStyle
styles.bgTransparent,
item.isSelected && styles.activeComponentBG,
isFocused && styles.sidebarLinkActive,
// Removing some of the styles because they are added to the parent OpacityView via animatedHighlightStyle
{backgroundColor: 'unset'},
styles.mh0,
];

Expand Down