Skip to content

fix: error not shown, redirect incorrectly on add bank account #50171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperhuangg merged 2 commits into from
Oct 3, 2024
+7 −7
Merged

fix: error not shown, redirect incorrectly on add bank account #50171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d02e0b
fix: error not shown, redirect incorrectly on add bank account
daledah Oct 3, 2024
392d5d7
fix: remove eslint disable line
daledah Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,8 @@ function BaseValidateCodeForm({
);

useEffect(() => {
if (!validateError) {
return;
}
clearError();
// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
}, [clearError, validateError]);
}, [clearError]);

useEffect(() => {
if (!hasMagicCodeBeenSent) {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/AddPersonalBankAccountPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function AddPersonalBankAccountPage() {
} else if (shouldContinue && onSuccessFallbackRoute) {
PaymentMethods.continueSetup(onSuccessFallbackRoute);
} else {
Navigation.goBack();
Navigation.navigate(ROUTES.SETTINGS_WALLET);
}
},
[personalBankAccount],
Expand Down
6 changes: 5 additions & 1 deletion src/pages/settings/Wallet/VerifyAccountPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ function VerifyAccountPage({route}: VerifyAccountPageProps) {
[loginList, contactMethod],
);

const clearError = useCallback(() => {
User.clearContactMethodErrors(contactMethod, 'validateLogin');
}, [contactMethod]);

useEffect(() => {
if (!isUserValidated) {
return;
Expand All @@ -73,7 +77,7 @@ function VerifyAccountPage({route}: VerifyAccountPageProps) {
validateCodeAction={validateCodeAction}
validateError={validateLoginError}
handleSubmitForm={handleSubmitForm}
clearError={() => User.clearContactMethodErrors(contactMethod, 'validateLogin')}
clearError={clearError}
buttonStyles={[styles.justifyContentEnd, styles.flex1, safePaddingBottomStyle]}
/>
</View>
Expand Down