Revert "Fix task title is overflown and align the checkbox and arrow correctly"#50255
Conversation
|
Revert was confirmed to fix the issue here |
|
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@jasperhuangg do you want me to author checklist? |
|
@ishpaul777 Its done already, I can take over here |
|
@ishpaul777 Do you mind also testing the fix on Android native and uploading a screen recording? |
|
sure i am on it |
|
works well 🎉 Screen.Recording.2024-10-04.at.10.38.52.PM.mov |
|
@jasperhuangg looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Something happened with the checks, both checklists are clearly there |
…-title-overflown Revert "Fix task title is overflown and align the checkbox and arrow correctly" (cherry picked from commit 85c7b5a) (CP triggered by jasperhuangg)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.0.44-10 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀
|
Reverts #49686
$ #50209
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-10-04.at.10.38.52.PM.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-10-04.at.10.14.47.PM.mov
MacOS: Desktop