[Cp Stag] fix Spanish translation by nkdengineer · Pull Request #50384 · Expensify/App

nkdengineer · 2024-10-08T09:32:34Z

Details

Fixed Issues

$ #50381
#50382
#50390

PROPOSAL:

Tests

Change the language to Spanish
Open a DM or concierge
Verify that the translation is correct with a space
Create a group chat with only yourself
Verify that the welcome text is removed
Create a public room and invite at least 3 users
Verify that the second line in welcome text is Just use + button to split expense

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Change the language to Spanish
Open a DM or concierge
Verify that the translation is correct with a space
Create a group chat with only yourself
Verify that the welcome text is removed
Create a public room and invite at least 3 users
Verify that the second line in welcome text is Just use + button to split expense

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-08T09:39:04Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2024-10-08T19:57:17Z

@nkdengineer Let me know when you're done with all the changes that need to be shipped with this PR so I can start reviewing once that's ready - make sure to add tests for each issue that this is fixing.

nkdengineer · 2024-10-08T20:03:28Z

@ikevin127 All changes are done and the test steps for all related issues. I uploaded videos on all platforms for the original issues and added web videos for two other issues since these are logic bugs.

ikevin127 · 2024-10-08T20:27:18Z

Cool - I'll start reviewing once everything is green 🟢

ikevin127 · 2024-10-08T22:16:00Z

src/components/ReportWelcomeText.tsx

                    </Text>
                )}
-                {isDefault && (
+                {isDefault && displayNamesWithTooltips.length && (


@nkdengineer I think this line is causing UI to show 0 for test step 4. Create a group chat with only yourself, instead of showing nothing:

@ikevin127 We decided to remove it in this case. The context here.

@nkdengineer I understand that, but the problem is that with the current code there's a 0 showing up instead of nothing (take a closer look at the picture.

@ikevin127 I updated to fix it now.

ikevin127 · 2024-10-08T22:28:08Z

src/components/ReportWelcomeText.tsx

@@ -50,7 +50,7 @@ function ReportWelcomeText({report, policy}: ReportWelcomeTextProps) {
            item !== CONST.IOU.TYPE.INVOICE,


Not specific to any changed line, but the testing steps 6 and 7 fail because the only welcome text seen on a public room or any other #room type is: This chat room is for anything #public-room related.

We should invite some members to display the Just use + button to split expense text.

jayeshmangwani · 2024-10-09T18:31:04Z

@nkdengineer beginning line is missing when starting the group with ownself, am I missing something here ?

no-begining-line.mov

jayeshmangwani · 2024-10-09T18:33:48Z

Looking at your test steps, I noticed we're removing the beginning line. I was comparing it with production, and it still has the line. If this was intentional, please ignore.

nkdengineer · 2024-10-09T18:41:41Z

It's expexted.

jayeshmangwani · 2024-10-09T18:57:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWeb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

#50381

#50382

room-split-label.mov

#50390

no-beginning.line.mov

MacOS: Desktop

desktop.mov

jayeshmangwani · 2024-10-09T19:23:57Z

@thienlnam PR looks good, and the 3 issues mentioned have been resolved.
Before approving the PR, I wanted to confirm: when we start a group chat with ourselves, there is no beginning line. So, is the spacing between 'Say hello!' and the composer perfect as it is ?

Desktop

iOS

jayeshmangwani

LGTM 🚀

[Cp Stag] fix Spanish translation (cherry picked from commit 342d5a1) (CP triggered by thienlnam)

OSBotify · 2024-10-09T19:45:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-09T20:07:45Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.46-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2024-10-09T20:29:34Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.46-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix Spanish translation

2ee8aaf

nkdengineer marked this pull request as ready for review October 8, 2024 09:38

nkdengineer requested a review from a team as a code owner October 8, 2024 09:39

melvin-bot bot requested a review from ikevin127 October 8, 2024 09:39

melvin-bot bot removed the request for review from a team October 8, 2024 09:39

nkdengineer mentioned this pull request Oct 8, 2024

[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>." #50381

Closed

6 tasks

fix public room case

79308e6

nkdengineer mentioned this pull request Oct 8, 2024

[HOLD for payment 2024-10-16] [$250] Update beginningOfChatHistory for certain cases with fresh copy #47427

Closed

thienlnam changed the title ~~fix Spanish translation~~ [Cp Stag] fix Spanish translation Oct 8, 2024

thienlnam mentioned this pull request Oct 8, 2024

[Hold for payment 2024-10-16] Public room - "Use the + button to or split an expense." is not consistent and incomplete #50382

Closed

6 tasks

Merge branch 'main' into fix/50381

92bb1bc

fix group chat only has yourself

eda9f8e

thienlnam self-requested a review October 8, 2024 20:10

nkdengineer force-pushed the fix/50381 branch from 5f93544 to eda9f8e Compare October 8, 2024 20:20

ikevin127 suggested changes Oct 8, 2024

View reviewed changes

change the condition

17f47cb

thienlnam requested a review from jayeshmangwani October 9, 2024 18:01

jayeshmangwani approved these changes Oct 9, 2024

View reviewed changes

thienlnam approved these changes Oct 9, 2024

View reviewed changes

thienlnam merged commit 342d5a1 into Expensify:main Oct 9, 2024

OSBotify pushed a commit that referenced this pull request Oct 9, 2024

Merge pull request #50384 from nkdengineer/fix/50381

fd9bbcb

[Cp Stag] fix Spanish translation (cherry picked from commit 342d5a1) (CP triggered by thienlnam)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 9, 2024

github-actions bot mentioned this pull request Oct 9, 2024

Deploy Checklist: New Expensify 2024-10-07 #50366

Closed

50 tasks

		@@ -50,7 +50,7 @@ function ReportWelcomeText({report, policy}: ReportWelcomeTextProps) {
		item !== CONST.IOU.TYPE.INVOICE,

Conversation

nkdengineer commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 8, 2024

Uh oh!

ikevin127 commented Oct 8, 2024

Uh oh!

nkdengineer commented Oct 8, 2024

Uh oh!

ikevin127 commented Oct 8, 2024

Uh oh!

ikevin127 Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

ikevin127 Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

ikevin127 Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nkdengineer Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani commented Oct 9, 2024

Uh oh!

jayeshmangwani commented Oct 9, 2024

Uh oh!

nkdengineer commented Oct 9, 2024

Uh oh!

jayeshmangwani commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented Oct 9, 2024

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 9, 2024

Uh oh!

github-actions bot commented Oct 9, 2024

Uh oh!

github-actions bot commented Oct 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nkdengineer commented Oct 8, 2024 •

edited

Loading

ikevin127 Oct 8, 2024 •

edited

Loading

jayeshmangwani commented Oct 9, 2024 •

edited

Loading