Feat: Implement to use a 👍icon next to approved report preview by Krishna2323 · Pull Request #50387 · Expensify/App

Krishna2323 · 2024-10-08T10:04:11Z

Details

Fixed Issues

$ #49847
PROPOSAL: #49847 (comment)

Tests

[Employee] Submit a expense as a employee
[Approver] Approve the request
[Approver] Verify the animation after approving the request.
Pay the approved expense and verify 👍 animates out and ✅ animates in

Verify that no errors appear in the JS console

Offline tests

[Employee] Submit a expense as a employee
[Approver] Approve the request
[Approver] Verify the animation after approving the request.
Pay the approved expense and verify 👍 animates out and ✅ animates in

QA Steps

[Employee] Submit a expense as a employee
[Approver] Approve the request
[Approver] Verify the animation after approving the request.
Pay the approved expense and verify 👍 animates out and ✅ animates in

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2024-10-08T10:04:16Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan

Please add platform screenshots

situchan · 2024-10-08T18:46:55Z

src/components/ReportActionItem/ReportPreview.tsx

    }));

+    const isApproved = ReportUtils.isReportApproved(iouReport, action);
+    const thumbsUpScale = useSharedValue(isApproved ? 1 : 0.25);


0.25 - where does this value come from? what issue with 0?

If we use 0, it will look less subtle than this . #49847 (comment)

Krishna2323 · 2024-10-09T05:20:00Z

@situchan, can you please check this comment?

Krishna2323 · 2024-10-11T14:26:07Z

@Expensify/design, please check if the animation of the thumbs-up icon looks correct or not.

Monosnap.screencast.2024-10-02.05-53-34.mp4

Krishna2323 · 2024-10-14T11:03:11Z

@Expensify/design, friendly bump ^

situchan · 2024-10-15T05:12:29Z

@Expensify/design ^

dubielzyk-expensify · 2024-10-15T05:25:00Z

That looks good to me. Keen to hear the others thoughts. I do see a slight jump when the Red Dot disappears though which I think we should probably fix 🤔

shawnborton · 2024-10-15T07:16:05Z

Agree about the RBR not going away immediately. It is weird to see the thumbs up icon before the RBR goes away.

We also might want to consider making that top eyebrow line use a height of 20px so we don't get a small jump from 20px down to 16px height once the RBR goes away.

situchan · 2024-10-17T20:15:34Z

@Krishna2323 what is status?

Krishna2323 · 2024-10-18T12:01:20Z

Will work on these issues today.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-10-20T12:41:25Z

@situchan, I have increased the line-height of the text beside RBR so it won't jump when the RBR is removed. As for the RBR not being removed immediately, I believe that's a separate issue from what we are trying to solve, and I don't have time to investigate it in-depth. I have very limited time these days as I’ve been dealing with health issues for the past 2-3 months. Sorry :(

situchan · 2024-10-22T20:20:49Z

Agree "RBR not being removed immediately" is out of scope.

I have increased the line-height of the text beside RBR so it won't jump when the RBR is removed.

👍

situchan · 2024-10-23T07:42:43Z

@Krishna2323 please also add test: pay after approve. Just to see how 👍 animates out and ✅ animates in

shawnborton · 2024-10-23T07:44:55Z

Let us know when there are updated videos/screenshots to review as well!

Krishna2323 · 2024-10-23T10:33:12Z

also add test: pay after approve. Just to see how 👍 animates out and ✅ animates in

@situchan, done.

Krishna2323 · 2024-10-25T11:44:10Z

@situchan bump.

situchan · 2024-10-28T06:03:56Z

#50387 (comment)
@Krishna2323 please post videos as well so design team can review them

Krishna2323 · 2024-10-28T20:16:53Z

Let us know when there are updated videos/screenshots to review as well!

@shawnborton, do you also need the animation from 👍 to ✅ for all platforms? Below is the video on web and on other platforms I have only recorded the animation of the appearance of 👍.

Monosnap.screencast.2024-10-02.05-53-34.mp4

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

dannymcclain · 2024-10-28T20:36:30Z

I think it's looking really good. Will let Shawn and @dubielzyk-expensify weigh in too!

dubielzyk-expensify · 2024-10-29T02:01:49Z

Yep that looks good to me too 👏

shawnborton · 2024-10-29T08:24:20Z

Generally looks good to me, but I think I was expecting the same button animation to happen where the button transforms into some kind of "Approved" text... I know a Payment button needs to show up next, so I think we could just fade that Payment button in after a second or so of showing the Approved text. Thoughts on trying something like that out?

Krishna2323 · 2024-11-07T01:19:59Z

@DylanDylann you can start reviewing 😃

DylanDylann · 2024-11-09T08:21:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-09.at.15.19.30.mov

Android: mWeb Chrome

Screen.Recording.2024-11-09.at.15.17.44.mov

iOS: Native

Screen.Recording.2024-11-09.at.15.18.34.mov

iOS: mWeb Safari

Screen.Recording.2024-11-09.at.15.15.36.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-09.at.15.08.09.mov

MacOS: Desktop

Screen.Recording.2024-11-09.at.15.14.09.mov

DylanDylann

LGTM 👍

DylanDylann · 2024-11-12T02:05:59Z

@Krishna2323 Could you please resolve conflict?

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-11-12T10:43:16Z

conflicts resolved

DylanDylann · 2024-11-13T07:58:17Z

@Krishna2323 Bump again

DylanDylann · 2024-11-13T07:58:36Z

@youssef-lr Could you help to review this PR?

Krishna2323 · 2024-11-13T11:14:21Z

conflicts resolved

github-actions · 2024-11-13T19:30:12Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/50387/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/50387/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/50387/NewExpensify.dmg	https://50387.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

youssef-lr · 2024-11-13T21:54:23Z

src/components/ReportActionItem/ReportPreview.tsx

    const onlyShowPayElsewhere = useMemo(() => !canIOUBePaid && getCanIOUBePaid(true), [canIOUBePaid, getCanIOUBePaid]);
    const shouldShowPayButton = isPaidAnimationRunning || canIOUBePaid || onlyShowPayElsewhere;
-    const shouldShowApproveButton = useMemo(() => IOU.canApproveIOU(iouReport, policy), [iouReport, policy]);
+    const shouldShowApproveButton = useMemo(() => IOU.canApproveIOU(iouReport, policy), [iouReport, policy]) || isApprovedAnimationRunning;


why do we need this || isApprovedAnimationRunning;?

If we don't add || isApprovedAnimationRunning, the button will be hidden as soon as we approve the expense, and IOU.canApproveIOU(iouReport, policy) becomes false, interrupting the animation.

youssef-lr

LGTM!

OSBotify · 2024-11-19T19:45:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-21T01:43:47Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mjasikowski · 2024-11-21T14:55:38Z

@Krishna2323 this has been reverted due to causing #52873.
I could only reproduce the behavior from the linked issue on a real Android device, but not an emulator.
I reproduced by tapping approve when the keyboard was visible (or clicking approve and then quickly tapping multiple times on the message composer to bring the keyboard up). Afterwards the dropdown arrow stopped working until I left and navigated back to the response chat.

Tried debbuging this ad hoc and removed the following line:

isDisabled={isPaidAnimationRunning || isApprovedAnimationRunning || isDisabled}

but that did not help - it seems this isn't the root cause.

github-actions · 2024-11-22T19:47:47Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Krishna2323 · 2024-12-02T11:03:57Z

@mjasikowski @DylanDylann, I tried reproducing the regression bug on a physical device, but I wasn't able to reproduce it.

WhatsApp.Video.2024-12-02.at.16.25.37.mp4

Krishna2323 · 2024-12-03T16:33:37Z

@DylanDylann, could you please test the new PR on a physical Android device to double-check that this issue is no longer reproducible?

mjasikowski · 2024-12-04T14:07:04Z

@Krishna2323 I'll try to reproduce this today

mjasikowski · 2024-12-04T14:54:11Z

@Krishna2323 I can still reproduce the issue on the original PR branch (Pixel 4a), will try with the new PR in a moment:

Screen.Recording.2024-12-04.at.15.52.36.mov

mjasikowski · 2024-12-04T15:13:36Z

Can't reproduce in your new PR: #53373

Krishna2323 · 2024-12-04T17:31:11Z

@mjasikowski thanks for checking 🙏🏻

Krishna2323 added 2 commits October 2, 2024 05:55

feat: Implement to use a 👍icon next to approved report preview.

ac0f5b9

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/49847

0f83fed

Krishna2323 requested a review from a team as a code owner October 8, 2024 10:04

melvin-bot bot requested review from situchan and removed request for a team October 8, 2024 10:04

Krishna2323 changed the title ~~Krishna2323/issue/49847~~ Feat: Implement to use a 👍icon next to approved report preview Oct 8, 2024

situchan reviewed Oct 8, 2024

View reviewed changes

Krishna2323 added 3 commits October 20, 2024 17:39

Merge branch 'Expensify:main' into krishna2323/issue/49847

0b2ec04

minor updates.

51842c4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

make animation subtle.

27e2bee

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann approved these changes Nov 9, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr November 9, 2024 08:21

Krishna2323 added 2 commits November 12, 2024 16:02

Merge branch 'main' into krishna2323/issue/49847

db30782

minor fix.

3512844

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/49847

9639ba6

youssef-lr added the Ready To Build label Nov 13, 2024

youssef-lr reviewed Nov 13, 2024

View reviewed changes

youssef-lr approved these changes Nov 19, 2024

View reviewed changes

youssef-lr merged commit a73f681 into Expensify:main Nov 19, 2024

github-actions bot mentioned this pull request Nov 21, 2024

Deploy Checklist: New Expensify 2024-11-21 #52862

Closed

65 tasks

IuliiaHerets mentioned this pull request Nov 21, 2024

Android - Expense - Nothing happens after approving expense and tapping dropdown button #52873

Closed

8 tasks

mjasikowski mentioned this pull request Nov 21, 2024

[CP Staging] Revert "Feat: Implement to use a 👍icon next to approved report preview" #52901

Merged

Conversation

Krishna2323 commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 8, 2024

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

situchan Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

situchan Oct 22, 2024

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Oct 9, 2024

Uh oh!

Krishna2323 commented Oct 11, 2024

Uh oh!

Krishna2323 commented Oct 14, 2024

Uh oh!

situchan commented Oct 15, 2024

Uh oh!

dubielzyk-expensify commented Oct 15, 2024

Uh oh!

shawnborton commented Oct 15, 2024

Uh oh!

situchan commented Oct 17, 2024

Uh oh!

Krishna2323 commented Oct 18, 2024

Uh oh!

Krishna2323 commented Oct 20, 2024

Uh oh!

situchan commented Oct 22, 2024

Uh oh!

situchan commented Oct 23, 2024

Uh oh!

shawnborton commented Oct 23, 2024

Uh oh!

Krishna2323 commented Oct 23, 2024

Uh oh!

Krishna2323 commented Oct 25, 2024

Uh oh!

situchan commented Oct 28, 2024

Uh oh!

Krishna2323 commented Oct 28, 2024

Uh oh!

dannymcclain commented Oct 28, 2024

Uh oh!

dubielzyk-expensify commented Oct 29, 2024

Uh oh!

shawnborton commented Oct 29, 2024

Uh oh!

Krishna2323 commented Nov 7, 2024

Uh oh!

DylanDylann commented Nov 9, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Nov 12, 2024

Uh oh!

Krishna2323 commented Nov 12, 2024

Uh oh!

DylanDylann commented Nov 13, 2024

Uh oh!

DylanDylann commented Nov 13, 2024

Uh oh!

Krishna2323 commented Oct 8, 2024 •

edited

Loading