fix: incorrect lhn report name when partially pay held report by mkzie2 · Pull Request #50762 · Expensify/App

mkzie2 · 2024-10-15T02:17:00Z

Details

Fixed Issues

$ #49274
PROPOSAL: #49274 (comment)

Tests

A submits 2 IOUs to B
B puts on hold one of the IOUs
Go offline
B partially pays the report
B opens the unpaid IOU report that was hold before
Verify the LHN report title shows correctly

Verify that no errors appear in the JS console

Offline tests

See Tests

QA Steps

See Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-04.at.19.07.07-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-11-04.at.19.04.32-compressed.mov

iOS: Native

Screen.Recording.2024-11-04.at.18.52.15-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-11-04.at.18.54.08-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-15.at.10.56.09-compressed.mov

MacOS: Desktop

Screen.Recording.2024-11-04.at.18.57.39-compressed.mov

…e/49274

melvin-bot · 2024-10-15T02:54:40Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mkzie2 · 2024-10-15T08:33:06Z

@hoangzinh Found a problem with LHN last message text, will ping you once I resolve it.

mkzie2 · 2024-10-16T03:33:33Z

@hoangzinh Take a look at the IOU report's last message text in LHN, it's not correct:

To get the last report action, we need to find the transactionThreadReportID.

App/src/libs/OptionsListUtils.ts

Line 313 in e35c4a9

    
           const transactionThreadReportID = ReportActionUtils.getOneTransactionThreadReportID(reportID, actions[reportActions[0]]);

The problem here is at the time create a new IOU report, getOneTransactionThreadReportID in OptionsListUtils return the correct value but after refreshing the page,allReports in ReportConnection.getAllReports below is undefined.

App/src/libs/ReportActionsUtils.ts

Lines 1028 to 1030 in e35c4a9

    
           function getOneTransactionThreadReportID(reportID: string, reportActions: OnyxEntry<ReportActions> | ReportAction[], isOffline: boolean | undefined = undefined): string | undefined { 
        
               // If the report is not an IOU, Expense report, or Invoice, it shouldn't be treated as one-transaction report. 
        
               const report = ReportConnection.getAllReports()?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];

This bug also happens on the latest main when we do the same in the WS chat so I think we can ignore this. Or do you think we should fix it here too?

hoangzinh · 2024-10-18T03:50:04Z

Hi @mkzie2 What do you mean saying "but after refreshing the page"? Is it refresh page (Cmd + R) or revisit by direct link?

hoangzinh · 2024-10-25T09:14:58Z

cc @mkzie2 on this PR

mkzie2 · 2024-10-30T09:12:44Z

Hi @mkzie2 What do you mean saying "but after refreshing the page"? Is it refresh page (Cmd + R) or revisit by direct link?

@hoangzinh it's Cmd + R

hoangzinh · 2024-10-31T10:11:46Z

I see. Agree, we can leave it as it is. Btw, can you help to merge latest main branch into this PR?

…e/49274

mkzie2 · 2024-10-31T11:30:57Z

@hoangzinh Done.

hoangzinh · 2024-10-31T16:07:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- [ x] MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-01.at.05.35.20.android.mov

Android: mWeb Chrome

Screen.Recording.2024-11-01.at.05.32.43.android.chrome.mov

iOS: Native

Screen.Recording.2024-11-01.at.05.39.58.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-11-01.at.05.42.15.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-31.at.23.05.32.web.mov

MacOS: Desktop

Screen.Recording.2024-10-31.at.23.11.02.desktop.mov

src/libs/ReportUtils.ts

hoangzinh · 2024-10-31T22:45:38Z

@mkzie2 can you also add recordings for other platforms?

…e/49274

mkzie2 · 2024-11-04T12:08:22Z

@hoangzinh Updated.

hoangzinh

LGTM

robertjchen

awesome, thanks!

OSBotify · 2024-11-04T15:44:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-06T00:36:34Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.0.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-07T12:41:37Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.58-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

mkzie2 added 2 commits October 15, 2024 09:16

fix: incorrect lhn message when partially pay held report

55d5d69

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

dffde64

…e/49274

mkzie2 marked this pull request as ready for review October 15, 2024 02:54

mkzie2 requested a review from a team as a code owner October 15, 2024 02:54

melvin-bot bot requested review from hoangzinh and removed request for a team October 15, 2024 02:54

mkzie2 changed the title ~~fix: incorrect lhn message when partially pay held report~~ fix: incorrect lhn report name when partially pay held report Oct 15, 2024

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

5c58846

…e/49274

hoangzinh reviewed Oct 31, 2024

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

mkzie2 added 2 commits November 4, 2024 15:54

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

895a009

…e/49274

add JSDoc comment

8943a0f

hoangzinh approved these changes Nov 4, 2024

View reviewed changes

melvin-bot bot requested a review from robertjchen November 4, 2024 12:41

robertjchen approved these changes Nov 4, 2024

View reviewed changes

robertjchen merged commit 4c04320 into Expensify:main Nov 4, 2024

github-actions bot mentioned this pull request Nov 5, 2024

Deploy Checklist: New Expensify 2024-11-05 #52084

Closed

71 tasks

melvin-bot bot mentioned this pull request Nov 7, 2024

[HOLD for payment 2024-11-14] [$250] [Held requests] Not here page for held expense when partially pay the report #49274

Closed

6 tasks

Conversation

mkzie2 commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 15, 2024

Uh oh!

mkzie2 commented Oct 15, 2024

Uh oh!

mkzie2 commented Oct 16, 2024

Uh oh!

hoangzinh commented Oct 18, 2024

Uh oh!

hoangzinh commented Oct 25, 2024

Uh oh!

mkzie2 commented Oct 30, 2024

Uh oh!

hoangzinh commented Oct 31, 2024

Uh oh!

mkzie2 commented Oct 31, 2024

Uh oh!

hoangzinh commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

hoangzinh commented Oct 31, 2024

Uh oh!

mkzie2 commented Nov 4, 2024

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

robertjchen left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 4, 2024

Uh oh!

github-actions bot commented Nov 6, 2024

Uh oh!

github-actions bot commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mkzie2 commented Oct 15, 2024 •

edited

Loading

hoangzinh commented Oct 31, 2024 •

edited

Loading