Fixes "Not here" page briefly showing when last member leaves group chat. by wildan-m · Pull Request #50846 · Expensify/App

wildan-m · 2024-10-16T04:22:44Z

Details

This PR will resolve the issue of the "Not here" page briefly appearing when the last member leaves the group chat.

Fixed Issues

$ #49468
PROPOSAL: #49468 (comment)

Tests

Create a group chat
Click on the header
Remove all existing members from the group
Click Leave the group
Confirm leaving the group participant
Verify no "not found" page appeared

Verify that no errors appear in the JS console

Offline tests

Create a group chat
Click on the header
Remove all existing members from the group
Turn off network
Click Leave the group
Turn on network
Confirm leaving the group participant
Verify no "not found" page appeared

Verify that no errors appear in the JS console

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Kapture.2024-10-16.at.11.15.56.mp4

Android: mWeb Chrome

Kapture.2024-10-16.at.11.17.54.mp4

iOS: Native

Kapture.2024-10-16.at.09.36.27.mp4

iOS: mWeb Safari

Kapture.2024-10-16.at.09.40.28.mp4

MacOS: Chrome / Safari

Kapture.2024-10-16.at.09.33.15.mp4

MacOS: Desktop

Kapture.2024-10-16.at.09.50.48.mp4

…x/49468-group-chat-not-found-appear

melvin-bot · 2024-10-16T04:22:49Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2024-10-16T04:27:18Z

src/libs/actions/Report.ts

+                stateNum: CONST.REPORT.STATE_NUM.APPROVED,
+                statusNum: CONST.REPORT.STATUS_NUM.CLOSED,


Do we need to pass these?

@parasharrajat I think some places use that to determine archive mode. Seems we'll need that especially when the user offline

parasharrajat · 2024-10-16T04:28:22Z

src/libs/actions/Report.ts

+                return acc;
+            }, {}),
+        },
+    ];


Does the Success response delete this report from API?

Based on the network inspect in this video -- yes

#49468 (comment)

Then do we need this?

@parasharrajat I think we don't really need that, but do you think applying https updates can be paused for some reason?

@parasharrajat I'm afraid remove request from the server will be pending, I think we'll still need this successData

https://github.com/Expensify/App/blob/main/src%2Flibs%2Factions%2FOnyxUpdates.ts#L30

parasharrajat · 2024-10-16T04:53:19Z

Screenshots

🔲 iOS / native

27.10.2024_23.16.17_REC.mp4

🔲 iOS / Safari

27.10.2024_23.04.35_REC.mp4

🔲 MacOS / Desktop

27.10.2024_23.23.46_REC.mp4

🔲 MacOS / Chrome

27.10.2024_21.03.45_REC.mp4

🔲 Android / Chrome

27.10.2024_21.02.34_REC.mp4

🔲 Android / native

27.10.2024_23.17.17_REC.mp4

parasharrajat · 2024-10-27T17:56:57Z

Waiting on confirming the real values for

 stateNum: CONST.REPORT.STATE_NUM.APPROVED,
 statusNum: CONST.REPORT.STATUS_NUM.CLOSED,

wildan-m · 2024-10-27T21:43:53Z

Waiting on confirming the real values for

 stateNum: CONST.REPORT.STATE_NUM.APPROVED,
 statusNum: CONST.REPORT.STATUS_NUM.CLOSED,

@parasharrajat did you mean we need to analyze this #50846 (comment) in details?

…x/49468-group-chat-not-found-appear

parasharrajat · 2024-10-28T05:22:48Z

I am checking whether these values are the correct ones for these properties.

parasharrajat · 2024-10-28T15:06:09Z

I confirmed and they look good.https://expensify.slack.com/archives/C02NK2DQWUX/p1730029989661739

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2024-10-28T15:34:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-29T09:44:19Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-10-31T11:17:31Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.55-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

ikevin127 · 2024-11-30T21:32:43Z

src/libs/actions/Report.ts

+        {
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
+            value: Object.keys(report).reduce<Record<string, null>>((acc, key) => {


This block led to the following issue:

[HOLD for payment 2024-12-05] [$250] Search - Empty row in "In" field when searching for messages in inaccessible group chat #52924

which was fixed by setting value to null - more details in the selected proposal.

wildan-m added 5 commits October 15, 2024 15:58

Resolve not found page briefly appeared when remove leave the group

480c4b4

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

0e77f38

…x/49468-group-chat-not-found-appear

revert unnecessary changes

63b49be

Add comment

6eb346a

Revert unnecessary change

1f52c29

wildan-m requested a review from a team as a code owner October 16, 2024 04:22

melvin-bot bot requested review from parasharrajat and removed request for a team October 16, 2024 04:22

wildan-m mentioned this pull request Oct 16, 2024

[Payment 2024-11-07] [$250] mWeb - Group chat - Not here page appears briefly when last member leave the group chat #49468

Closed

6 tasks

wildan-m changed the title ~~Wildan/fix/49468 group chat not found appear~~ Fixes "Not here" page briefly showing when last member leaves group chat. Oct 16, 2024

parasharrajat suggested changes Oct 16, 2024

View reviewed changes

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

0851b74

…x/49468-group-chat-not-found-appear

parasharrajat approved these changes Oct 28, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen October 28, 2024 15:06

tgolen approved these changes Oct 28, 2024

View reviewed changes

tgolen merged commit 4aa19bf into Expensify:main Oct 28, 2024

github-actions bot mentioned this pull request Oct 29, 2024

Deploy Checklist: New Expensify 2024-10-29 #51635

Closed

65 tasks

wildan-m mentioned this pull request Nov 22, 2024

Fix: Expense - Not here page shows up briefly when deleting the expense #52740

Merged

49 tasks

ikevin127 reviewed Nov 30, 2024

View reviewed changes

wildan-m mentioned this pull request Dec 5, 2024

patch success data to prevent issue report object not considered to null #53616

Merged

50 tasks

		stateNum: CONST.REPORT.STATE_NUM.APPROVED,
		statusNum: CONST.REPORT.STATUS_NUM.CLOSED,

Conversation

wildan-m commented Oct 16, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 16, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat commented Oct 27, 2024

Uh oh!

wildan-m commented Oct 27, 2024

Uh oh!

parasharrajat commented Oct 28, 2024

Uh oh!

parasharrajat commented Oct 28, 2024

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

OSBotify commented Oct 28, 2024

Uh oh!

github-actions bot commented Oct 29, 2024

Uh oh!

github-actions bot commented Oct 31, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

parasharrajat commented Oct 16, 2024 •

edited

Loading