Migrate MoneyRequestConfirmationList to useOnyx by NJ-2020 · Pull Request #50848 · Expensify/App

NJ-2020 · 2024-10-16T07:04:42Z

Details

Fixed Issues

$ #50532
PROPOSAL: #50532 (comment)

Tests

Go to Expensify App
Submit expense and click next to go to confirmation list page
Verify the confirmation list page working properly

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-01.at.02.56.22.mov

Android: mWeb Chrome

Screen.Recording.2024-11-01.at.20.28.59.mov

iOS: Native

Screen.Recording.2024-11-01.at.00.24.16.mov

iOS: mWeb Safari

Screen.Recording.2024-11-01.at.00.46.03.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-01.at.01.30.02.mov

MacOS: Desktop

Screen.Recording.2024-11-01.at.01.44.11.mov

melvin-bot · 2024-10-16T07:04:47Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2024-10-16T08:27:36Z

src/components/MoneyRequestConfirmationList.tsx

+export default memo(
+    MoneyRequestConfirmationList,
+    (prevProps, nextProps) =>
+        lodashIsEqual(prevProps.transaction, nextProps.transaction) &&
+        prevProps.onSendMoney === nextProps.onSendMoney &&
+        prevProps.onConfirm === nextProps.onConfirm &&
+        prevProps.iouType === nextProps.iouType &&
+        prevProps.iouAmount === nextProps.iouAmount &&
+        prevProps.isDistanceRequest === nextProps.isDistanceRequest &&
+        prevProps.isPolicyExpenseChat === nextProps.isPolicyExpenseChat &&
+        prevProps.iouCategory === nextProps.iouCategory &&
+        prevProps.shouldShowSmartScanFields === nextProps.shouldShowSmartScanFields &&
+        prevProps.isEditingSplitBill === nextProps.isEditingSplitBill &&
+        prevProps.iouCurrencyCode === nextProps.iouCurrencyCode &&
+        prevProps.iouMerchant === nextProps.iouMerchant &&
+        lodashIsEqual(prevProps.selectedParticipants, nextProps.selectedParticipants) &&
+        lodashIsEqual(prevProps.payeePersonalDetails, nextProps.payeePersonalDetails) &&
+        prevProps.isReadOnly === nextProps.isReadOnly &&
+        prevProps.bankAccountRoute === nextProps.bankAccountRoute &&
+        prevProps.policyID === nextProps.policyID &&
+        prevProps.reportID === nextProps.reportID &&
+        prevProps.receiptPath === nextProps.receiptPath &&
+        prevProps.iouComment === nextProps.iouComment &&
+        prevProps.receiptFilename === nextProps.receiptFilename &&
+        prevProps.iouCreated === nextProps.iouCreated &&
+        prevProps.iouIsBillable === nextProps.iouIsBillable &&
+        prevProps.onToggleBillable === nextProps.onToggleBillable &&
+        prevProps.hasSmartScanFailed === nextProps.hasSmartScanFailed &&
+        prevProps.reportActionID === nextProps.reportActionID &&
+        lodashIsEqual(prevProps.action, nextProps.action) &&
+        prevProps.shouldDisplayReceipt === nextProps.shouldDisplayReceipt,


Can you check why this memo is being used here?

@shubham1206agra We use memo here to prevent the component from being rendered to many times and we will re-render the component if the prevProps and nextProps value change i.e

App/src/components/MoneyRequestConfirmationList.tsx

Line 957 in add705d

lodashIsEqual(prevProps.transaction, nextProps.transaction) &&

if the transaction value change we will re-render the component

Friendly bump @shubham1206agra

I think since we changed to hook now, it will start to re-render again. We need to stop this.

since we changed to hook now, it will start to re-render again. We need to stop this.

Can you explain please what do you mean by that?

I remove the memo checks because it's coming from withOnyx which is already migrated to useOnyx so we don't need it again

@shubham1206agra I think we can close this PR because it's already have been migrated to useOnyx here

I don't think they have done it correctly.

Can you remove the memo since it is not being used? It will be auto optimized by RN.

shubham1206agra · 2024-10-22T05:04:21Z

@NJ-2020 Can you merge main otherwise it will fail tests?

NJ-2020 · 2024-10-22T06:03:08Z

@shubham1206agra Done

shubham1206agra · 2024-10-22T07:02:42Z

@NJ-2020 Please add the tests.

shubham1206agra · 2024-10-23T05:16:41Z

@NJ-2020 Can you again merge main? Since the PR got reverted

NJ-2020 · 2024-10-24T13:04:57Z

@shubham1206agra Sorry for the delay, Okay will do

NJ-2020 · 2024-10-26T13:47:28Z

@shubham1206agra Done

NJ-2020 · 2024-10-30T09:53:15Z

Bump @shubham1206agra for reviewer checklist

shubham1206agra · 2024-10-31T04:36:24Z

@NJ-2020 Please test this #51256. And run the fix for it.

NJ-2020 · 2024-11-02T03:32:27Z

@shubham1206agra Done updated

NJ-2020 · 2024-11-07T06:44:09Z

Bump @shubham1206agra ^

shubham1206agra · 2024-11-10T16:09:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-10.at.9.34.54.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-10.at.9.13.02.PM.mov

iOS: Native

Screen.Recording.2024-11-10.at.9.31.15.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-10.at.9.08.49.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-10.at.9.06.29.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-10.at.9.21.39.PM.mov

shubham1206agra · 2024-11-14T14:05:05Z

@neil-marcellini Bump here

neil-marcellini

Sorry for the delay in reviewing, I was on a backpacking trip last week.

It looks like this component was already migrated to useOnyx, so can we just close the PR and issue? I think so. It looks like the only difference is that you're changing the defaultID values and removing the memo.

I understand that we use the React compiler so it should be ok to remove the memo, but I checked with dev tools and I don't see the Memo ✨ badge next to the component so according the docs that means it's not optimized. Therefore we should leave the memo in and I think we can just close this PR.

shubham1206agra · 2024-11-20T02:57:06Z

Sorry for the delay in reviewing, I was on a backpacking trip last week.

It looks like this component was already migrated to useOnyx, so can we just close the PR and issue? I think so. It looks like the only difference is that you're changing the defaultID values and removing the memo.

I understand that we use the React compiler so it should be ok to remove the memo, but I checked with dev tools and I don't see the Memo ✨ badge next to the component so according the docs that means it's not optimized. Therefore we should leave the memo in and I think we can just close this PR.

@neil-marcellini Leaving the memo in is not required since it will just add some extra overhead on the component.

NJ-2020 requested a review from a team as a code owner October 16, 2024 07:04

melvin-bot bot requested a review from shubham1206agra October 16, 2024 07:04

melvin-bot bot removed the request for review from a team October 16, 2024 07:04

shubham1206agra reviewed Oct 16, 2024

View reviewed changes

fix conflicts

7afcb15

fix prettier and eslint error

de97398

Merge branch 'Expensify:main' into fix/50532

0e7c5e7

pull changes from main and fix conflicts

6c8c92a

neil-marcellini requested a review from shubham1206agra November 7, 2024 17:59

shubham1206agra approved these changes Nov 10, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini November 10, 2024 16:10

Merge branch 'main' into fix/50532

e446f18

neil-marcellini requested changes Nov 19, 2024

View reviewed changes

neil-marcellini closed this Nov 19, 2024

abekkala mentioned this pull request Nov 21, 2024

[$250] Migrate MoneyRequestConfirmationList to useOnyx #50532

Closed

Conversation

NJ-2020 commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 16, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NJ-2020 Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NJ-2020 Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Oct 22, 2024

Uh oh!

NJ-2020 commented Oct 22, 2024

Uh oh!

shubham1206agra commented Oct 22, 2024

Uh oh!

shubham1206agra commented Oct 23, 2024

Uh oh!

NJ-2020 commented Oct 24, 2024

Uh oh!

NJ-2020 commented Oct 26, 2024

Uh oh!

NJ-2020 commented Oct 30, 2024

Uh oh!

shubham1206agra commented Oct 31, 2024

Uh oh!

NJ-2020 commented Nov 2, 2024

Uh oh!

NJ-2020 commented Nov 7, 2024

Uh oh!

shubham1206agra commented Nov 10, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

shubham1206agra commented Nov 14, 2024

Uh oh!

neil-marcellini left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Nov 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NJ-2020 commented Oct 16, 2024 •

edited

Loading

NJ-2020 Oct 16, 2024 •

edited

Loading

NJ-2020 Oct 22, 2024 •

edited

Loading

neil-marcellini left a comment •

edited

Loading