Add missing calls to App.confirmReadyToOpenApp by aldo-expensify · Pull Request #51110 · Expensify/App

aldo-expensify · 2024-10-18T19:47:46Z

Details

Seems like when we open the App from settings, the function confirmReadyToOpenApp is never called, which results in us never calling ReconnectApp here because the promise returned from getPolicyParamsForOpenOrReconnect never resolves

This PR is adding calls to App.confirmReadyToOpenApp where I think it is missing.

cc @jasperhuangg since you added the function App.confirmReadyToOpenApp here: #18114

Some more context: https://expensify.slack.com/archives/C03TQ48KC/p1729204325866909

Fixed Issues

$ #49371 (comment)
PROPOSAL:

Tests

Enable Accounting for a workspace and go to the Accounting settings page
Copy the URL, it should be something like: https://<domain>/settings/workspaces/<policyID>/accounting and keep it somewhere (you will have to return to it later)
Connect QBO to a workspace
Close the tab before the connection finishes syncing
Wait for a minute or two until the connecting syncing has finished
Open a new browser tab and open the chrome dev console in the network tab
In that same tab, navigate to the URL you saved in step 2
Verify that you see the OpenInitialSettingsPage and ReconnectApp requests
Verify that the QBO integration is not stuck with an infinite spinner and that it loaded correctly:

Verify that no errors appear in the JS console

Offline tests

QA Steps

Enable Accounting for a workspace and go to the Accounting settings page
Copy the URL, it should be something like: https://<domain>/settings/workspaces/<policyID>/accounting and keep it somewhere (you will have to return to it later)
Connect QBO to a workspace
Close the tab before the connection finishes syncing
Wait for a minute or two until the connecting syncing has finished
Open a new browser tab and open the chrome dev console in the network tab
In that same tab, navigate to the URL you saved in step 2
Verify that you see the OpenInitialSettingsPage and ReconnectApp requests
Verify that the QBO integration is not stuck with an infinite spinner and that it loaded correctly:

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Starting the sync and closing the tab before it finishes:

Screen.Recording.2024-10-18.at.1.25.41.PM.mov

Reopening the tab:

Screen.Recording.2024-10-18.at.1.27.38.PM.mov

MacOS: Desktop

melvin-bot · 2024-10-18T20:29:59Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2024-10-18T20:33:07Z

src/pages/settings/InitialSettingsPage.tsx


    useEffect(() => {
        Wallet.openInitialSettingsPage();
+        App.confirmReadyToOpenApp();


This is for when you open the App directly in the main settings page:

aldo-expensify · 2024-10-18T20:33:56Z

src/pages/workspace/WorkspaceInitialPage.tsx

+    useEffect(() => {
+        App.confirmReadyToOpenApp();
+    }, []);
+


This is for when you open the App directly in a workspace's settings page:

jasperhuangg · 2024-10-21T14:16:20Z

@abdulrahuman5196 Please complete PR reviewer checklist, thanks!

abdulrahuman5196 · 2024-10-21T19:14:41Z

Hi, Checking now

abdulrahuman5196 · 2024-10-21T19:48:06Z

Hi @aldo-expensify I am facing server not found error after clicking on Quickbooks Online from dev. I haven't worked with QBO before, do I need to do any more steps for connection?

Screen.Recording.2024-10-22.at.1.10.55.AM.mov

aldo-expensify · 2024-10-21T20:12:51Z

Hi @aldo-expensify I am facing server not found error after clicking on Quickbooks Online from dev. I haven't worked with QBO before, do I need to do any more steps for connection?

hmm, seems like it is trying to connect to the dev web api which contributors / C+ don't have. @mananjadhav I think you have tested QBO stuff... do you know what @abdulrahuman5196 may have misconfigured in their env to be making calls to expensify.com.dev instead of staging.expensify.com?

ikevin127 · 2024-10-23T18:57:57Z

@abdulrahuman5196 This is expected during development, when I encountered this I removed the .dev part from the redirect URL and proceed with connecting as usual - once you connected the provider, the integration will show up on your local dev instance.

aldo-expensify · 2024-10-23T19:06:00Z

Thanks @ikevin127

aldo-expensify · 2024-10-23T23:11:16Z

@abdulrahuman5196 do you think you will be able to review this soon?

aldo-expensify · 2024-10-24T18:44:26Z

@abdulrahuman5196 in case QBO is harder to make work than other, for the testing steps, any kind of integration should work.

abdulrahuman5196 · 2024-10-28T10:07:39Z

Hi, Checking this now again, will let you know if I am able to unblock this dev issue.

abdulrahuman5196 · 2024-10-28T16:22:59Z

Checking again now

abdulrahuman5196 · 2024-10-28T16:29:52Z

Thank you for the help everyone. I am able to connect QBO, Will work on further checking and close this out.

abdulrahuman5196 · 2024-10-28T19:20:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-10-29.at.12.46.40.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-10-29.at.12.43.24.AM.mp4

MacOS: Desktop

Screen.Recording.2024-10-29.at.12.44.18.AM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @jasperhuangg

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2024-10-28T19:40:03Z

I also checked mweb safari and its working fine and making reconnectApp call.

melvin-bot · 2024-10-28T19:40:10Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2024-10-28T19:44:05Z

Thanks!

OSBotify · 2024-10-28T19:55:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-29T09:44:31Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-10-31T11:17:43Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.55-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

Add missing calls to App.confirmReadyToOpenApp

5a1317a

aldo-expensify self-assigned this Oct 18, 2024

Fix import prettier error

b6d61ed

aldo-expensify marked this pull request as ready for review October 18, 2024 20:29

aldo-expensify requested a review from a team as a code owner October 18, 2024 20:29

melvin-bot bot requested a review from abdulrahuman5196 October 18, 2024 20:29

melvin-bot bot removed the request for review from a team October 18, 2024 20:29

aldo-expensify mentioned this pull request Oct 18, 2024

[HOLD for payment 2024-11-07] QBO - Syncing is stuck at "Waiting for imported data to load" #49371

Closed

6 tasks

aldo-expensify commented Oct 18, 2024

View reviewed changes

jasperhuangg approved these changes Oct 18, 2024

View reviewed changes

aldo-expensify mentioned this pull request Oct 25, 2024

QBO - Changing to other option does not save for the first time #49372

Closed

6 tasks

abdulrahuman5196 approved these changes Oct 28, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair October 28, 2024 19:40

aldo-expensify merged commit 91aed17 into main Oct 28, 2024

aldo-expensify deleted the aldo_confirmReadyToOpenApp branch October 28, 2024 19:44

github-actions bot mentioned this pull request Oct 29, 2024

Deploy Checklist: New Expensify 2024-10-29 #51635

Closed

65 tasks

Conversation

aldo-expensify commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 18, 2024

Uh oh!

aldo-expensify Oct 18, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify Oct 18, 2024

Choose a reason for hiding this comment

Uh oh!

jasperhuangg commented Oct 21, 2024

Uh oh!

abdulrahuman5196 commented Oct 21, 2024

Uh oh!

abdulrahuman5196 commented Oct 21, 2024

Uh oh!

aldo-expensify commented Oct 21, 2024

Uh oh!

ikevin127 commented Oct 23, 2024

Uh oh!

aldo-expensify commented Oct 23, 2024

Uh oh!

aldo-expensify commented Oct 23, 2024

Uh oh!

aldo-expensify commented Oct 24, 2024

Uh oh!

abdulrahuman5196 commented Oct 28, 2024

Uh oh!

abdulrahuman5196 commented Oct 28, 2024

Uh oh!

abdulrahuman5196 commented Oct 28, 2024

Uh oh!

abdulrahuman5196 commented Oct 28, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Oct 28, 2024

Uh oh!

melvin-bot bot commented Oct 28, 2024

Uh oh!

aldo-expensify commented Oct 28, 2024

Uh oh!

OSBotify commented Oct 28, 2024

Uh oh!

github-actions bot commented Oct 29, 2024

Uh oh!

github-actions bot commented Oct 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aldo-expensify commented Oct 18, 2024 •

edited

Loading