[Self-guided tours][V2] Add tour links to onboarding tasks by c3024 · Pull Request #51153 · Expensify/App

c3024 · 2024-10-21T06:09:17Z

Details

Fixed Issues

$ #50926
PROPOSAL: N/A

Tests

Test 1:

Logon to ND with a new account.
Select any of the onboarding options other than "Manage my team’s expenses" or "Something else" and complete the onboarding flow.
Navigate to Concierge chat.
Verify that the first incomplete task is "Take a 2-minute tour".
Click on the task.
Verify that you are navigated to the employee focused self guided tour link when you click on the link hyperlinked to the text "Take a self-guided product tour".

Test2:

Logon to ND with a new account.
Select the onboarding option "Manage my team’s expenses" and complete the onboarding flow.
Navigate to Concierge chat.
Verify that the first incomplete task is "Take a 2-minute tour".
Click on the task.
Verify that you are navigated to the admin focused self guided tour link when you click on the link hyperlinked to the text "Take a self-guided product tour".

Test 3:

Logon to ND with a new account.
Select the onboarding options "Something else" and complete the onboarding flow.
Navigate to Concierge chat.
Verify that there is no task named "Take a 2-minute tour".

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

tourAndroid.mp4

Android: mWeb Chrome

tourAndroidmWeb.mp4

iOS: Native

touriOS.mp4

iOS: mWeb Safari

touriOSmWeb.mp4

MacOS: Chrome / Safari

tourChrome1.mp4

tourChrome2.mp4

MacOS: Desktop

tourDesktop.mp4

melvin-bot · 2024-10-26T02:43:05Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/CONST.ts

rushatgabhane · 2024-10-28T01:29:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-10-28.at.06.43.28.mov

iOS: mWeb Safari

Screen.Recording.2024-10-28.at.06.35.40.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-28.at.06.31.33.mov

MacOS: Desktop

rushatgabhane · 2024-10-28T01:30:40Z

@mountiny this has changes from #51136 too. So I'd recommend to review #51136 first

rushatgabhane · 2024-10-28T01:31:20Z

@Expensify/design hope this looks good?

dubielzyk-expensify · 2024-10-28T03:55:52Z

Visually looks good to me 👍

rushatgabhane · 2024-10-29T14:38:40Z

@c3024 please resolve conflicts.

mountiny

@c3024 @rushatgabhane couple small comments

mountiny · 2024-11-04T18:29:09Z

src/libs/API/types.ts


    // Invoice API
    [WRITE_COMMANDS.SET_INVOICING_TRANSFER_BANK_ACCOUNT]: Parameters.SetInvoicingTransferBankAccountParams;
+    [WRITE_COMMANDS.SELF_TOUR_VIEWED]: null;


This is not invoice API, can you move it to a more appropriate section please?

mountiny · 2024-11-04T18:36:31Z

src/libs/onboardingSelectors.ts

+    if (Array.isArray(onboarding)) {
+        return true;
+    }


Given this answer, I think that if the onboarding NVP is not set yet, so old account, we still want to show them the tour option.

Suggested change

if (Array.isArray(onboarding)) {

return true;

}

if (Array.isArray(onboarding)) {

return false;

}

rushatgabhane · 2024-11-04T18:54:32Z

@mountiny see #51136 (comment)

mountiny · 2024-11-04T21:20:43Z

@c3024 please merge main

c3024 · 2024-11-05T01:26:34Z

@mountiny

Merged main but tasks are rejected by backend when the intent selected is "Chat and Split with friends" on main.

output-task.mp4

and that has nothing to do with this PR. All other choices work well and here are the videos. This PR can be merged.

tourTask.mp4

Screen.Recording.2024-11-05.at.7.03.46.AM.mov

dubielzyk-expensify

LGTM

mountiny

Thanks

OSBotify · 2024-11-05T08:56:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-06T00:36:40Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-07T12:41:43Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.58-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

brunovjk · 2024-12-06T19:12:48Z

We did not include selfGuidedTourTask in thecombinedTrackSubmitOnboardingPersonalSpendMessage leading to this issue.

tgolen · 2025-04-02T15:13:42Z

src/CONST.ts

    SMB: 'smb',
 } as const;

+const selfGuidedTourTask: OnboardingTaskType = {


@c3024 @mountiny Is there a reason these objects were put in CONST.ts? I feel that this is not the right file for putting message templates. Would anyone mind if I open an issue to have these moved somewhere else so that we only keep CONSTs in this file?

Task titles and descriptions for onboarding tasks were in this file when we added this task. Extracted this self tour task to an object because this is repetitive for several onboarding intents.

Would anyone mind if I open an issue to have these moved somewhere else so that we only keep CONSTs in this file?

Not at all, sounds like a good idea!

Yep agreed, we can move anything dynamic out of this file to keep it purely consts

c3024 added 2 commits October 21, 2024 10:44

Merge branch 'kc-fabtour' into self-guided-tours-v2-add-tasks

1e256cc

add self guided tours to tasks

7e9bf7c

c3024 marked this pull request as ready for review October 26, 2024 02:43

c3024 requested review from a team as code owners October 26, 2024 02:43

melvin-bot bot requested a review from rushatgabhane October 26, 2024 02:43

melvin-bot bot removed the request for review from a team October 26, 2024 02:43

c3024 marked this pull request as draft October 26, 2024 02:43

Merge branch 'main' into self-guided-tours-v2-add-tasks

ef6a0c4

c3024 changed the title ~~[Pending on design doc][Self-guided tours][V2] Add tour links to onboarding tasks~~ [V2] Add tour links to onboarding tasks Oct 26, 2024

c3024 changed the title ~~[V2] Add tour links to onboarding tasks~~ [Self-guided tours][V2] Add tour links to onboarding tasks Oct 26, 2024

use existing param engagementChoice

512fa36

c3024 marked this pull request as ready for review October 26, 2024 09:31

Merge branch 'rush-tour' into self-guided-tours-v2-add-tasks

2e22f2c

rushatgabhane suggested changes Oct 28, 2024

View reviewed changes

src/CONST.ts Show resolved Hide resolved

rushatgabhane approved these changes Oct 28, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny October 28, 2024 01:30

Merge branch 'main' into self-guided-tours-v2-add-tasks

d756a15

mountiny assigned c3024 Oct 30, 2024

c3024 added 3 commits November 4, 2024 22:30

Merge branch 'main' into self-guided-tours-v2-add-tasks

8580e31

merge conflicts

c6e4184

remove unused type

9b8ec2c

mountiny reviewed Nov 4, 2024

View reviewed changes

mountiny mentioned this pull request Nov 4, 2024

[Self-guided tours][V3] Add tour link to FAB #51136

Merged

50 tasks

rushatgabhane mentioned this pull request Nov 4, 2024

[HOLD for payment 2024-11-14] [HOLD for payment 2024-10-29] Self-guided tours for onboarding (v1, 2, and 3) #50926

Closed

3 tasks

Merge branch 'main' into self-guided-tours-v2-add-tasks

7cc770c

dubielzyk-expensify approved these changes Nov 5, 2024

View reviewed changes

mountiny approved these changes Nov 5, 2024

View reviewed changes

mountiny merged commit a42f0f3 into Expensify:main Nov 5, 2024

github-actions bot mentioned this pull request Nov 5, 2024

Deploy Checklist: New Expensify 2024-11-05 #52084

Closed

71 tasks

IuliiaHerets mentioned this pull request Nov 6, 2024

[HOLD for payment 2024-12-03] [hold] Web - Concierge - Take a 2-minute tour task not autocomplete after finishing tour #52098

Closed

8 tasks

This was referenced Dec 6, 2024

Tasks for guided setup #39951

Merged

[HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Chat - There is no “Take a 2-minute tour” task at the Concierge chat #52985

Closed

rushatgabhane mentioned this pull request Dec 18, 2024

[HOLD for payment 2024-12-12] [$250] Take a 2-minute tour task not displayed in concierge #52908

Closed

8 tasks

tgolen reviewed Apr 2, 2025

View reviewed changes

Conversation

c3024 commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 26, 2024

Uh oh!

Uh oh!

rushatgabhane commented Oct 28, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane commented Oct 28, 2024

Uh oh!

rushatgabhane commented Oct 28, 2024

Uh oh!

dubielzyk-expensify commented Oct 28, 2024

Uh oh!

rushatgabhane commented Oct 29, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

rushatgabhane Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Nov 4, 2024

Uh oh!

mountiny commented Nov 4, 2024

Uh oh!

c3024 commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 5, 2024

Uh oh!

github-actions bot commented Nov 6, 2024

Uh oh!

github-actions bot commented Nov 7, 2024

Uh oh!

brunovjk commented Dec 6, 2024

Uh oh!

tgolen Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

c3024 commented Oct 21, 2024 •

edited

Loading

c3024 commented Nov 5, 2024 •

edited

Loading

c3024 Apr 2, 2025 •

edited

Loading