Skip to content

[CP Staging] Revert "Search suffix tree implementation"#51177

Merged
jasperhuangg merged 1 commit intomainfrom
revert-48652-perf/search-suffix-ukkonen-tree
Oct 21, 2024
Merged

[CP Staging] Revert "Search suffix tree implementation"#51177
jasperhuangg merged 1 commit intomainfrom
revert-48652-perf/search-suffix-ukkonen-tree

Conversation

@mjasikowski
Copy link
Contributor

@mjasikowski mjasikowski commented Oct 21, 2024 •
edited
Loading

Reverts #48652 to fix #51175
This PR is a straight revert.

@mjasikowski mjasikowski changed the title Revert "Search suffix tree implementation" [CP Staging] Revert "Search suffix tree implementation" Oct 21, 2024
@mjasikowski mjasikowski marked this pull request as ready for review October 21, 2024 14:05
@mjasikowski mjasikowski requested a review from a team as a code owner October 21, 2024 14:05
@melvin-bot melvin-bot bot requested a review from jasperhuangg October 21, 2024 14:06
@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2024

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 21, 2024 14:06
@mjasikowski mjasikowski self-assigned this Oct 21, 2024
@jasperhuangg
Copy link
Contributor

jasperhuangg commented Oct 21, 2024

@mjasikowski Can you update the OP to correctly link the issue?

@Gonals Gonals self-requested a review October 21, 2024 14:14
jasperhuangg
jasperhuangg approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@jasperhuangg jasperhuangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight revert

@jasperhuangg jasperhuangg merged commit 786d037 into main Oct 21, 2024
@jasperhuangg jasperhuangg deleted the revert-48652-perf/search-suffix-ukkonen-tree branch October 21, 2024 14:17
@melvin-bot melvin-bot bot added the Emergency label Oct 21, 2024
@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2024

@jasperhuangg looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 21, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mjasikowski
Copy link
Contributor Author

mjasikowski commented Oct 21, 2024 •
edited
Loading

not an emergency, straight revert

@ahmedGaber93 ahmedGaber93 mentioned this pull request Oct 21, 2024
Closed
6 tasks
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Closed
74 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.52-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@hannojg hannojg mentioned this pull request Oct 23, 2024
Closed
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gonals Gonals Gonals approved these changes

@jasperhuangg jasperhuangg jasperhuangg approved these changes

Assignees

@mjasikowski mjasikowski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search - Search does not returns group when entering group members

4 participants

@mjasikowski @jasperhuangg @OSBotify @Gonals