Fix keyboard doesn't show when magic code page is shown by bernhardoj · Pull Request #51453 · Expensify/App

bernhardoj · 2024-10-25T08:48:06Z

Details

The keyboard, specifically in Android, doesn't show when we open the magic code page/modal.

Fixed Issues

$ #51279
PROPOSAL: #51279 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open settings > Profile > Contact method
Tap the New contact method button
Enter any email that will be used as a secondary login
Press on anywhere to close the keyboard
Proceed to the magic code step
Verify the magic code input is focused and a keyboard is shown (mobile)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-10-25T08:48:11Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-10-25T08:51:05Z

src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

+            } else {
                inputValidateCodeRef.current?.focusLastSelected();
-            }, CONST.ANIMATED_TRANSITION);
+            }


Mobile safari can't auto focus with delay, otherwise the keyboard won't show.
ref: #10414

Thanks for this comment. Can you put it as a code comment in the code?

Ollyws · 2024-10-28T10:14:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

Ollyws

LGTM.

cead22 · 2024-10-28T14:03:14Z

src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

+            } else {
                inputValidateCodeRef.current?.focusLastSelected();
-            }, CONST.ANIMATED_TRANSITION);
+            }


Thanks for this comment. Can you put it as a code comment in the code?

cead22 · 2024-10-28T14:04:37Z

Everything else looks good

bernhardoj · 2024-11-13T13:38:01Z

@cead22 hi, can we merge this?

(sorry, I just realized I forgot to tag you when I added the comment)

cead22 · 2024-11-13T15:20:57Z

Oh yes, thanks for the bump!

OSBotify · 2024-11-13T15:31:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-14T00:52:53Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.0.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2024-11-15T14:16:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

disable immediate autofocus, except for mobile safari

e88680b

bernhardoj requested a review from a team as a code owner October 25, 2024 08:48

melvin-bot bot requested a review from Ollyws October 25, 2024 08:48

melvin-bot bot removed the request for review from a team October 25, 2024 08:48

bernhardoj commented Oct 25, 2024

View reviewed changes

Ollyws approved these changes Oct 28, 2024

View reviewed changes

melvin-bot bot requested a review from cead22 October 28, 2024 10:15

cead22 requested changes Oct 28, 2024

View reviewed changes

bernhardoj added 3 commits October 29, 2024 10:54

Merge branch 'main' into fix/51279-keyboard-doesn't-show

6a58b10

add comment

3b1e41b

Merge branch 'main' into fix/51279-keyboard-doesn't-show

d23fc21

cead22 approved these changes Nov 13, 2024

View reviewed changes

cead22 merged commit 1b9e302 into Expensify:main Nov 13, 2024

github-actions bot mentioned this pull request Nov 14, 2024

Deploy Checklist: New Expensify 2024-11-14 #52512

Closed

47 tasks

melvin-bot bot mentioned this pull request Nov 15, 2024

[Awaiting checklist] [$250] Contact method - Keyboard not opened when navigating to enter magic code step #51279

Closed

8 tasks

Ollyws mentioned this pull request Nov 25, 2024

Refactor: reuse ValidateCodeActionModal #49445

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix keyboard doesn't show when magic code page is shown#51453

Fix keyboard doesn't show when magic code page is shown#51453
cead22 merged 4 commits intoExpensify:mainfrom
bernhardoj:fix/51279-keyboard-doesn't-show

bernhardoj commented Oct 25, 2024

Uh oh!

melvin-bot bot commented Oct 25, 2024

Uh oh!

bernhardoj Oct 25, 2024

Uh oh!

cead22 Oct 28, 2024

Uh oh!

Ollyws commented Oct 28, 2024

Uh oh!

Ollyws left a comment

Uh oh!

cead22 Oct 28, 2024

Uh oh!

cead22 commented Oct 28, 2024

Uh oh!

bernhardoj commented Nov 13, 2024 •

edited

Loading

Uh oh!

cead22 commented Nov 13, 2024

Uh oh!

OSBotify commented Nov 13, 2024

Uh oh!

github-actions bot commented Nov 14, 2024

Uh oh!

github-actions bot commented Nov 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bernhardoj commented Oct 25, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 25, 2024

Uh oh!

bernhardoj Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

cead22 Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

Ollyws commented Oct 28, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

cead22 Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

cead22 commented Oct 28, 2024

Uh oh!

bernhardoj commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cead22 commented Nov 13, 2024

Uh oh!

OSBotify commented Nov 13, 2024

Uh oh!

github-actions bot commented Nov 14, 2024

Uh oh!

github-actions bot commented Nov 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernhardoj commented Nov 13, 2024 •

edited

Loading