Upgrade to React Native 0.76 by j-piasecki · Pull Request #51475 · Expensify/App

j-piasecki · 2024-10-25T14:54:13Z

Details

This PR upgrades the version of React Native used in the App to 0.76.

Upstream PRs:

Select text inside TextInput only once from onLayout facebook/react-native#47902
Transaction merging can cause CREATE mutations to be effectively dropped facebook/react-native#47960
Fix "folly::toJson: JSON object value was an INF" software-mansion/react-native-reanimated#6773
Use nullish assignment operator to assign entries in FormData expo/expo#33445
Export types using export type instead of export in expo-image-manipulator expo/expo#33446
Import types using import-type instead of import in expo-modules-core expo/expo#33447

Notes:

https://github.com/react-native-modal/react-native-modal - seems not to be maintained anymore
https://github.com/margelo/react-native-quick-sqlite - deprecated in favor of react-native-nitro-sqlite

Fixed Issues

$ #48911
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

jayeshmangwani · 2025-01-07T15:39:25Z

@WoLewicki I noticed some differences in the pod lock file locally. Could you confirm if you forgot to push those changes, or if it's just a local difference on my end that we can ignore?

jayeshmangwani · 2025-01-07T15:41:10Z

If possible, could we also fix the (rulesdir/no-default-id-values ) lint failure in the OptionRowLHN.tsx file here?

jayeshmangwani · 2025-01-07T15:41:56Z

@WoLewicki @mountiny I’ve tested on web, desktop, iOS (locally), and Android. So far, I haven’t found anything unusual during testing; everything seems perfectly fine to me.

WoLewicki · 2025-01-07T15:52:19Z

If possible, could we also fix the (rulesdir/no-default-id-values ) lint failure in the OptionRowLHN.tsx file here?

We talked about it already and since those changes are not coming from this PR, I would restrain from doing it.

I noticed some differences in the pod lock file locally. Could you confirm if you forgot to push those changes, or if it's just a local difference on my end that we can ignore?

I retested running pod install and did not get any changes. Also, the job checking the Podfile.lock succeded on CI so I think it might be something on your end.

jayeshmangwani · 2025-01-07T16:07:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

lgtm 🚀

mountiny

Thanks for the hard work. Lots of testing was done, QA did full regression testing and C+ did a thorough testing through the app, but as it goes with prs like this, there will be some issues stemming from it. @WoLewicki @j-piasecki please make sure to be around tomorrow to help with any issues as we will most likely not revert this PR and we want to avoid holding deploy for a long time, thank you!

mountiny · 2025-01-07T18:53:17Z

package.json

-    "expo-image": "1.12.15",
-    "expo-image-manipulator": "12.0.5",
+    "expo": "52.0.14",
+    "expo-asset": "^11.0.1",


What do we need this one for?

Expo depends on it. IIRC when bumping expo for RN 0.76, when I was building app without explicitly adding it here, it did not build for some reason. I can see that expo has dependency on it: https://github.com/expo/expo/blob/1a16bb66dcd8b0cc7391d9611d923fd54803af3c/packages/expo/package.json#L81 so I am not sure why it didn't work then.

We can try to remove it in follow-up and maybe it will be properly resolved from expo. It won't change much as for the contents of the app since it is required nevertheless.

Yeah lets keep an eye on this so we dont increase the bundle size unnecessary

mountiny · 2025-01-07T18:53:22Z

package.json

+    "expo": "52.0.14",
+    "expo-asset": "^11.0.1",
+    "expo-av": "^15.0.1",
+    "expo-font": "^13.0.1",


Same as above

mountiny · 2025-01-07T18:54:57Z

patches/expo-image-manipulator+13.0.5+002+fix-type-exports.patch

@@ -0,0 +1,17 @@
+diff --git a/node_modules/expo-image-manipulator/src/index.ts b/node_modules/expo-image-manipulator/src/index.ts


Can you please make sure all the new patches added here are tracked? I see you have added them to the list in the PR, but just reminding here if its up to date?

I will go through all of them when bumping to RN 0.77 ok?

mountiny · 2025-01-07T18:59:43Z

The ESLint check is failing because of one file but we will migrate that in another PR to avoid scope creep

melvin-bot · 2025-01-07T19:04:35Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2025-01-07T19:05:52Z

Not emergency as explained just above

OSBotify · 2025-01-07T19:16:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-08T02:59:35Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-08T03:39:24Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

shubham1206agra · 2025-01-08T12:26:35Z

android/build.gradle

+        buildToolsVersion = "35.0.0"
+        minSdkVersion = 24
+        compileSdkVersion = 35
        targetSdkVersion = 34


@WoLewicki Shouldn't targetSdkVersion be 35 as well?

Coming from https://react-native-community.github.io/upgrade-helper/?from=0.75.2&to=0.76.3 it seems like it should be left with 34. Do you have a reason for bumping it though?

marcochavezf · 2025-01-08T17:29:55Z

Hi guys, this PR is breaking the attachments in the composer (GH), any insight of what could be the solution?

mountiny · 2025-01-08T17:54:30Z

@marcochavezf lets try to fix it and CP a fix, lets talk in Slack

github-actions · 2025-01-10T03:38:00Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

s77rt · 2025-01-13T18:18:39Z

Hey, we think this upgrade caused a keyboard bug. We don't have much info here but probably due to some internal changes.

shubham1206agra · 2025-02-04T20:26:17Z

Hello

This upgrade broke the textinput label on iOS. More details #54971

eh2077 · 2025-09-29T10:30:33Z

There seems no upstream issue for the patches/expo-image-manipulator+13.0.5+001+initial.patch patch.

WoLewicki and others added 16 commits October 21, 2024 17:32

feat: update patches for expo

44682c9

feat: bump to newest RN

ffae2d9

chore: update patch numbers

e520b04

feat: update expo

d4c742b

chore: merge current main

54586a7

fix: update patches and fix gradle build

9df77bf

Bump to stable 0.76 and expo preview 3

43696bd

Add patch for mapbox

91253f2

Fix headless tasks causing crash

49d1255

Merge branch 'main' into @wolewicki/rn-76-upgrade

55aa7d3

Fix Android build

d9ed4fa

Merge branch 'main' into @wolewicki/rn-76-upgrade

9e2ef24

Fix lint

7ca13d2

Fix mock

3d5d0af

Merge branch 'main' into @wolewicki/rn-76-upgrade

99ae53e

Build Github Actions

3086b54

mountiny added the Ready To Build label Oct 28, 2024

This comment has been minimized.

Sign in to view

WoLewicki and others added 12 commits October 28, 2024 17:57

fix: enable bridgeless again

5a8cdbc

Merge branch 'main' into @wolewicki/rn-76-upgrade

e5f32d7

Override regexpu-core version

af36d31

Fix ios build

30bf3a5

Move git tests to other directory

ece3d70

Fix middleware tests

926bde4

Merge process from Expo and NodeJS

7c3f55d

Restore previous configs

7e6d265

Fix types & eslint

7dfffdd

Transpile updated expo modules on web

4358c2e

Add patches for type imports

50be77f

Merge branch 'main' into @wolewicki/rn-76-upgrade

4df9f59

jayeshmangwani approved these changes Jan 7, 2025

View reviewed changes

mountiny approved these changes Jan 7, 2025

View reviewed changes

mountiny merged commit 476b8d5 into Expensify:main Jan 7, 2025

melvin-bot bot added the Emergency label Jan 7, 2025

mountiny removed the Emergency label Jan 7, 2025

github-actions bot mentioned this pull request Jan 8, 2025

Deploy Checklist: New Expensify 2025-01-08 #54928

Closed

60 tasks

shubham1206agra reviewed Jan 8, 2025

View reviewed changes

marcochavezf mentioned this pull request Jan 8, 2025

[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] [$125] iOS - Unable to add attachment to chat and upload avatar #54970

Closed

8 tasks

pecanoro mentioned this pull request Jan 9, 2025

[HOLD for payment 2025-01-21] [HOLD for payment 2025-01-18] [$500] Hybrid Android - App overlaps with status bar when app is killed and relaunched #54988

Closed

8 tasks

melvin-bot bot mentioned this pull request Jan 10, 2025

[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] Upgrade react-native to 0.76 #48911

Closed

s77rt mentioned this pull request Jan 13, 2025

[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] [$250] Android - Group - Start Group button moves up and space is created below on confirmation tab #54975

Closed

8 tasks

NJ-2020 mentioned this pull request Jan 20, 2025

[$250] Android - Workspace - App crashes when tapping on workspace share link as other user #55195

Closed

8 tasks

shubham1206agra mentioned this pull request Feb 4, 2025

[HOLD for payment 2025-02-04] [$125] iOS - Extra spacing before field label #54971

Closed

8 tasks

		@@ -0,0 +1,17 @@
		diff --git a/node_modules/expo-image-manipulator/src/index.ts b/node_modules/expo-image-manipulator/src/index.ts

Conversation

j-piasecki commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment has been minimized.

jayeshmangwani commented Jan 7, 2025

Uh oh!

jayeshmangwani commented Jan 7, 2025

Uh oh!

jayeshmangwani commented Jan 7, 2025

Uh oh!

WoLewicki commented Jan 7, 2025

Uh oh!

jayeshmangwani commented Jan 7, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jan 7, 2025

Uh oh!

melvin-bot bot commented Jan 7, 2025

Uh oh!

mountiny commented Jan 7, 2025

Uh oh!

OSBotify commented Jan 7, 2025

Uh oh!

github-actions bot commented Jan 8, 2025

Uh oh!

github-actions bot commented Jan 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcochavezf commented Jan 8, 2025

Uh oh!

mountiny commented Jan 8, 2025

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

s77rt commented Jan 13, 2025

Uh oh!

shubham1206agra commented Feb 4, 2025

Uh oh!

eh2077 commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

j-piasecki commented Oct 25, 2024 •

edited

Loading