Skip to content

[CP Staging] Allow input on members page #51684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bondydaa merged 2 commits into from
Oct 29, 2024
Merged

[CP Staging] Allow input on members page #51684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d511d3a
Allow input on members page
grgia Oct 29, 2024
3f2c9b5
prettier
grgia Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/pages/RoomMembersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import SelectionListWithModal from '@components/SelectionListWithModal';
import Text from '@components/Text';
import type {WithCurrentUserPersonalDetailsProps} from '@components/withCurrentUserPersonalDetails';
import withCurrentUserPersonalDetails from '@components/withCurrentUserPersonalDetails';
import useDebouncedState from '@hooks/useDebouncedState';
import useLocalize from '@hooks/useLocalize';
import useNetwork from '@hooks/useNetwork';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
Expand Down Expand Up @@ -55,7 +54,7 @@ function RoomMembersPage({report, policies}: RoomMembersPageProps) {
const [selectedMembers, setSelectedMembers] = useState<number[]>([]);
const [removeMembersConfirmModalVisible, setRemoveMembersConfirmModalVisible] = useState(false);
const [userSearchPhrase] = useOnyx(ONYXKEYS.ROOM_MEMBERS_USER_SEARCH_PHRASE);
const [searchValue, debouncedSearchTerm, setSearchValue] = useDebouncedState('');
const [searchValue, setSearchValue] = useState('');
const [didLoadRoomMembers, setDidLoadRoomMembers] = useState(false);
const personalDetails = usePersonalDetails() || CONST.EMPTY_OBJECT;
const policy = useMemo(() => policies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID ?? ''}`], [policies, report?.policyID]);
Expand All @@ -71,14 +70,6 @@ function RoomMembersPage({report, policies}: RoomMembersPageProps) {
const [selectionMode] = useOnyx(ONYXKEYS.MOBILE_SELECTION_MODE);
const canSelectMultiple = isSmallScreenWidth ? selectionMode?.isEnabled : true;

useEffect(() => {
setSearchValue(userSearchPhrase ?? '');
}, [isFocusedScreen, setSearchValue, userSearchPhrase]);

useEffect(() => {
UserSearchPhraseActions.updateUserSearchPhrase(debouncedSearchTerm);
}, [debouncedSearchTerm]);

useEffect(() => {
if (isFocusedScreen) {
return;
Expand Down Expand Up @@ -195,6 +186,17 @@ function RoomMembersPage({report, policies}: RoomMembersPageProps) {
return activeParticipants.length >= CONST.SHOULD_SHOW_MEMBERS_SEARCH_INPUT_BREAKPOINT;
}, [participants, personalDetails, isOffline, report]);

useEffect(() => {
if (!isFocusedScreen || !shouldShowTextInput) {
return;
}
setSearchValue(userSearchPhrase ?? '');
}, [isFocusedScreen, shouldShowTextInput, userSearchPhrase]);

useEffect(() => {
UserSearchPhraseActions.updateUserSearchPhrase(searchValue);
}, [searchValue]);

Comment on lines +189 to +199
Copy link
Contributor

@bondydaa bondydaa Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm just realizing isn't this basically the same as what already exists immediately below it?

App/src/pages/RoomMembersPage.tsx

Lines 189 to 210 in 3f2c9b5

useEffect(() => {
if (!isFocusedScreen || !shouldShowTextInput) {
return;
}
setSearchValue(userSearchPhrase ?? '');
}, [isFocusedScreen, shouldShowTextInput, userSearchPhrase]);
useEffect(() => {
UserSearchPhraseActions.updateUserSearchPhrase(searchValue);
}, [searchValue]);
useEffect(() => {
if (!isFocusedScreen) {
return;
}
if (shouldShowTextInput) {
setSearchValue(userSearchPhrase ?? '');
} else {
UserSearchPhraseActions.clearUserSearchPhrase();
setSearchValue('');
}
}, [isFocusedScreen, setSearchValue, shouldShowTextInput, userSearchPhrase]);

Copy link
Contributor

@Beamanator Beamanator Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh looks veeeeery similar!

Copy link
Contributor Author

@grgia grgia Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good point, maybe we should combine?

useEffect(() => {
if (!isFocusedScreen) {
return;
Expand Down Expand Up @@ -385,9 +387,7 @@ function RoomMembersPage({report, policies}: RoomMembersPageProps) {
textInputLabel={translate('selectionList.findMember')}
disableKeyboardShortcuts={removeMembersConfirmModalVisible}
textInputValue={searchValue}
onChangeText={(value) => {
setSearchValue(value);
}}
onChangeText={setSearchValue}
headerMessage={headerMessage}
turnOnSelectionModeOnLongPress
onTurnOnSelectionMode={(item) => item && toggleUser(item)}
Expand Down