Update transaction violations when the money request is paid by marcochavezf · Pull Request #51770 · Expensify/App

marcochavezf · 2024-10-30T22:08:58Z

~~On hold for https://github.com/Expensify/Web-Expensify/pull/44222~~

Explanation of Change

Fixed Issues

$ #51141
PROPOSAL: #51141 (comment)

Tests

Pre-requisite: The account should be on canUseDupeDetection

Create a new workspace.
Submit an expense to the workspace chat.
Pay the expense.
Submit the same expense in Step 3 to the workspace chat.
Click on the expense preview.
Click Pay elsewhere and pay it.
Verify the Review duplicates button disappears after the expense is paid.

Verify that no errors appear in the JS console

Offline tests

Same test steps go offline before the money request is paid

QA Steps

Same as test and offline steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Offline:

1 request:

Screen.Recording.2024-10-30.at.4.02.26.p.m.mov

2 requests:

Screen.Recording.2024-10-30.at.4.01.44.p.m.mov

MacOS: Desktop

melvin-bot · 2024-10-30T22:09:03Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-10-31T03:50:39Z

Will this require a C+ review?

marcochavezf · 2024-10-31T18:18:09Z

Will this require a C+ review?

Yes, please! But let's wait until the BE fix is deployed

allgandalf · 2024-10-31T18:24:01Z

No worries!

marcochavezf · 2024-11-06T23:44:00Z

BE PR was deployed, and now this one is ready for review @allgandalf

allgandalf · 2024-11-07T04:15:08Z

That's cool, I will start review today

allgandalf · 2024-11-07T04:15:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-25.at.12.24.47.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-25.at.12.18.37.PM.mov

iOS: Native

Screen.Recording.2024-11-25.at.12.17.21.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-08.at.4.29.40.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-08.at.4.24.56.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-08.at.4.27.37.PM.mov

allgandalf · 2024-11-08T10:54:49Z

@marcochavezf can you update the testing steps to mention that the QA should be on canUseDupeDetection beta to test this PR :)

allgandalf · 2024-11-08T11:06:34Z

Bug? : RBR is not cleared on report preview when we pay the expense, we should fix this no @marcochavezf ?

marcochavezf · 2024-11-11T17:18:57Z

Oh interesting I will check it out today, thanks for catching that

allgandalf · 2024-11-12T08:25:37Z

All good, let me know when you have an update

allgandalf · 2024-11-15T10:09:42Z

@marcochavezf any luck looking into the bug?

marcochavezf · 2024-11-15T19:30:45Z

Is this happening offline, right? Because the RBR is cleared out after I pay the expense:

Screen.Recording.2024-11-15.at.1.25.03.p.m.mov

Can you share a video how you're getting the error? 🙏🏽

allgandalf · 2024-11-18T18:16:54Z

this slipped through the cracks i will check today

allgandalf · 2024-11-21T14:29:06Z

Is this happening offline, right? Because the RBR is cleared out after I pay the expense:

i guess that workspace i tested with was connected with a accounting software so something was odd there, i tested on new workspace and this doesn't happen.

Is this happening offline, right?

This works fine now

Screen.Recording.2024-11-21.at.7.58.31.PM.mov

I will complete the checklist now

allgandalf · 2024-11-21T14:35:03Z

@marcochavezf can you merge main, there are many issues on the current branch for native devices

marcochavezf · 2024-11-22T19:09:46Z

Updated!

allgandalf

Tests well both online and offline, LGTM 🚀

melvin-bot · 2024-11-25T06:56:12Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

deetergp

Code looks good and tests well on web 👍

OSBotify · 2024-11-25T20:33:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-26T16:40:24Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.67-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-28T14:21:27Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.67-9 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Update transaction violations when the money request is paid

528d544

marcochavezf self-assigned this Oct 30, 2024

marcochavezf requested a review from a team as a code owner October 30, 2024 22:08

melvin-bot bot requested a review from allgandalf October 30, 2024 22:09

melvin-bot bot removed the request for review from a team October 30, 2024 22:09

marcochavezf mentioned this pull request Oct 30, 2024

[HOLD for payment 2024-12-05] Review duplicates - Review duplicates button does not disappear after the expense is paid #51141

Closed

8 tasks

Remove unused value

234327d

marcochavezf changed the title ~~[HOLD] Update transaction violations when the money request is paid~~ Update transaction violations when the money request is paid Nov 6, 2024

Merge branch 'main' into marco-clearDuplicateTransactions

3d3b4ed

allgandalf approved these changes Nov 25, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp November 25, 2024 06:56

deetergp approved these changes Nov 25, 2024

View reviewed changes

deetergp merged commit e4ac07a into main Nov 25, 2024

deetergp deleted the marco-clearDuplicateTransactions branch November 25, 2024 20:22

github-actions bot mentioned this pull request Nov 26, 2024

Deploy Checklist: New Expensify 2024-11-26 #53142

Closed

75 tasks

Conversation

marcochavezf commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 30, 2024

Uh oh!

allgandalf commented Oct 31, 2024

Uh oh!

marcochavezf commented Oct 31, 2024

Uh oh!

allgandalf commented Oct 31, 2024

Uh oh!

marcochavezf commented Nov 6, 2024

Uh oh!

allgandalf commented Nov 7, 2024

Uh oh!

allgandalf commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Nov 8, 2024

Uh oh!

allgandalf commented Nov 8, 2024

Uh oh!

marcochavezf commented Nov 11, 2024

Uh oh!

allgandalf commented Nov 12, 2024

Uh oh!

allgandalf commented Nov 15, 2024

Uh oh!

marcochavezf commented Nov 15, 2024

Uh oh!

allgandalf commented Nov 18, 2024

Uh oh!

allgandalf commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allgandalf commented Nov 21, 2024

Uh oh!

marcochavezf commented Nov 22, 2024

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 25, 2024

Uh oh!

deetergp left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 25, 2024

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

github-actions bot commented Nov 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marcochavezf commented Oct 30, 2024 •

edited

Loading

allgandalf commented Nov 7, 2024 •

edited

Loading

allgandalf commented Nov 21, 2024 •

edited

Loading