Merged
Conversation
Contributor
|
Your New Help changes have been deployed to https://11db5377.newhelp.pages.dev ⚡️ |
Contributor
Author
|
@Gonals I think this is ready for your review! Remember: This site is still hidden behind a robots.txt, and not linked anywhere. So it's very much a prototype/WIP, but I'd like to merge it so I can engage others in the next steps. |
Gonals
reviewed
Nov 5, 2024
Contributor
Author
|
@Gonals Can you add the PR reviewer checklist? |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Gonals
approved these changes
Nov 6, 2024
Contributor
|
🚀Deployed to NewHelp production! 🚀 |
60 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.59-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This is part of the ongoing effort to create New Help. This includes a ton of new but largely AI-generated fake content, as well as updates to the ToC.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/414789
PROPOSAL:
(none)
Tests
Offline tests
n/a
QA Steps
n/a
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
n/a