fix gray-out and name issue in offline category update by huult · Pull Request #51927 · Expensify/App

huult · 2024-11-02T15:27:01Z

Details

Fixed Issues

$ #50563
PROPOSAL: #50563 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Navigate to Workspace Settings > Categories.
Open the Travel category (because it is linked to the Airlines spend in Settings).
Change the category name and click Save.
Click Settings and verify that the Airlines category name is updated.
Go offline.
Open the Travel category, rename it, and click Save.
Click Settings and then open the Airlines category.
Verify that the Travel category has the updated name and is grayed out.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-02.at.22.16.16.mp4

Android: mWeb Chrome

Screen.Recording.2024-11-02.at.22.18.36.mp4

iOS: Native

Screen.Recording.2024-11-02.at.22.11.32.mp4

iOS: mWeb Safari

Screen.Recording.2024-11-02.at.22.13.27.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-11-02.at.22.01.40.mp4

MacOS: Desktop

Screen.Recording.2024-11-02.at.22.04.10.mp4

melvin-bot · 2024-11-02T15:27:05Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ategory-update-gray-out-and-name

eVoloshchak · 2024-11-05T21:42:18Z

src/libs/Middleware/SaveResponseInOnyx.ts

    SIDE_EFFECT_REQUEST_COMMANDS.RECONNECT_APP,
    WRITE_COMMANDS.CLOSE_ACCOUNT,
    WRITE_COMMANDS.DELETE_MONEY_REQUEST,
+    WRITE_COMMANDS.RENAME_WORKSPACE_CATEGORY,


all these requests are updating the app to the most current state

Is this really the case for WRITE_COMMANDS.RENAME_WORKSPACE_CATEGORY request?

Yes, I added it to fix the issue of updating the category. After that, when I go back and go to the settings, I see that the category is grayed out even though it was changed

VIDEO

Screen.Recording.2024-11-06.at.14.01.14.mp4

The RCA: lastUpdateIDFromClient is less than the previousUpdateID received, so we set this response, which did not clear the pendingAction. This issue occurred, and it only happens the first time.

This issue same RCA with #50780 #49329 and #44114

I raised this issue in Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1730457202958539?thread_ts=1730392335.081509&cid=C01GTK53T8Q

I think this issue is out of the scope of this ticket and has a different RCA. However, if we don't fix it, we will need to perform a regression test. Can you advise?

@eVoloshchak Could you review my comment above when you have time? Thank you

The RCA: lastUpdateIDFromClient is less than the previousUpdateID received

@huult, it seems to me that this should be resolved on the backend ideally. Do you agree with that?

@eVoloshchak Yes, if they are able to fix it, we should update from the BE side. This issue is not related to this ticket.

@eVoloshchak what do you think?

Can we skip this case? It is not related to this issue and has a different RCA. We will report a new ticket to fix it.

Yes, that's exactly what needs to be done. This should be fixed on the back end, it's not related to this PR

@eVoloshchak I think we need to confirm with the internal team to avoid regression when testing this case, or we can add this command to the ignore list. Which option do you choose or suggest?

@eVoloshchak Could you review this pull request so it can be completed? It has been open for 3 weeks and involves a small change, so your prompt review would be appreciated.

@eVoloshchak I have removed this command from the ignore list.

…st-time category update case

…ategory-update-gray-out-and-name

eVoloshchak · 2024-11-25T18:26:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-30.at.17.13.09.mov

Android: mWeb Chrome

Screen.Recording.2024-11-25.at.19.32.05.mov

iOS: Native

Screen.Recording.2024-10-30.at.17.31.14.mov

iOS: mWeb Safari

Screen.Recording.2024-11-25.at.19.44.18.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-25.at.19.29.12.mov

MacOS: Desktop

Screen.Recording.2024-11-25.at.19.36.20.mov

eVoloshchak

LGTM!

src/libs/actions/Policy/Category.ts

…ategory-update-gray-out-and-name

huult · 2024-11-28T14:21:17Z

@youssef-lr I've updated your feedback. Could you please check it again? Thank you!

src/libs/actions/Policy/Category.ts

…ategory-update-gray-out-and-name

huult · 2024-11-29T03:08:20Z

@youssef-lr I've updated your feedback. Could you please check it again? Thank you!

huult · 2024-12-02T16:02:26Z

@youssef-lr What do you think of my update?

OSBotify · 2024-12-04T21:11:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-05T15:16:52Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-05T16:01:59Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-09T16:05:14Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.72-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix gray-out and name issue in offline category update

36a58e3

huult requested a review from a team as a code owner November 2, 2024 15:27

melvin-bot bot requested a review from eVoloshchak November 2, 2024 15:27

melvin-bot bot removed the request for review from a team November 2, 2024 15:27

huult mentioned this pull request Nov 2, 2024

[HOLD for payment 2024-12-16] [HOLD for payment 2024-11-11] [$250] Categories -Category name for spend is not updated offline & a new category is created instead #50563

Closed

6 tasks

Merge remote-tracking branch 'upstream/main' into 50563-fix-offline-c…

724046b

…ategory-update-gray-out-and-name

eVoloshchak reviewed Nov 5, 2024

View reviewed changes

huult added 7 commits November 6, 2024 05:47

remove unused code

d582cc3

Add RENAME_WORKSPACE_CATEGORY to ignore last update ID for fixing fir…

09a7c37

…st-time category update case

Merge remote-tracking branch 'upstream/main' into 50563-fix-offline-c…

a929426

…ategory-update-gray-out-and-name

remove renaming ws category

d4ce223

Merge remote-tracking branch 'upstream/main' into 50563-fix-offline-c…

1e406c7

…ategory-update-gray-out-and-name

Merge remote-tracking branch 'upstream/main' into 50563-fix-offline-c…

91e7a4c

…ategory-update-gray-out-and-name

Remove unused imports

1b89a1f

eVoloshchak approved these changes Nov 25, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr November 25, 2024 19:04

youssef-lr reviewed Nov 26, 2024

View reviewed changes

src/libs/actions/Policy/Category.ts Outdated Show resolved Hide resolved

huult added 2 commits November 27, 2024 10:56

Merge remote-tracking branch 'upstream/main' into 50563-fix-offline-c…

22b0f36

…ategory-update-gray-out-and-name

Update MCC group for failure data

38d8ba7

youssef-lr reviewed Nov 28, 2024

View reviewed changes

src/libs/actions/Policy/Category.ts Outdated Show resolved Hide resolved

huult added 2 commits November 29, 2024 09:20

Merge remote-tracking branch 'upstream/main' into 50563-fix-offline-c…

d9f7184

…ategory-update-gray-out-and-name

Update MCC group for failed data

425e743

youssef-lr approved these changes Dec 4, 2024

View reviewed changes

youssef-lr merged commit 35e4761 into Expensify:main Dec 4, 2024

github-actions bot mentioned this pull request Dec 5, 2024

Deploy Checklist: New Expensify 2024-12-05 #53631

Closed

43 tasks

Conversation

huult commented Nov 2, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 2, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huult Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

huult commented Nov 28, 2024

Uh oh!

Uh oh!

huult commented Nov 29, 2024

Uh oh!

huult commented Dec 2, 2024

Uh oh!

OSBotify commented Dec 4, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

huult Nov 6, 2024 •

edited

Loading

eVoloshchak commented Nov 25, 2024 •

edited

Loading