Fix fullscreen video controls difficult to click#52302
Merged
Gonals merged 3 commits intoExpensify:mainfrom Nov 20, 2024
Merged
Fix fullscreen video controls difficult to click#52302Gonals merged 3 commits intoExpensify:mainfrom
Gonals merged 3 commits intoExpensify:mainfrom
Conversation
Contributor
Author
|
@akinwale Could you review this when you have a moment? Thanks! |
Contributor
|
Thanks for the bump. Reviewing now. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: Native52302-android-native.mp4Android: mWeb Chrome52302-android-chrome.mp4iOS: Native52302-ios-native.mp4iOS: mWeb Safari52302-ios-safari.mp4MacOS: Chrome / Safari52302-web.mp4MacOS: Desktop52302-desktop.mp4 |
Gonals
approved these changes
Nov 20, 2024
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
Author
|
It looks like the linking test failure is tracked in #52813. |
65 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.65-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #51246
PROPOSAL: #51246 (comment)
Tests
Offline tests
The test steps do not apply in offline mode.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native.mp4
Android: mWeb Chrome
android-web.mp4
iOS: Native
ios-native.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
mac-web.mp4
MacOS: Desktop
mac-desktop.mp4