Fix: Expensify card - Error when wrong 4 digit is used persists for a few sec after a refresh by nyomanjyotisa · Pull Request #52303 · Expensify/App

nyomanjyotisa · 2024-11-11T08:23:52Z

Explanation of Change

Fixed Issues

$ #51396
PROPOSAL: #51396 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Pre-conditions:

Workspace is connected with a bank account
Workspace has a member invited
Workspace has enabled Expensify card
Admin has issued a physical card for employee
Employee is done adding shipping details to receive the card

Sign in with the invited member's account
Go to wallet > Open issued physical card RHP
Use random 4-digit number to activate the card
Refresh the page
Verify that no error message is displayed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Unable to test on native Android since the page cannot be refreshed/reloaded

Android: mWeb Chrome

Android-mWeb.Chrome.mp4

iOS: Native

Unable to test on native iOS since the page cannot be refreshed/reloaded

iOS: mWeb Safari

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

MacOS: Desktop

MacOS-Desktop.mp4

… few sec after a refresh

nyomanjyotisa · 2024-11-12T09:32:52Z

Hi @alitoshmatov The error is still briefly displayed (but shorter then before, < 1 sec) on mweb android and ios using my proposed solution, even if i change useEffect to useLayoutEffect

expensify-app-fork-README-md-at-main-.-margelo-expensify-app-fork.online-video-cutter.com.1.mp4

Can we implement 'beforeunload' event listener instead? It works in mweb

    useEffect(() => {
        const handleBeforeUnload = () => {
            if (!inactiveCard?.cardID) {
                return;
            }
            CardSettings.clearCardListErrors(inactiveCard?.cardID);
        };
    
        window.addEventListener('beforeunload', handleBeforeUnload);
    
        return () => {
            if (!inactiveCard?.cardID) {
                return;
            }
            CardSettings.clearCardListErrors(inactiveCard?.cardID);
            window.removeEventListener('beforeunload', handleBeforeUnload);
        };
    }, [inactiveCard?.cardID]);

New-Expensify.34.mp4

alitoshmatov · 2024-11-12T09:44:40Z

@nyomanjyotisa I don't think that is a good idea. I think we rushed on choosing a solution, we have similar cases on signup and 2FA pages, can we check them and see what was their solution for the same issue

nyomanjyotisa · 2024-11-13T14:44:26Z

@alitoshmatov for the signup and 2fa, we use Onyx.init to set the ONYXKEYS.ACCOUNT with the CONST.DEFAULT_ACCOUNT_DATA which reset the error message. this will reset the error message every page load

App/src/setup/index.ts

Line 34 in b1c1a4b

[ONYXKEYS.ACCOUNT]: CONST.DEFAULT_ACCOUNT_DATA,

App/src/CONST.ts

Line 1399 in b1c1a4b

DEFAULT_ACCOUNT_DATA: {errors: null, success: '', isLoading: false},

I think for this expensify card case we can't do the same as above, since the error message is under specific cardID

nyomanjyotisa · 2024-11-13T15:07:28Z

@alitoshmatov another approach: Only allow to show error message after user click submit button

const [shouldShowError, setShouldShowError] = useState<boolean>(false);

App/src/pages/settings/Wallet/ActivatePhysicalCardPage.tsx

Line 104 in b1c1a4b

const submitAndNavigateToNextPage = useCallback(() => {

    const submitAndNavigateToNextPage = useCallback(() => {
        setShouldShowError(true)
        ...

App/src/pages/settings/Wallet/ActivatePhysicalCardPage.tsx

Line 143 in b1c1a4b

errorText={formError || cardError}

errorText={shouldShowError ? (formError || cardError) : ''}

melvin-bot · 2024-11-14T15:13:21Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2024-11-17T14:34:50Z

@alitoshmatov another approach: Only allow to show error message after user click submit button

@nyomanjyotisa This changes existing behavior not viable option

nyomanjyotisa · 2024-11-20T12:31:17Z

@alitoshmatov I think it is expected not to showing any errors before submit action

alitoshmatov · 2024-11-20T12:44:25Z

But when there is an error and you input valid answer error should be dismissed automatically. I think we should close this PR, and go back to the issue to choose a new proposal

nyomanjyotisa · 2024-11-21T06:01:47Z

But when there is an error and you input valid answer error should be dismissed automatically.

It doesn't change this behavior actually

errorText={shouldShowError ? (formError || cardError) : ''}

if there is no error on formError or cardError it won't show any error although the shouldShowErroris true

shouldShowError variable name seems confusing, might need to change to shouldAllowToShowError or something

alitoshmatov · 2024-11-26T08:31:22Z

You are right, I didn't see this part where errors are cleared everytime there is an input

App/src/pages/settings/Wallet/ActivatePhysicalCardPage.tsx

Lines 94 to 102 in b1c1a4b

    
           const onCodeInput = (text: string) => { 
        
               setFormError(''); 
        
               if (cardError && inactiveCard?.cardID) { 
        
                   CardSettings.clearCardListErrors(inactiveCard?.cardID); 
        
               } 
        
               setLastFourDigits(text); 
        
           };

alitoshmatov · 2024-11-26T08:32:37Z

@cristipaval We had an issue with original solution, so we decided to go with this new solution. What do you think?

cristipaval · 2024-11-26T13:32:44Z

@cristipaval We had an issue with original solution, so we decided to go with this new solution. What do you think?

fine for me

nyomanjyotisa · 2024-11-27T05:17:36Z

PR and recordings are updated and ready for review 👍

alitoshmatov · 2024-11-27T14:50:51Z

src/pages/settings/Wallet/ActivatePhysicalCardPage.tsx

    const [formError, setFormError] = useState('');
    const [lastFourDigits, setLastFourDigits] = useState('');
    const [lastPressedDigit, setLastPressedDigit] = useState('');
+    const [shouldAllowToShowError, setShouldAllowToShowError] = useState<boolean>(false);


Very confusing, I think canShowError is more suitable.

alitoshmatov · 2024-11-27T14:52:46Z

Please update all recordings

nyomanjyotisa · 2024-11-27T16:00:12Z

Sure, I've updated it as requested @alitoshmatov

alitoshmatov · 2024-12-02T17:07:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

code-mweb.mp4

iOS: Native

iOS: mWeb Safari

code-safari.mp4

MacOS: Chrome / Safari

code-web.mov

MacOS: Desktop

code-desktop.mov

alitoshmatov

LGTM!

cristipaval · 2024-12-03T10:14:09Z

@nyomanjyotisa could you please resolve the conflicts?

nyomanjyotisa · 2024-12-04T01:46:33Z

Conflict resolved @cristipaval

OSBotify · 2024-12-04T10:15:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-05T15:16:58Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-05T16:02:05Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-09T16:05:20Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.72-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Fix: Expensify card - Error when wrong 4 digit is used persists for a…

55a077a

… few sec after a refresh

fix and migrate to useOnyx

5b131b5

nyomanjyotisa marked this pull request as ready for review November 14, 2024 15:13

nyomanjyotisa requested a review from a team as a code owner November 14, 2024 15:13

melvin-bot bot requested review from alitoshmatov and removed request for a team November 14, 2024 15:13

nyomanjyotisa mentioned this pull request Nov 25, 2024

[HOLD for payment 2024-12-16] [$250] Web - Expensify card - Error when wrong 4 digit is used persists for a few sec after a refresh #51396

Closed

8 tasks

minor fix

3dff8e7

alitoshmatov reviewed Nov 27, 2024

View reviewed changes

minor fix

7444aea

alitoshmatov approved these changes Dec 2, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval December 2, 2024 17:08

Merge branch 'main' into issue-51396

07290cb

cristipaval approved these changes Dec 4, 2024

View reviewed changes

cristipaval merged commit 00f0dee into Expensify:main Dec 4, 2024

github-actions bot mentioned this pull request Dec 5, 2024

Deploy Checklist: New Expensify 2024-12-05 #53631

Closed

43 tasks

nyomanjyotisa mentioned this pull request Dec 12, 2024

[HOLD for payment 2025-02-04] [$125] mWeb - 2FA - In 2FA magic code page, after refresh briefly error message is displayed #54009

Closed

8 tasks

Conversation

nyomanjyotisa commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

nyomanjyotisa commented Nov 12, 2024

Uh oh!

alitoshmatov commented Nov 12, 2024

Uh oh!

nyomanjyotisa commented Nov 13, 2024

Uh oh!

nyomanjyotisa commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Nov 14, 2024

Uh oh!

alitoshmatov commented Nov 17, 2024

Uh oh!

nyomanjyotisa commented Nov 20, 2024

Uh oh!

alitoshmatov commented Nov 20, 2024

Uh oh!

nyomanjyotisa commented Nov 21, 2024

Uh oh!

alitoshmatov commented Nov 26, 2024

Uh oh!

alitoshmatov commented Nov 26, 2024

Uh oh!

cristipaval commented Nov 26, 2024

Uh oh!

nyomanjyotisa commented Nov 27, 2024

Uh oh!

alitoshmatov Nov 27, 2024

Choose a reason for hiding this comment

Uh oh!

alitoshmatov commented Nov 27, 2024

Uh oh!

nyomanjyotisa commented Nov 27, 2024

Uh oh!

alitoshmatov commented Dec 2, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

alitoshmatov left a comment

Choose a reason for hiding this comment

Uh oh!

cristipaval commented Dec 3, 2024

Uh oh!

nyomanjyotisa commented Dec 4, 2024

Uh oh!

OSBotify commented Dec 4, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nyomanjyotisa commented Nov 11, 2024 •

edited

Loading

nyomanjyotisa commented Nov 13, 2024 •

edited

Loading