Implemented International Bank Account flow#52322
Merged
MonilBhavsar merged 70 commits intoExpensify:mainfrom Dec 31, 2024
Merged
Implemented International Bank Account flow#52322MonilBhavsar merged 70 commits intoExpensify:mainfrom
MonilBhavsar merged 70 commits intoExpensify:mainfrom
Conversation
MonilBhavsar
approved these changes
Dec 31, 2024
| bankAccountID: number; | ||
| onfidoData: string; | ||
| policyID?: string; | ||
| policyID: string; |
Contributor
There was a problem hiding this comment.
NAB, We could probably revert this change as the code works with empty policyID
68 tasks
|
@shubham1206agra @MonilBhavsar What our QA team should be validating here? Could you help with this? |
Contributor
|
@kavimuru the QA steps are in this doc https://docs.google.com/document/d/1H1hMnTcMrR8MT6BXz3fCE99eVIurgrHDtaxIH5aW8Ug/edit?usp=sharing |
Contributor
|
Please tag me and @shubham1206agra if any regression is coming out from this PR. We'll handle that in a followup PR. Thanks! |
Contributor
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.80-1 🚀
|
8 tasks
8 tasks
8 tasks
Closed
8 tasks
This was referenced Jan 2, 2025
Closed
This was referenced Jan 2, 2025
Closed
8 tasks
Contributor
|
reverted - see #54729 |
50 tasks
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.80-6 🚀
|
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #51082
Tests
https://docs.google.com/document/d/19ltca0iKwB00pReokjBf9rEHoi1u8y-2_x-82jMibho/edit?pli=1&tab=t.0#bookmark=id.tf0af0lugbin
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-11-25.at.5.24.19.PM.mov
Android: mWeb Chrome
Screen.Recording.2024-11-25.at.4.46.43.PM.mov
iOS: Native
Screen.Recording.2024-11-25.at.5.08.17.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-11-25.at.4.29.32.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-11-25.at.4.23.43.PM.mov
MacOS: Desktop
Screen.Recording.2024-11-25.at.4.59.34.PM.mov