Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/libs/actions/Link.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@ function buildOldDotURL(url: string, shortLivedAuthToken?: string): Promise<stri
/**
* @param shouldSkipCustomSafariLogic When true, we will use `Linking.openURL` even if the browser is Safari.
*/
function openExternalLink(url: string, shouldSkipCustomSafariLogic = false) {
asyncOpenURL(Promise.resolve(), url, shouldSkipCustomSafariLogic);
function openExternalLink(url: string, shouldSkipCustomSafariLogic = false, shouldOpenInSameTab = false) {
asyncOpenURL(Promise.resolve(), url, shouldSkipCustomSafariLogic, shouldOpenInSameTab);
}

function openOldDotLink(url: string) {
function openOldDotLink(url: string, shouldOpenInSameTab = false) {
if (isNetworkOffline) {
buildOldDotURL(url).then((oldDotURL) => openExternalLink(oldDotURL));
buildOldDotURL(url).then((oldDotURL) => openExternalLink(oldDotURL, undefined, shouldOpenInSameTab));
return;
}

Expand All @@ -82,6 +82,8 @@ function openOldDotLink(url: string) {
.then((response) => (response ? buildOldDotURL(url, response.shortLivedAuthToken) : buildOldDotURL(url)))
.catch(() => buildOldDotURL(url)),
(oldDotURL) => oldDotURL,
undefined,
shouldOpenInSameTab,
);
}

Expand Down
10 changes: 7 additions & 3 deletions src/libs/asyncOpenURL/index.website.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,26 @@
import {Linking} from 'react-native';
import type {Linking as LinkingWeb} from 'react-native-web';
import getPlatform from '@libs/getPlatform';
import Log from '@libs/Log';
import CONST from '@src/CONST';
import type AsyncOpenURL from './types';

/**
* Prevents Safari from blocking pop-up window when opened within async call.
* @param shouldSkipCustomSafariLogic When true, we will use `Linking.openURL` even if the browser is Safari.
*/
const asyncOpenURL: AsyncOpenURL = (promise, url, shouldSkipCustomSafariLogic) => {
const asyncOpenURL: AsyncOpenURL = (promise, url, shouldSkipCustomSafariLogic, shouldOpenInSameTab) => {
if (!url) {
return;
}

const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
const canOpenURLInSameTab = getPlatform() === CONST.PLATFORM.WEB;

if (!isSafari || shouldSkipCustomSafariLogic) {
if (!isSafari || !!shouldSkipCustomSafariLogic || !!shouldOpenInSameTab) {
promise
.then((params) => {
Linking.openURL(typeof url === 'string' ? url : url(params));
(Linking.openURL as LinkingWeb['openURL'])(typeof url === 'string' ? url : url(params), shouldOpenInSameTab && canOpenURLInSameTab ? '_self' : undefined);
})
.catch(() => {
Log.warn('[asyncOpenURL] error occured while opening URL', {url});
Expand Down
2 changes: 1 addition & 1 deletion src/libs/asyncOpenURL/types.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
type AsyncOpenURL = <T>(promise: Promise<T>, url: string | ((params: T) => string), shouldSkipCustomSafariLogic?: boolean) => void;
type AsyncOpenURL = <T>(promise: Promise<T>, url: string | ((params: T) => string), shouldSkipCustomSafariLogic?: boolean, shouldOpenInSameTab?: boolean) => void;

export default AsyncOpenURL;
2 changes: 1 addition & 1 deletion src/pages/settings/ExitSurvey/ExitSurveyConfirmPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function ExitSurveyConfirmPage({route, navigation}: ExitSurveyConfirmPageProps)
onPress={() => {
ExitSurvey.switchToOldDot();
Navigation.dismissModal();
Link.openOldDotLink(CONST.OLDDOT_URLS.INBOX);
Link.openOldDotLink(CONST.OLDDOT_URLS.INBOX, true);
}}
isDisabled={isOffline}
/>
Expand Down