Feat: Add account validation step to Invoices page by hungvu193 · Pull Request #52356 · Expensify/App

hungvu193 · 2024-11-12T07:12:00Z

Explanation of Change

This PR adds validation steps to Invoices page and also fixes some issues left by our previous PR.

Fixed Issues

$ #51166
$ #52336
PROPOSAL: N/A

Tests

Create a new workspace with your brand new account (Your account muse be not invalidated yet).
Go to More feature and enable Invoices feature.
Go to Invoices page and press Add bank account.
An modal shows, enter the code.
Verify you can continue the VBBA flow.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-15.at.13.35.11.mov

Android: mWeb Chrome

Screen.Recording.2024-11-15.at.13.42.02.mov

iOS: Native

Screen.Recording.2024-11-15.at.13.28.07.mov

iOS: mWeb Safari

Screen.Recording.2024-11-15.at.13.28.48.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-15.at.13.19.31.mov

MacOS: Desktop

Screen.Recording.2024-11-15.at.13.19.31.mov

hungvu193 · 2024-11-13T03:08:31Z

src/pages/settings/Wallet/VerifyAccountPage.tsx

+        Navigation.goBack();
        Navigation.navigate(navigateBackTo);


@getusha This PR is ready for review. I think you might need to test the case I mentioned in our DM.
Also another flow that used VerifyAccountPage and see if there's problem with this goBack here.

@adamgrzybowski @WojtekBoman I am not sure if this is a best practice for managing the navigation. Should we use dismissModal here?

I see this goBack and navigate pattern in two other places in the app, but not sure

There is a problem with both dismissModal and goBack for cases where navigateBackTo leads to RHP.

If you look closely at the video for web, you'll see that the overlay doesn't work properly because we close the RHP and immediately open a new one.

To solve this, we can try to replace the validate account flow with the add bank account flow. This way RHP will stay opened the whole time.

Please try this Navigation.navigate(navigateBackTo, CONST.NAVIGATION.TYPE.UP). This should force replace action. You don't need any goBack() and dismissModal() with this solution.

I think it should work with other cases e.g. replacing the whole RHP with central pane but it's something worth checking.

Please let me know if the above works for you. Thanks! 🙇

Thanks for your advice @adamgrzybowski. I'll give it a try 👍

It's working well 🚀 . Should be ready for your final review @mountiny

melvin-bot · 2024-11-13T03:14:53Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-11-13T04:15:38Z

After merge main, after I entered the magic code, I got logged out 😂

hungvu193 · 2024-11-14T03:26:51Z

go ahead @getusha, the offending PR was reverted

getusha · 2024-11-14T15:32:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-14.at.11.25.32.at.night.mov

Android: mWeb Chrome

Screen.Recording.2024-11-14.at.11.16.00.at.night.mov

iOS: Native

Screen.Recording.2024-11-14.at.11.29.34.at.night.mov

iOS: mWeb Safari

Screen.Recording.2024-11-14.at.11.11.34.at.night.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-14.at.10.55.07.at.night.mov

MacOS: Desktop

Screen.Recording.2024-11-14.at.11.33.07.at.night.mov

src/pages/settings/Wallet/VerifyAccountPage.tsx

into feat/validate-invoice

src/libs/actions/User.ts

getusha

LGTM, tests well!

mountiny

One question

mountiny · 2024-11-18T15:32:21Z

src/pages/settings/Wallet/VerifyAccountPage.tsx

+        Navigation.goBack();
        Navigation.navigate(navigateBackTo);


@adamgrzybowski @WojtekBoman I am not sure if this is a best practice for managing the navigation. Should we use dismissModal here?

I see this goBack and navigate pattern in two other places in the app, but not sure

src/libs/actions/User.ts

src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

mountiny

Thank you!

OSBotify · 2024-11-19T17:35:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-21T01:44:20Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 9.0.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-22T19:48:23Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

hungvu193 added 2 commits November 12, 2024 14:02

add validate code to invoice page

9ca597a

add magic code status to verify account page

7469918

hungvu193 mentioned this pull request Nov 12, 2024

[HOLD for payment 2024-11-29] [HOLD for payment 2024-11-20] [HOLD for payment 2024-11-13] [$250] Add a step that collects the magic code when adding a VBBA #51166

Closed

8 tasks

hungvu193 added 2 commits November 13, 2024 09:12

update the content

65ef0d7

merge main

6a3b579

hungvu193 commented Nov 13, 2024

View reviewed changes

hungvu193 marked this pull request as ready for review November 13, 2024 03:14

hungvu193 requested a review from a team as a code owner November 13, 2024 03:14

melvin-bot bot requested review from getusha and removed request for a team November 13, 2024 03:14

fix navigation issue

7ef9a1f

merge main

77fd685

mountiny assigned hungvu193 Nov 14, 2024

mountiny self-requested a review November 14, 2024 17:47

getusha reviewed Nov 14, 2024

View reviewed changes

src/pages/settings/Wallet/VerifyAccountPage.tsx Show resolved Hide resolved

hungvu193 added 5 commits November 17, 2024 15:34

fix: exerises API called

1306bc2

fix: excesses API called

6a5e1fb

Merge branch 'feat/validate-invoice' of https://github.com/hungvu193/App

f944492

into feat/validate-invoice

fix typo

7550a55

Merge remote-tracking branch 'origin/main' into feat/validate-invoice

7e2a78e

hungvu193 requested a review from getusha November 18, 2024 10:35

getusha reviewed Nov 18, 2024

View reviewed changes

src/libs/actions/User.ts Show resolved Hide resolved

getusha approved these changes Nov 18, 2024

View reviewed changes

melvin-bot bot requested a review from pecanoro November 18, 2024 15:27

mountiny previously approved these changes Nov 18, 2024

View reviewed changes

pecanoro requested changes Nov 18, 2024

View reviewed changes

src/libs/actions/User.ts Outdated Show resolved Hide resolved

src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx Show resolved Hide resolved

use replace for navigate action

a5fb8b7

hungvu193 dismissed mountiny’s stale review via a5fb8b7 November 19, 2024 02:28

hungvu193 added 2 commits November 19, 2024 09:32

Address comment

b0bac5f

merge main

260291f

mountiny approved these changes Nov 19, 2024

View reviewed changes

mountiny changed the title ~~Feat: Add account validation step to Invoices page.~~ Feat: Add account validation step to Invoices page Nov 19, 2024

mountiny requested a review from pecanoro November 19, 2024 14:36

pecanoro approved these changes Nov 19, 2024

View reviewed changes

pecanoro merged commit e046ebe into Expensify:main Nov 19, 2024

github-actions bot mentioned this pull request Nov 21, 2024

Deploy Checklist: New Expensify 2024-11-21 #52862

Closed

65 tasks

melvin-bot bot mentioned this pull request Nov 22, 2024

[HOLD for payment 2024-11-29] Verify account - "Code requested" only shows in 2FA page after user opens contact method page #52336

Closed

8 tasks

Conversation

hungvu193 commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

hungvu193 Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 Nov 19, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 Nov 19, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 13, 2024

Uh oh!

hungvu193 commented Nov 13, 2024

Uh oh!

hungvu193 commented Nov 14, 2024

Uh oh!

getusha commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

getusha left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 19, 2024

Uh oh!

github-actions bot commented Nov 21, 2024

Uh oh!

github-actions bot commented Nov 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hungvu193 commented Nov 12, 2024 •

edited

Loading

getusha commented Nov 14, 2024 •

edited

Loading