fix: The shortcut CTRL + K does not work with a user as employee in a WS by truph01 · Pull Request #52448 · Expensify/App

truph01 · 2024-11-13T07:55:06Z

Explanation of Change

Fixed Issues

$ #52260
PROPOSAL: #52260 (comment)

Tests

Desktop/MacOS Chrome

Log in with any account in incognito mode
Turn on console and type: Onyx.set('nvp_onboarding', '{"selfTourViewed": true}');
Press the shortcut CTRL + K to open search dialog
Verify he shortcut CTRL + K to open the search dialog should open correctly

Mobile

Log in with new account in incognito mode
Verify the onboarding modal is displayed properly.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

New account:

Screen.Recording.2024-11-14.at.15.19.35.mov

Old account:

Screen.Recording.2024-11-14.at.15.20.23.mov

Android: mWeb Chrome

New account:

Screen.Recording.2024-11-14.at.15.17.26.mov

Old account:

Screen.Recording.2024-11-14.at.15.18.15.mov

iOS: Native

New account:

Screen.Recording.2024-11-14.at.15.15.31.mov

Old account:

Screen.Recording.2024-11-14.at.15.16.15.mov

iOS: mWeb Safari

- New account:

Screen.Recording.2024-11-14.at.15.12.23.mov

Old account:

Screen.Recording.2024-11-14.at.15.14.30.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-13.at.14.48.23.mov

MacOS: Desktop

Screen.Recording.2024-11-13.at.14.54.07.mov

melvin-bot · 2024-11-13T07:56:17Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

truph01 · 2024-11-13T07:59:02Z

@dukenv0307 The feature is only available on desktop devices, so I didn’t include test steps or screen recordings for mobile devices. Do you have any suggestions about the test steps for the rest platforms?

dukenv0307 · 2024-11-14T03:42:14Z

@truph01 This PR is reverted so we should include the tests for other places that uses hasCompletedGuidedSetupFlowSelector

dukenv0307 · 2024-11-14T04:01:29Z

There're 3 places that uses hasCompletedGuidedSetupFlowSelector:

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 51 in 99da1ac

const [isOnboardingCompleted = true] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {
App/src/libs/Navigation/NavigationRoot.tsx

Line 94 in 99da1ac

const [isOnboardingCompleted = true] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {
App/src/hooks/useOnboardingFlow.ts

Line 17 in 99da1ac

const [isOnboardingCompleted, isOnboardingCompletedMetadata] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {

But 2 first places already use fallback value so we just cover the 3rd one.

useOnboardingFlowRouter is used in AuthScreens

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 528 to 529 in 99da1ac

    
           {isOnboardingCompleted === false && ( 
        
               <RootStack.Screen

so we should test the normal onboarding flow for new/old account

dukenv0307 · 2024-11-14T04:41:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

New account:

web-resize.mp4

Old account:

Screen.Recording.2024-11-14.at.11.27.38.mov

Android: mWeb Chrome

New account:

web-resize.mp4

Old account:

Screen.Recording.2024-11-14.at.11.18.03.mov

iOS: Native

New account:

web-resize.mp4

Old account:

Screen.Recording.2024-11-14.at.11.23.58.mov

iOS: mWeb Safari

New account:

web-resize.mp4

Old account:

Screen.Recording.2024-11-14.at.11.12.08.mov

MacOS: Chrome / Safari

Old account:
https://github.com/user-attachments/assets/2b6a6a06-feaa-4c9e-a123-aac44f39bbac

New account:

Screen.Recording.2024-11-14.at.11.05.49.mov

MacOS: Desktop

New account:

web-resize.mp4

Old account:

Screen.Recording.2024-11-14.at.11.33.33.mov

dukenv0307 · 2024-11-14T04:42:53Z

I recorded videos on all platforms for new and old account

Note for a new account: Ensure the onboarding modal is shown at the beginning, after refreshing or navigating to another page.

truph01 · 2024-11-14T09:08:43Z

@dukenv0307 I just added all videos to my checklist

mountiny

Lets add the tests so we do not run into these issues again

src/libs/onboardingSelectors.ts

mountiny · 2024-11-15T13:56:53Z

@truph01 what is your ETA for the changes? thanks!

truph01 · 2024-11-18T09:22:36Z

I am working on it

truph01 · 2024-11-18T10:51:29Z

@dukenv0307 @mountiny I added the unit tests.

mountiny

@truph01 couple small changes

tests/unit/OnboardingSelectorsTest.ts

truph01 · 2024-11-18T18:41:37Z

I updated comments @mountiny

mountiny

Thank you very much for your patience 🙇

OSBotify · 2024-11-19T15:41:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-21T01:44:29Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-22T19:48:32Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: The shortcut CTRL + K does not work with a user as employee in a WS

7eb7812

truph01 marked this pull request as ready for review November 13, 2024 07:56

truph01 requested a review from a team as a code owner November 13, 2024 07:56

melvin-bot bot requested a review from dukenv0307 November 13, 2024 07:56

melvin-bot bot removed the request for review from a team November 13, 2024 07:56

truph01 added 2 commits November 13, 2024 15:05

refactor function

326cd80

fix: refactor hasCompletedGuidedSetupFlowSelector

7b6fb60

dukenv0307 mentioned this pull request Nov 13, 2024

[HOLD for payment 2024-11-29] [$250] Search - The shortcut CTRL + K does not work with a user as employee in a WS #52260

Closed

8 tasks

mountiny self-requested a review November 13, 2024 22:13

mountiny assigned truph01 Nov 13, 2024

merge main

675ef3e

dukenv0307 approved these changes Nov 14, 2024

View reviewed changes

mountiny requested changes Nov 14, 2024

View reviewed changes

src/libs/onboardingSelectors.ts Show resolved Hide resolved

dukenv0307 mentioned this pull request Nov 15, 2024

fix: prevent open search on onboarding route #52534

Merged

49 tasks

merge main

cd8f6a8

truph01 added 2 commits November 18, 2024 16:33

fix: Add unit test

495e9a3

fix: lint

5c3fa8e

mountiny requested changes Nov 18, 2024

View reviewed changes

fix: update comments

6da0b81

mountiny approved these changes Nov 19, 2024

View reviewed changes

mountiny merged commit e8ac6d4 into Expensify:main Nov 19, 2024

github-actions bot mentioned this pull request Nov 21, 2024

Deploy Checklist: New Expensify 2024-11-21 #52862

Closed

65 tasks

Conversation

truph01 commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Desktop/MacOS Chrome

Mobile

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 13, 2024

Uh oh!

truph01 commented Nov 13, 2024

Uh oh!

dukenv0307 commented Nov 14, 2024

Uh oh!

dukenv0307 commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Nov 14, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Nov 14, 2024

Uh oh!

truph01 commented Nov 14, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny commented Nov 15, 2024

Uh oh!

truph01 commented Nov 18, 2024

Uh oh!

truph01 commented Nov 18, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

truph01 commented Nov 18, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 19, 2024

Uh oh!

github-actions bot commented Nov 21, 2024

Uh oh!

github-actions bot commented Nov 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

truph01 commented Nov 13, 2024 •

edited

Loading

dukenv0307 commented Nov 14, 2024 •

edited

Loading