Add row to workspace chat in Workspace by nkdengineer · Pull Request #52449 · Expensify/App

nkdengineer · 2024-11-13T08:10:39Z

Explanation of Change

Fixed Issues

$ #51851
PROPOSAL: #51851 (comment)

Tests

Login to the app
Go to workspace list
Click on a workspace
Verify that: Submit expenses using your workspace chat below: is displayed in the bottom left
Click on workspace in the bottom left
Verify that: redirect to workspace chat

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-13.at.15.14.47.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-11-13T16:11:18Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-11-13T16:16:22Z

Can we use the same exact margin/padding that we have in the Inbox LHN?

Workspace LHN	Inbox LHN

src/pages/workspace/WorkspaceInitialPage.tsx

s77rt · 2024-11-13T16:53:30Z

Bug: The offline indicator should be at the bottom

nkdengineer · 2024-11-19T09:36:40Z

Bug: The offline indicator should be at the bottom

@s77rt Fixed this bug.

s77rt · 2024-11-19T10:42:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/pages/workspace/WorkspaceInitialPage.tsx

src/languages/en.ts

src/styles/index.ts

s77rt · 2024-11-19T10:43:34Z

Bug: Workspace created offline should have the chat menu item row with opacity reduced

dannymcclain · 2024-11-19T14:01:06Z

@Expensify/design do we want this label to be aligned with the workspace avatar?

Looks like right now it's aligned with the icons from the menu items.

nkdengineer · 2024-11-19T14:38:19Z

Can we use the same exact margin/padding that we have in the Inbox LHN?

@shawnborton What do you think? This is the reason why I added another margin/padding initially.

nkdengineer · 2024-11-19T14:43:22Z

@s77rt Should we also grey out the submit expense text?

s77rt · 2024-11-19T16:04:21Z

Overall looks good to me. I will retest and approve the PR after the design concerns are addressed.

Should we also grey out the submit expense text?

I don't have a strong preference, will let this to the design team as well

s77rt · 2024-11-19T16:09:10Z

There is just this "bug?" that I noticed but it exists in the app already (e.g. deep link from chat): If you put the workspace switcher on workspace A and go to workspace B and click on the row. The chat will be open without changing the workspace.

Screen.Recording.2024-11-19.at.5.06.33.PM.mov

shawnborton · 2024-11-19T19:00:40Z

I would think that label should be aligned with the workspace avatar right? That's what our mock has at least:

shawnborton · 2024-11-19T19:01:33Z

Should we also grey out the submit expense text?

For offline, I don't think we should "gray out" the text above the interactive element, we should only "gray out" the interactive element itself.

dannymcclain · 2024-11-19T21:10:18Z

Agree with both of your comments Shawn!

grgia

LGTM, let's have design do final confirmation once tests pass

src/components/MenuItem.tsx

nkdengineer · 2024-11-25T14:49:20Z

LGTM, let's have design do final confirmation once tests pass

@shawnborton Please help to get a final confirmation when you have a chance, thanks.

github-actions · 2024-11-25T14:51:01Z

🚧 @shawnborton has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-25T15:18:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52449/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/52449/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52449/NewExpensify.dmg	https://52449.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-11-25T15:21:19Z

Design looks good to me 👍

nkdengineer · 2024-11-26T05:15:17Z

@grgia Please help to review again when you have a chance.

grgia

Nice work on this!

shawnborton · 2024-11-26T12:28:41Z

Lovely, feel free to merge @grgia - all good on my end!

OSBotify · 2024-11-27T10:51:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-28T14:47:21Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.68-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mountiny · 2024-11-28T15:59:20Z

src/pages/workspace/WorkspaceInitialPage.tsx

                            ))}
                        </View>
                    </OfflineWithFeedback>
+                    <View style={[styles.pb4, styles.mh3, styles.mt3]}>


What if the workspace does not have workspace chats enabled, i dont see a check to not show the button in such case @nkdengineer

@mountiny This case will happen if isPolicyExpenseChatEnabled is false right?

github-actions · 2024-11-30T13:51:56Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.68-7 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

dukenv0307 · 2024-12-24T07:59:21Z

src/pages/workspace/WorkspaceInitialPage.tsx

+                                title={getReportName(currentUserPolicyExpenseChat)}
+                                description={translate('workspace.common.workspace')}
+                                icon={getIcons(currentUserPolicyExpenseChat, personalDetails)}
+                                onPress={() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(currentUserPolicyExpenseChat?.reportID ?? '-1'))}


Coming from #53665, we should add UP type here to prevent WS list opens in background.

Add row to workspace chat in Workspace

f88a717

nkdengineer marked this pull request as ready for review November 13, 2024 16:11

nkdengineer requested review from a team as code owners November 13, 2024 16:11

melvin-bot bot requested review from s77rt and removed request for a team November 13, 2024 16:11

s77rt suggested changes Nov 13, 2024

View reviewed changes

src/pages/workspace/WorkspaceInitialPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/WorkspaceInitialPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/WorkspaceInitialPage.tsx Outdated Show resolved Hide resolved

nkdengineer added 3 commits November 18, 2024 16:07

Merge branch 'main' into fix/51851

29ade25

fix: workspace init page style

46e39a7

only subscribe policyExpense chat report

e18dc37

fix lint

8629c81

s77rt suggested changes Nov 19, 2024

View reviewed changes

src/pages/workspace/WorkspaceInitialPage.tsx Outdated Show resolved Hide resolved

src/languages/en.ts Outdated Show resolved Hide resolved

src/styles/index.ts Outdated Show resolved Hide resolved

Merge branch 'main' into fix/51851

31ea888

grey out policy expense chat row when creating it offline

6ec4a0f

nkdengineer added 2 commits November 20, 2024 12:10

Merge branch 'main' into fix/51851

9ed82ac

update padding left

a1d4cdd

rename variable

ef84e97

grgia previously approved these changes Nov 22, 2024

View reviewed changes

s77rt approved these changes Nov 22, 2024

View reviewed changes

src/components/MenuItem.tsx Outdated Show resolved Hide resolved

src/components/MenuItem.tsx Outdated Show resolved Hide resolved

melvin-bot bot requested a review from grgia November 22, 2024 20:32

move the function to outside

0669d0c

nkdengineer dismissed grgia’s stale review via 0669d0c November 22, 2024 20:37

Merge branch 'main' into fix/51851

22300ac

shawnborton previously approved these changes Nov 25, 2024

View reviewed changes

merge main

ac0b229

nkdengineer dismissed shawnborton’s stale review via ac0b229 November 26, 2024 05:14

grgia approved these changes Nov 26, 2024

View reviewed changes

shawnborton approved these changes Nov 26, 2024

View reviewed changes

grgia merged commit bb74657 into Expensify:main Nov 27, 2024

github-actions bot mentioned this pull request Nov 28, 2024

Deploy Checklist: New Expensify 2024-11-28 #53245

Closed

72 tasks

mountiny reviewed Nov 28, 2024

View reviewed changes

garrettmknight mentioned this pull request Nov 28, 2024

Workspace - Not here page is displayed when opening row to workspace chat #53252

Closed

8 tasks

melvin-bot bot mentioned this pull request Nov 30, 2024

[HOLD for payment 2024-12-07] [$250] [NewDot Feature Request] Add route to WS chat in Workspace menu #51851

Closed

youssef-lr mentioned this pull request Dec 2, 2024

Revert "Add row to workspace chat in Workspace" #53402

Closed

s77rt mentioned this pull request Dec 13, 2024

[HOLD for payment 2024-12-17] Web - Workspace - Workspace tooltip does not adjust immediately after updating workspace name #53287

Closed

8 tasks

dukenv0307 reviewed Dec 24, 2024

View reviewed changes

DylanDylann mentioned this pull request Dec 22, 2025

Remove workspace chat section and link from workspace editor #78139

Merged

53 tasks

Conversation

nkdengineer commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 13, 2024

Uh oh!

shawnborton commented Nov 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s77rt commented Nov 13, 2024

Uh oh!

nkdengineer commented Nov 19, 2024

Uh oh!

s77rt commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s77rt commented Nov 19, 2024

Uh oh!

dannymcclain commented Nov 19, 2024

Uh oh!

nkdengineer commented Nov 19, 2024

Uh oh!

nkdengineer commented Nov 19, 2024

Uh oh!

s77rt commented Nov 19, 2024

Uh oh!

s77rt commented Nov 19, 2024

Uh oh!

shawnborton commented Nov 19, 2024

Uh oh!

shawnborton commented Nov 19, 2024

Uh oh!

dannymcclain commented Nov 19, 2024

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nkdengineer commented Nov 25, 2024

Uh oh!

github-actions bot commented Nov 25, 2024

Uh oh!

github-actions bot commented Nov 25, 2024

Uh oh!

shawnborton commented Nov 25, 2024

Uh oh!

nkdengineer commented Nov 26, 2024

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Nov 26, 2024

Uh oh!

OSBotify commented Nov 27, 2024

Uh oh!

github-actions bot commented Nov 28, 2024

Uh oh!

mountiny Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 30, 2024

Uh oh!

nkdengineer commented Nov 13, 2024 •

edited

Loading

s77rt commented Nov 19, 2024 •

edited

Loading